Skip Menu |

This queue is for tickets about the CGI-Simple CPAN distribution.

Report information
The Basics
Id: 130454
Status: resolved
Priority: 0/
Queue: CGI-Simple
People
Owner: MANWAR [...] cpan.org
Requestors: ROBINS [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in:
  • 1.18
  • 1.19
  • 1.20
  • 1.21
Fixed in: 1.22

History Show all quoted text
  Thu Sep 05 12:38:09 2019 ROBINS [...] cpan.org - Ticket created
Subject: The -samesite parameter in CGI::Simple::Cookie->new() is missing in cookie() method
It seems like the -samesite parameter in CGI::Simple::Cookie->new() is not part of the valid parameter list for the CGI::Simple cookie() method. Most likely this is an oversight when -samesite feature was implemented in 1.18.
  Fri Sep 06 11:08:23 2019 MANWAR [...] cpan.org - Correspondence added
You are correct, we missed it. I will patch the code and upload it first thing tomorrow morning.
  Fri Sep 06 11:08:23 2019 The RT System itself - Status changed from 'new' to 'open'
  Fri Sep 06 11:08:24 2019 MANWAR [...] cpan.org - Taken
  Fri Sep 06 11:08:47 2019 MANWAR [...] cpan.org - Severity Normal changed to Important
  Fri Sep 06 16:16:58 2019 robin [...] smidsrod.no - Correspondence added
Subject: Re: [rt.cpan.org #130454] The -samesite parameter in CGI::Simple::Cookie->new() is missing in cookie() method
Date: Fri, 6 Sep 2019 22:10:59 +0200
To: bug-CGI-Simple [...] rt.cpan.org, ROBINS [...] cpan.org
From: Robin Smidsrød <robin [...] smidsrod.no>
On 2019-09-06 17:08, Mohammad Sajid Anwar via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=130454 > > > You are correct, we missed it. > I will patch the code and upload it first thing tomorrow morning.
While you're at it - I also noticed the documentation for the samesite() accessor on CGI::Simple::Cookie is missing. Didn't actually verify if the sub is also missing, as I didn't use that feature (only used as_string). -- Robin
  Fri Sep 06 17:51:18 2019 MANWAR [...] cpan.org - Correspondence added
Indeed it was missing in the pod. I will fix that as well. Thanks for reporting.
  Sat Sep 07 16:47:20 2019 MANWAR [...] cpan.org - Correspondence added
https://metacpan.org/release/CGI-Simple v1.22
  Sat Sep 07 16:47:21 2019 MANWAR [...] cpan.org - Status changed from 'open' to 'resolved'
  Sat Sep 07 16:47:21 2019 MANWAR [...] cpan.org - Fixed in 1.22 added
  Sat Sep 07 19:37:36 2019 robin [...] smidsrod.no - Correspondence added
Subject: Re: [rt.cpan.org #130454] The -samesite parameter in CGI::Simple::Cookie->new() is missing in cookie() method
Date: Sun, 8 Sep 2019 01:37:22 +0200
To: bug-CGI-Simple [...] rt.cpan.org
From: Robin Smidsrød <robin [...] smidsrod.no>
On 2019-09-07 22:47, Mohammad Sajid Anwar via RT wrote: Show quoted text
> https://metacpan.org/release/CGI-Simple v1.22
Oh my, thanks for a very quick response! *clap* *clap* -- Robin