Bug #130445 for TermReadKey: Win32 term width

Wed Sep 04 03:48:20 2019 KUERBIS [...] cpan.org - Ticket created

Subject:

Win32 term width

ReadKey.xs - lines 505,506: if (retheight) *retheight = info.srWindow.Bottom - info.srWindow.Top; # 1 Top # 2 # 3 # 4 # 5 Bottom Should this be "Bottom + 1 - Top" instead of "Bottom - Top"?

Thu Sep 19 09:53:43 2019 jonathan.stowe [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #130445] Win32 term width
Date:	Thu, 19 Sep 2019 14:53:14 +0100
To:	bug-TermReadKey [...] rt.cpan.org
From:	Jonathan Stowe <jonathan.stowe [...] gmail.com>

Hi, I've copied this into https://github.com/jonathanstowe/TermReadKey/issues/32 on GitHub as that is easier to manage for me. Unfortunately I'm not in a position to test on Windows at the moment, but if you could send a pull request on Github I'll merge it as long as it passes the tests on the platforms I can test. Thanks. On Wed, 2019-09-04 at 03:48 -0400, Matthäus Kiem via RT wrote: Show quoted text

> Wed Sep 04 03:48:20 2019: Request 130445 was acted upon. > Transaction: Ticket created by KUERBIS > Queue: TermReadKey > Subject: Win32 term width > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: KUERBIS@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=130445 > > > > > ReadKey.xs - lines 505,506: > > if (retheight) > *retheight = info.srWindow.Bottom - info.srWindow.Top; > > # 1 Top > # 2 > # 3 > # 4 > # 5 Bottom > > Should this be "Bottom + 1 - Top" instead of "Bottom - Top"?

Thu Sep 19 09:53:44 2019 The RT System itself - Status changed from 'new' to 'open'

Fri Sep 20 05:50:26 2019 matthaeuskiem [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #130445] Win32 term width
Date:	Fri, 20 Sep 2019 11:49:59 +0200
To:	bug-TermReadKey [...] rt.cpan.org
From:	Matthäus Kiem <matthaeuskiem [...] gmail.com>

Hi, I've submitted a patch. Am 19.09.19 um 15:53 schrieb Jonathan Stowe via RT: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=130445 > > > Hi, > I've copied this into > https://github.com/jonathanstowe/TermReadKey/issues/32 on GitHub as > that is easier to manage for me. > > Unfortunately I'm not in a position to test on Windows at the moment, > but if you could send a pull request on Github I'll merge it as long as > it passes the tests on the platforms I can test. > > Thanks. > > On Wed, 2019-09-04 at 03:48 -0400, Matthäus Kiem via RT wrote:

>> Wed Sep 04 03:48:20 2019: Request 130445 was acted upon. >> Transaction: Ticket created by KUERBIS >> Queue: TermReadKey >> Subject: Win32 term width >> Broken in: (no value) >> Severity: (no value) >> Owner: Nobody >> Requestors: KUERBIS@cpan.org >> Status: new >> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=130445 > >> >> >> >> ReadKey.xs - lines 505,506: >> >> if (retheight) >> *retheight = info.srWindow.Bottom - info.srWindow.Top; >> >> # 1 Top >> # 2 >> # 3 >> # 4 >> # 5 Bottom >> >> Should this be "Bottom + 1 - Top" instead of "Bottom - Top"?