Bug #130420 for Type-Tiny-XS: Type::Tiny::XS identifies non-ints as ints

Originally reported on Github (https://github.com/tobyink/p5-type-tiny-xs/issues/8), but I think that's not where you want reports. I'm unsure. If I call int($num) on a floating point number, that number is subsequently identified as an integer, even when it's not. I suspected this is because the pIOK flag is set, but this might be a red herring (more later). Here's sample code which fails on every version (even .001) of Type:Tiny::XS that I've tested. This code replicates the issue: #!/usr/bin/env perl use Test::More; use Type::Tiny::XS; use Devel::Peek; diag $Type::Tiny::XS::VERSION; my $num = 3.14; Dump($num); ok !Type::Tiny::XS::Int($num), "$num should not be an integer"; Dump($num); { no warnings; int($num); } Dump($num); ok !Type::Tiny::XS::Int($num), "$num should not be an integer"; Dump($num); done_testing; And the output: type_tiny.t .. # 0.014 SV = NV(0x7fb6e4903088) at 0x7fb6e49030a0 REFCNT = 1 FLAGS = (NOK,pNOK) NV = 3.14 ok 1 - 3.14 should not be an integer not ok 2 - 3.14 should not be an integer SV = PVNV(0x7fb6e48027f0) at 0x7fb6e49030a0 REFCNT = 1 FLAGS = (NOK,pNOK) IV = 0 NV = 3.14 PV = 0x7fb6e45df090 "3.14"\0 CUR = 4 LEN = 32 SV = PVNV(0x7fb6e48027f0) at 0x7fb6e49030a0 REFCNT = 1 FLAGS = (NOK,pIOK,pNOK) IV = 3 NV = 3.14 PV = 0x7fb6e45df090 "3.14"\0 CUR = 4 LEN = 32 # Failed test '3.14 should not be an integer' # at type_tiny.t line 16. SV = PVNV(0x7fb6e48027f0) at 0x7fb6e49030a0 REFCNT = 1 FLAGS = (NOK,pIOK,pNOK) IV = 3 NV = 3.14 PV = 0x7fb6e45df090 "3.14"\0 CUR = 4 LEN = 32 1..2 # Looks like you failed 1 test of 2. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests And I suspect this is the cause of the same int bug reported by Peter Mottram. However, all versions of Perl we've tested have pIOK set and this might be a red herring. I found the problem in a large codebase and reduced it to this: perl -MTypes::Standard=is_Int -E \ 'my $num = 3.14; say is_Int($num)?"Yes":"No"; int($num); say is_Int($num)?"Yes":"No";say $num' On my box, that shows: No Yes 3.14 The code appears to be correct when we use the PP version of Type::Tiny, but is incorrect with the XS version.