Bug #130243 for Firefox-Marionette: Firefox-Marionette-0.79 bug

Thu Aug 01 15:06:01 2019 kiskom [...] digikabel.hu - Ticket created

Subject:	Firefox-Marionette-0.79 bug
Date:	Thu, 01 Aug 2019 21:05:46 +0200
To:	bug-firefox-marionette [...] rt.cpan.org
From:	kiskom <kiskom [...] digikabel.hu>

Dear David, When I use Firefox-Marionette-0.79 the method delete_session closes firefox window instead of deleting the current WebDriver session. Best regards Sándor Kiss

Thu Aug 01 15:25:29 2019 DDICK [...] cpan.org - Correspondence added

On Fri Aug 02 05:06:01 2019, kiskom@digikabel.hu wrote: Show quoted text

> When I use Firefox-Marionette-0.79 the method delete_session closes > firefox window instead of deleting the current WebDriver session.

Not quite sure what you mean. When the Firefox::Marionette object goes out of scope, it automatically closes the firefox window. Can you supply a example bit of code? Cheers David

Thu Aug 01 15:25:29 2019 The RT System itself - Status changed from 'new' to 'open'

Fri Aug 02 05:33:08 2019 kiskom [...] digikabel.hu - Correspondence added

Subject:	[rt.cpan.org #130243] Firefox::Marionette-0.79 bug
Date:	Fri, 2 Aug 2019 11:32:43 +0200
To:	bug-firefox-marionette [...] rt.cpan.org
From:	kiskom [...] digikabel.hu

Dear David ,

I use Firefox::Marionette mainly for performing login action .
After compliting initial action I would like the program to be exited and I manually interact with browser.
So I call delete_session and then exit.

use v5.20;
use warnings;
use Firefox::Marionette;
#_21

my $uri='https://perldoc.pl';

say "$uri\nStarting firefox obj.creation... ",scalar localtime;
my $firefox = Firefox::Marionette->new(visible=>1);
say "Completed firefox obj.creation... ",scalar localtime;
$firefox->go($uri);
say "Completed go \$uri ",scalar localtime;

say "I am going to delete Marionette session, I expect firefox
to be remain on screen for user interaction. ",scalar localtime;
$firefox->delete_session;
say "After deleteing Marionette session, I expect firefox
to be remain on screen for user interaction. ",scalar localtime;
sleep 10;

say "After End of $0 program I expect firefox
to be remain on screen for user interaction. ",scalar localtime;
exit;

Firefox::Marionette-0.79 exit makes browser window close, while
previouse version of Firefox::Marionette left the browser window open for user interaction.

Best regards,

Sándor

Fri Aug 02 08:21:02 2019 DDICK [...] cpan.org - Correspondence added

On Fri Aug 02 19:33:08 2019, kiskom@digikabel.hu wrote: Show quoted text

> Dear David , > > I use Firefox::Marionette mainly for performing login action . > After compliting initial action I would like the program to be exited > and I > manually interact with browser. > So I call delete_session and then exit.

Unfortunately, the only reason why this worked was a bug in the delete_session method. I believe the correct thing to do is to keep the delete_session method in it's fixed state, but provide you with an alternative method to accomplish your goal. I propose a patch (to be released as 0.80) which will allow a program like so; my $firefox = Firefox::Marionette->new(survive => 1, visible => 1)->go('https://perldoc.pl'); to leave firefox on screen when the $firefox variable goes out of scope (and the program exits) Would that be acceptable? Cheers David

Fri Aug 02 10:16:25 2019 kiskom [...] digikabel.hu - Correspondence added

Subject:	Re: [rt.cpan.org #130243] Firefox-Marionette-0.79 bug
Date:	Fri, 02 Aug 2019 16:16:06 +0200
To:	bug-Firefox-Marionette [...] rt.cpan.org
From:	kiskom <kiskom [...] digikabel.hu>

Dear David, I accept Your suggestion . Thanks. Best regards, Sándor 2019.08.02 14:21 időpontban David Dick via RT ezt írta: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=130243 > > > On Fri Aug 02 19:33:08 2019, kiskom@digikabel.hu wrote:

>> Dear David , >> >> I use Firefox::Marionette mainly for performing login action . >> After compliting initial action I would like the program to be exited >> and I >> manually interact with browser. >> So I call delete_session and then exit.

> > Unfortunately, the only reason why this worked was a bug in the > delete_session method. > > I believe the correct thing to do is to keep the delete_session method > in it's fixed state, but provide you with an alternative method to > accomplish your goal. > > I propose a patch (to be released as 0.80) which will allow a program > like so; > > my $firefox = Firefox::Marionette->new(survive => 1, visible => > 1)->go('https://perldoc.pl'); > > to leave firefox on screen when the $firefox variable goes out of > scope (and the program exits) > > Would that be acceptable? > > Cheers > David

Sun Aug 04 01:47:11 2019 DDICK [...] cpan.org - Correspondence added

Fixed.

Sun Aug 04 01:47:12 2019 DDICK [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Aug 04 01:47:12 2019 DDICK [...] cpan.org - Fixed in 0.80 added

Mon Aug 05 02:06:25 2019 kiskom [...] digikabel.hu - Correspondence added

Subject:	Re: [rt.cpan.org #130243] Resolved: Firefox-Marionette-0.79 bug
Date:	Mon, 05 Aug 2019 08:06:08 +0200
To:	bug-Firefox-Marionette [...] rt.cpan.org
From:	kiskom <kiskom [...] digikabel.hu>

Dear David, I suggest including some explanation concerning "interactive" from page https://developer.mozilla.org/en-US/docs/Web/API/Document/readyState into Marionett documentation. Now I use page_load_strategy => eager with 0.80 version, and so my programs run as I expected. Thanks Sándor 2019.08.04 07:47 időpontban David Dick via RT ezt írta: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=130243 > > > According to our records, your request has been resolved. If you have > any > further questions or concerns, please respond to this message.