Bug #130167 for invoker: invoker: t/03ourself.t segfaults on perl-5.31.2 on FreeBSD-12

Wed Jul 24 16:52:17 2019 jkeenan [...] cpan.org - Ticket created

Subject:

invoker: t/03ourself.t segfaults on perl-5.31.2 on FreeBSD-12

This was observed in the course of CPAN-River-3000 testing on perl-5.31.2 on FreeBSD-12. Excerpt: ##### ... "t/03ourself.t .. ", "No subtests run ", "", "Test Summary Report", "-------------------", "t/03ourself.t (Wstat: 139 Tests: 0 Failed: 0)", " Non-zero wait status: 139", " Parse errors: No plan found in TAP output", "Files=3, Tests=18, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.34 cusr 0.27 csys = 0.63 CPU)", "Result: FAIL", [invoker-0.35] $ thisperl -Ilib -Iblib/lib -Iblib/arch/auto/invoker/ t/03ourself.t Segmentation fault (core dumped) ##### Thank you very much. Jim Keenan

Fri Jul 26 11:47:24 2019 ANDK [...] cpan.org - Correspondence added

Xref: https://rt.perl.org/Public/Bug/Display.html?id=134316

Fri Jul 26 11:47:25 2019 The RT System itself - Status changed from 'new' to 'open'

Sun Jul 28 02:24:01 2019 ANDK [...] cpan.org - Broken in 0.35 added

Mon Aug 05 14:51:47 2019 jkeenan [...] cpan.org - Correspondence added

On Fri Jul 26 11:47:24 2019, ANDK wrote: Show quoted text

> Xref: https://rt.perl.org/Public/Bug/Display.html?id=134316

Please find patch attached based on discussion between Dave Mitchell and H Merijn Brand in the RT cited above. This has been tested on threaded builds on perl-5.28.0 and on perl 5 blead (v5.31.3 (v5.31.2-26-ga377c856ab)) on FreeBSD-12. Please test on other platforms and do a new CPAN release at your earliest opportunity. Thank you very much. Jim Keenan

Subject:

invoker.xs.diff

65,66c65,66 < // "$self" was defined as a package variable -- use it < cUNOPx(arg)->op_first = newGVOP( --- > /** "$self" was defined as a package variable; use it **/ > OP *new_gvop = newGVOP( 70a71,76 > #if PERL_REVISION == 5 && PERL_VERSION >= 26 > op_sibling_splice(arg, NULL, 1, new_gvop); > #else > cUNOPx(arg)->op_first = new_gvop; > #endif > op_free(gvop);

Mon Oct 28 19:30:24 2019 GUGOD [...] cpan.org - Correspondence added

I reproduced the error on macOS 10.14 and Ubunto Disco and confirmed that the patch fixes for both. A new version (0.36) is just released. Thanks everyone for the effort!

Wed Oct 14 05:55:27 2020 SREZIC [...] cpan.org - Correspondence added

On 2019-10-28 19:30:24, GUGOD wrote: Show quoted text

> I reproduced the error on macOS 10.14 and Ubunto Disco and confirmed > that the patch fixes for both. > > A new version (0.36) is just released. > > Thanks everyone for the effort!

I think this ticket can be closed (I would do it, but I cannot).

Wed Oct 14 05:55:28 2020 SREZIC [...] cpan.org - Fixed in 0.36 added

Wed Oct 14 07:39:48 2020 jkeenan [...] cpan.org - Status changed from 'open' to 'resolved'