Bug #130096 for XML-Compile-SOAP: Erroneous removal of dependency on Test::Deep

V=2.36 removes the dependency on Test::Deep, however:

The tests still used it in 2.36: https://metacpan.org/source/MARKOV/XML-Compile-SOAP-2.36/t/12soapmust.t#L9

And the tests still use it in 3.24: https://metacpan.org/source/MARKOV/XML-Compile-SOAP-3.24/t/12soapmust.t#L9


$ cpanm --look XML::Compile::SOAP
--> Working on XML::Compile::SOAP
Fetching http://www.cpan.org/authors/id/M/MA/MARKOV/XML-Compile-SOAP-3.24.tar.gz ... OK
Entering /home/kent/.cpanm/work/1563363394.30115/XML-Compile-SOAP-3.24 with /bin/bash
$ grep 'Deep' -r .
./t/12soapmust.t:use Test::Deep   qw/cmp_deeply/;
./t/10soap.t:use Test::Deep   qw/cmp_deeply/;
./t/30charenc.t:use Test::Deep   qw/cmp_deeply/;
./t/01use.t:    Test::Deep
./t/11soapfault.t:use Test::Deep   qw/cmp_deeply/;
./t/60xop.t:use Test::Deep   qw/cmp_deeply/;
./ChangeLog:    - remove dependency for Test::Deep


That this still manages to pass tests is part miracle, relying on the weak indirect dependency via XML::Compile and XML::Compile tester.

*HOWEVER*, if one installs both of those packages without testing them, or installing their test dependencies, then XML-Compile-SOAP cannot be tested.

Suggested paths are to either remove the use of Test::Deep in tests entirely, or reinstate the test_requires dependency.

-- 
- CPAN kentnl@cpan.org
- Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )