Skip Menu |

This queue is for tickets about the Perl-Tidy CPAN distribution.

Report information
The Basics
Id: 130008
Status: resolved
Priority: 0/
Queue: Perl-Tidy

People
Owner: Nobody in particular
Requestors: violapiratejunky [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 20190601
Fixed in: (no value)



Subject: --break-at-old-method-breakpoints not working
I am setting -bom in my .perltidyrc, and code like this: $object ->this_method() ->then_that_method(); All gets put onto one line: $object->this_method()->then_that_method()
Subject: Re: [rt.cpan.org #130008] --break-at-old-method-breakpoints not working
Date: Mon, 8 Jul 2019 16:40:12 -0700
To: bug-Perl-Tidy [...] rt.cpan.org
From: Steven Hancock <s7078hancock [...] gmail.com>
I haven't been able to reproduce this. On Sun, Jul 7, 2019 at 3:10 PM Adam Hopkins via RT < bug-Perl-Tidy@rt.cpan.org> wrote: Show quoted text
> Sun Jul 07 18:10:16 2019: Request 130008 was acted upon. > Transaction: Ticket created by srchulo > Queue: Perl-Tidy > Subject: --break-at-old-method-breakpoints not working > Broken in: 20190601 > Severity: Normal > Owner: Nobody > Requestors: violapiratejunky@gmail.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=130008 > > > > I am setting -bom in my .perltidyrc, and code like this: > > $object > ->this_method() > ->then_that_method(); > > All gets put onto one line: > > $object->this_method()->then_that_method() >
I'm using: perl 5, version 28, subversion 1 (v5.28.1) built for darwin-2level Code::TidyAll 0.74 Perl::Tidy 20190601 The command I'm running is: tidyall lib/My/Module.pm -nst -cab=0 -w -l=120 # 120 characters per line -ce # 'cuddled' elses. elses appear on the same line as last brace -pt=2 # no parentheses spacing -pt=2 # High parenthesis tightness -bt=2 # High brace tightness -sbt=2 # High square bracket tightness -bar # opening braces right -nsbl # open subroutine brace on right -bbvt=1 # Block Brace Vertical Tightness -sot # stack opening tokens -sct # stack closing tokens -nsfs # no For Loop Semicolon Spaces -nolq # don't outdent long strings -isbc # --indent-spaced-block-comments -boc # --break-at-old-comma-breakpoints -bom -iob Should I not be using tidyall? Should I maybe try with a different command? Could you share the command that you are running with? On Mon Jul 08 19:40:30 2019, s7078hancock@gmail.com wrote: Show quoted text
> I haven't been able to reproduce this. > > On Sun, Jul 7, 2019 at 3:10 PM Adam Hopkins via RT < > bug-Perl-Tidy@rt.cpan.org> wrote: >
> > Sun Jul 07 18:10:16 2019: Request 130008 was acted upon. > > Transaction: Ticket created by srchulo > > Queue: Perl-Tidy > > Subject: --break-at-old-method-breakpoints not working > > Broken in: 20190601 > > Severity: Normal > > Owner: Nobody > > Requestors: violapiratejunky@gmail.com > > Status: new > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=130008 > > > > > > > I am setting -bom in my .perltidyrc, and code like this: > > > > $object > > ->this_method() > > ->then_that_method(); > > > > All gets put onto one line: > > > > $object->this_method()->then_that_method() > >
On Mon Jul 08 20:59:45 2019, srchulo wrote: Show quoted text
> I'm using: > > perl 5, version 28, subversion 1 (v5.28.1) built for darwin-2level > Code::TidyAll 0.74 > Perl::Tidy 20190601 > > The command I'm running is: > > tidyall lib/My/Module.pm > > -nst > -cab=0 > -w > -l=120 # 120 characters per line > -ce # 'cuddled' elses. elses appear on the same line as last brace > -pt=2 # no parentheses spacing > -pt=2 # High parenthesis tightness > -bt=2 # High brace tightness > -sbt=2 # High square bracket tightness > -bar # opening braces right > -nsbl # open subroutine brace on right > -bbvt=1 # Block Brace Vertical Tightness > -sot # stack opening tokens > -sct # stack closing tokens > -nsfs # no For Loop Semicolon Spaces > -nolq # don't outdent long strings > -isbc # --indent-spaced-block-comments > -boc # --break-at-old-comma-breakpoints > -bom > -iob > > > Should I not be using tidyall? Should I maybe try with a different > command? Could you share the command that you are running with? > > On Mon Jul 08 19:40:30 2019, s7078hancock@gmail.com wrote:
> > I haven't been able to reproduce this. > > > > On Sun, Jul 7, 2019 at 3:10 PM Adam Hopkins via RT < > > bug-Perl-Tidy@rt.cpan.org> wrote: > >
> > > Sun Jul 07 18:10:16 2019: Request 130008 was acted upon. > > > Transaction: Ticket created by srchulo > > > Queue: Perl-Tidy > > > Subject: --break-at-old-method-breakpoints not working > > > Broken in: 20190601 > > > Severity: Normal > > > Owner: Nobody > > > Requestors: violapiratejunky@gmail.com > > > Status: new > > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=130008 > > > > > > > > > > I am setting -bom in my .perltidyrc, and code like this: > > > > > > $object > > > ->this_method() > > > ->then_that_method(); > > > > > > All gets put onto one line: > > > > > > $object->this_method()->then_that_method() > > >
It will work if you remove the '-iob' flag. This flag tells perltidy to ignore old breakpoints, but the -bom flag needs to see them to function. Steve
ugh. Sorry about that. Thanks for the pointer! All of the options in Perl::Tidy are both a blessing and a curse :) Thank you for all of your hard work! On Mon Jul 08 21:29:28 2019, SHANCOCK wrote: Show quoted text
> On Mon Jul 08 20:59:45 2019, srchulo wrote:
> > I'm using: > > > > perl 5, version 28, subversion 1 (v5.28.1) built for darwin-2level > > Code::TidyAll 0.74 > > Perl::Tidy 20190601 > > > > The command I'm running is: > > > > tidyall lib/My/Module.pm > > > > -nst > > -cab=0 > > -w > > -l=120 # 120 characters per line > > -ce # 'cuddled' elses. elses appear on the same line as last brace > > -pt=2 # no parentheses spacing > > -pt=2 # High parenthesis tightness > > -bt=2 # High brace tightness > > -sbt=2 # High square bracket tightness > > -bar # opening braces right > > -nsbl # open subroutine brace on right > > -bbvt=1 # Block Brace Vertical Tightness > > -sot # stack opening tokens > > -sct # stack closing tokens > > -nsfs # no For Loop Semicolon Spaces > > -nolq # don't outdent long strings > > -isbc # --indent-spaced-block-comments > > -boc # --break-at-old-comma-breakpoints > > -bom > > -iob > > > > > > Should I not be using tidyall? Should I maybe try with a different > > command? Could you share the command that you are running with? > > > > On Mon Jul 08 19:40:30 2019, s7078hancock@gmail.com wrote:
> > > I haven't been able to reproduce this. > > > > > > On Sun, Jul 7, 2019 at 3:10 PM Adam Hopkins via RT < > > > bug-Perl-Tidy@rt.cpan.org> wrote: > > >
> > > > Sun Jul 07 18:10:16 2019: Request 130008 was acted upon. > > > > Transaction: Ticket created by srchulo > > > > Queue: Perl-Tidy > > > > Subject: --break-at-old-method-breakpoints not working > > > > Broken in: 20190601 > > > > Severity: Normal > > > > Owner: Nobody > > > > Requestors: violapiratejunky@gmail.com > > > > Status: new > > > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=130008 > > > > > > > > > > > > > I am setting -bom in my .perltidyrc, and code like this: > > > > > > > > $object > > > > ->this_method() > > > > ->then_that_method(); > > > > > > > > All gets put onto one line: > > > > > > > > $object->this_method()->then_that_method() > > > >
> > It will work if you remove the '-iob' flag. This flag tells perltidy > to ignore old breakpoints, but the -bom flag needs to see them to > function. > Steve
No problem ... I have added a warning message for this conflict. Steve