Skip Menu |

This queue is for tickets about the IO-Socket-ByteCounter CPAN distribution.

Report information
The Basics
Id: 129909
Status: resolved
Priority: 0/
Queue: IO-Socket-ByteCounter

People
Owner: Nobody in particular
Requestors: TONYC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: test calls $socket->send() with a TO parameter on a connected socket
The tests for IO::Socket::ByteCounter call send() with a TO parameter on a connected socket. Recently in bleadperl, the IO::Socket send() method was changed to always supply the TO parameter to the underlying CORE::send() function if the TO parameter is supplied to IO::Socket::send(), since this works for at least UDP sockets on Linux. It doesn't work for UNIX sockets, and means the tests hang due to the failed send call (which the test doesn't check for.) I suggest removing the 'peer' parameter from both calls to send() in the test code. Tony reported against perl as https://rt.perl.org/Ticket/Display.html?id=134224
On Tue Jun 25 20:12:08 2019, TONYC wrote: Show quoted text
> The tests for IO::Socket::ByteCounter call send() with a TO parameter > on a connected socket. > > Recently in bleadperl, the IO::Socket send() method was changed to > always supply the TO parameter to the underlying CORE::send() function > if the TO parameter is supplied to IO::Socket::send(), since this > works for at least UDP sockets on Linux. > > It doesn't work for UNIX sockets, and means the tests hang due to the > failed send call (which the test doesn't check for.) > > I suggest removing the 'peer' parameter from both calls to send() in > the test code. > > Tony > > reported against perl as > https://rt.perl.org/Ticket/Display.html?id=134224
Daniel Muey: The release of perl-5.32 is nearing, after which this module will fail its tests. Can you try out the fix recommended by Tony Cook above? Thank you very much. Jim Keenan
I'll try to prioritize this thanks! n Wed Apr 01 07:35:55 2020, JKEENAN wrote: Show quoted text
> On Tue Jun 25 20:12:08 2019, TONYC wrote:
> > The tests for IO::Socket::ByteCounter call send() with a TO parameter > > on a connected socket. > > > > Recently in bleadperl, the IO::Socket send() method was changed to > > always supply the TO parameter to the underlying CORE::send() > > function > > if the TO parameter is supplied to IO::Socket::send(), since this > > works for at least UDP sockets on Linux. > > > > It doesn't work for UNIX sockets, and means the tests hang due to the > > failed send call (which the test doesn't check for.) > > > > I suggest removing the 'peer' parameter from both calls to send() in > > the test code. > > > > Tony > > > > reported against perl as > > https://rt.perl.org/Ticket/Display.html?id=134224
> > Daniel Muey: The release of perl-5.32 is nearing, after which this > module will fail its tests. Can you try out the fix recommended by > Tony Cook above? > > Thank you very much. > Jim Keenan
On Wed Apr 01 09:21:14 2020, DMUEY wrote: Show quoted text
> I'll try to prioritize this thanks! >
I believe this is now broken on 5.32.0
Thanks! Resolved in v0.3 just uploaded to CPAN