Bug #129729 for Type-Tiny: Union with Enum with a value containing a '-' character fails

Sat Jun 01 21:30:22 2019 djerius [...] cpan.org - Ticket created

Subject:

Union with Enum with a value containing a '-' character fails

The following code use strict; use warnings; use Types::Standard qw[ Bool Enum ]; my $x = Bool | Enum [ 'start-end', 'end' ]; produces an error: Expected R_BRACKET; got TYPE at [...]/lib/site_perl/5.28.1/Type/Parser.pm line 391. Changing the '-' in 'start-end' to any other character (well, any that I've tried!) makes it behave.

Sat Jun 01 22:12:45 2019 djerius [...] cpan.org - Correspondence added

On Sat Jun 01 21:30:22 2019, DJERIUS wrote: Show quoted text

> The following code > > use strict; > use warnings; > > use Types::Standard qw[ Bool Enum ]; > > my $x = Bool | Enum [ 'start-end', 'end' ]; > > produces an error: > > Expected R_BRACKET; got TYPE at > [...]/lib/site_perl/5.28.1/Type/Parser.pm line 391. > > Changing the '-' in 'start-end' to any other character (well, any that > I've tried!) makes it behave.

On further investigation, I can't reproduce this on a clean install of Type::Tiny on a clean install of Perl. Still investigating...

Sat Jun 01 22:22:23 2019 djerius [...] cpan.org - Correspondence added

On Sat Jun 01 22:12:45 2019, DJERIUS wrote: Show quoted text

> On Sat Jun 01 21:30:22 2019, DJERIUS wrote:

> > The following code > > > > use strict; > > use warnings; > > > > use Types::Standard qw[ Bool Enum ]; > > > > my $x = Bool | Enum [ 'start-end', 'end' ]; > > > > produces an error: > > > > Expected R_BRACKET; got TYPE at > > [...]/lib/site_perl/5.28.1/Type/Parser.pm line 391. > > > > Changing the '-' in 'start-end' to any other character (well, any > > that > > I've tried!) makes it behave.

> > > On further investigation, I can't reproduce this on a clean install of > Type::Tiny on a clean install of Perl. > > Still investigating...

The unexpected behavior requires Type::Tiny::XS to be installed. With it: % perl -d:Modlist -Ilocal/lib/perl5 opt.pl Expected R_BRACKET; got TYPE at local/lib/perl5/Type/Parser.pm line 391. B 1.74 Error::TypeTiny 1.004004 Eval::TypeTiny 1.004004 Exporter 5.73 Exporter::Tiny 1.002001 List::Util 1.5 Scalar::Util 1.5 Sub::Util 1.5 Type::Coercion 1.004004 Type::Library 1.004004 Type::Parser 1.004004 Type::Tiny 1.004004 Type::Tiny::Enum 1.004004 Type::Tiny::Union 1.004004 Type::Tiny::XS 0.014 Types::Standard 1.004004 Types::TypeTiny 1.004004 XSLoader 0.30 overload 1.30 overloading 0.02 re 0.36 warnings 1.42 warnings::register 1.04 Without it: % perl -d:Modlist -Ilocal/lib/perl5 opt.pl B 1.74 Eval::TypeTiny 1.004004 Exporter 5.73 Exporter::Tiny 1.002001 List::Util 1.5 Scalar::Util 1.5 Sub::Util 1.5 Type::Coercion 1.004004 Type::Coercion::Union 1.004004 Type::Library 1.004004 Type::Tiny 1.004004 Type::Tiny::Enum 1.004004 Type::Tiny::Union 1.004004 Types::Standard 1.004004 Types::TypeTiny 1.004004 XSLoader 0.30 overload 1.30 overloading 0.02 re 0.36 warnings 1.42 warnings::register 1.04

Sun Jun 02 04:21:30 2019 perl [...] toby.ink - Correspondence added

Yeah, Type::Tiny communicates with Type::Tiny::XS by stringifying the type constraint and parsing the string. This seems to be an error in Type::Parser, or an error stringifying it. Type::Tiny::Enum actually has a check to make sure none of the strings match /^-/ before attempting to use XS. Maybe if I generalize that to any hyphens (or maybe even any non-word characters), it will help.

Sun Jun 02 04:21:31 2019 The RT System itself - Status changed from 'new' to 'open'

Sun Jun 02 04:22:19 2019 perl [...] toby.ink - Correspondence added

PS: as a workaround, use StrMatch instead of Enum. Bool | StrMatch[qr/^(start-)?end$/]

Sun Jun 02 08:47:30 2019 djerius [...] cpan.org - Correspondence added

On Sun Jun 02 04:22:19 2019, TOBYINK wrote: Show quoted text

> PS: as a workaround, use StrMatch instead of Enum. > > Bool | StrMatch[qr/^(start-)?end$/]

Thanks. That'll do it.

Mon Nov 11 17:25:42 2019 perl [...] toby.ink - Severity Normal added

Sun Nov 17 06:59:41 2019 perl [...] toby.ink - Correspondence added

Fixed in repo.

Sun Nov 17 06:59:41 2019 perl [...] toby.ink - Status changed from 'open' to 'patched'

Sat Dec 07 11:56:56 2019 perl [...] toby.ink - Correspondence added

Fixed in Type::Tiny 1.007_xxx.

Sat Dec 07 11:56:56 2019 perl [...] toby.ink - Status changed from 'patched' to 'resolved'

Thu Dec 12 16:13:11 2019 djerius [...] cpan.org - Correspondence added

On Sat Dec 07 11:56:56 2019, TOBYINK wrote: Show quoted text

> Fixed in Type::Tiny 1.007_xxx.

Thanks!