Bug #129677 for Module-Info: [PATCH] Fails with 5.8.1

Sat May 25 02:35:15 2019 ANDK [...] cpan.org - Ticket created

Subject:

[PATCH] Fails with 5.8.1

Would you consider a patch for nothing but to regain 5.8.1 compat? Appended with Greets from Berlin:)

Subject:

0001-regain-compat-581-Module-Info-0.37.diff

--- lib/Module/Info.pm~ 2015-11-01 15:30:19.000000000 +0000 +++ lib/Module/Info.pm 2019-05-25 06:24:09.947960306 +0000 @@ -336,7 +336,7 @@ my $filename = $self->file; - open my $file, $filename or return; # the file won't even open + open my($file), $filename or return; # the file won't even open while( <$file> ) { return $filename if /^=[a-z]/;

Sun May 26 15:40:00 2019 haarg [...] haarg.org - Correspondence added

Possibly a better fix is to switch to 3 arg open, which will also prevent the warning. Patch attached.

Subject:

module-info-fix-581.diff

--- lib/Module/Info.pm~ 2019-05-26 21:35:47.000000000 +0200 +++ lib/Module/Info.pm 2019-05-26 21:35:50.000000000 +0200 @@ -336,7 +336,7 @@ my $filename = $self->file; - open my $file, $filename or return; # the file won't even open + open my $file, '<', $filename or return; # the file won't even open while( <$file> ) { return $filename if /^=[a-z]/; @@ -348,7 +348,7 @@ return unless -f $filename; - open $file, $filename or return; + open $file, '<', $filename or return; while( <$file> ) { return $filename if /^=[a-z]/;

Sun May 26 15:40:01 2019 The RT System itself - Status changed from 'new' to 'open'

Tue May 28 01:50:04 2019 andreas.koenig.7os6VVqR [...] franz.ak.mind.de - Correspondence added

CC:	ANDK [...] cpan.org
Subject:	Re: [rt.cpan.org #129677] [PATCH] Fails with 5.8.1
Date:	Tue, 28 May 2019 07:49:45 +0200
To:	"Graham Knop via RT" <bug-Module-Info [...] rt.cpan.org>
From:	Andreas Koenig <andreas.koenig.7os6VVqR [...] franz.ak.mind.de>

Show quoted text

> Possibly a better fix is to switch to 3 arg open, which will also prevent the warning. Patch attached.

Thanks, Graham, I didn't know of this resolution, much better! -- andreas