Skip Menu |

This queue is for tickets about the Devel-PatchPerl CPAN distribution.

Report information
The Basics
Id: 129548
Status: resolved
Priority: 0/
Queue: Devel-PatchPerl

People
Owner: Nobody in particular
Requestors: bsmith [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.58
Fixed in: 1.60



_patch_conf_fwrapv has been added by 1.58 and it is a patch to Configure. However, Devel::PatchPerl calls patch with -p0 and the diff in _patch_conf_fwrapv uses {a/,b/} causing the patching to fail: Auto-guessed '5.16.2' patching Configure File Configure is read-only; trying to patch anyway patching ext/Errno/Errno_pm.PL File ext/Errno/Errno_pm.PL is read-only; trying to patch anyway patching b/Configure The text leading up to this was: -------------------------- |diff --git a/Configure b/Configure |index 15b3da1769..791889a2ab 100755 |--- a/Configure |+++ b/Configure -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored Died at /mnt/testssd/perl/patchperl/perl5lib/lib/perl5/Devel/PatchPerl.pm line 416. The attached patch removes the a/ and b/ on the +++ and --- lines to match other example s of patches in the module.
Subject: patch
Download patch
application/octet-stream 432b

Message body not shown because it is not plain text.

On Sun May 12 14:55:16 2019, BSMITH wrote: Show quoted text
> _patch_conf_fwrapv has been added by 1.58 and it is a patch to > Configure. However, Devel::PatchPerl calls patch with -p0 and the > diff in _patch_conf_fwrapv uses {a/,b/} causing the patching to fail: > > Auto-guessed '5.16.2' > patching Configure > File Configure is read-only; trying to patch anyway > patching ext/Errno/Errno_pm.PL > File ext/Errno/Errno_pm.PL is read-only; trying to patch anyway > patching b/Configure > The text leading up to this was: > -------------------------- > |diff --git a/Configure b/Configure > |index 15b3da1769..791889a2ab 100755 > |--- a/Configure > |+++ b/Configure > -------------------------- > No file to patch. Skipping patch. > 1 out of 1 hunk ignored > Died at > /mnt/testssd/perl/patchperl/perl5lib/lib/perl5/Devel/PatchPerl.pm line > 416. > > The attached patch removes the a/ and b/ on the +++ and --- lines to > match other example s of patches in the module.
I can confirm that patching under 5.16.3 is failing as well: [root@0995de0251d9 /]# cat /opt/perl5/build.perl-5.16.3.log Auto-guessed '5.16.3' patching Configure patching ext/Errno/Errno_pm.PL patching b/Configure The text leading up to this was: -------------------------- |diff --git a/Configure b/Configure |index 15b3da1769..791889a2ab 100755 |--- a/Configure |+++ b/Configure -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored Died at /opt/perl5/bin/patchperl line 556. ##### Brew Failed ##### [root@0995de0251d9 /]#