Skip Menu |

This queue is for tickets about the Gtk3 CPAN distribution.

Report information
The Basics
Id: 129310
Status: resolved
Priority: 0/
Queue: Gtk3

People
Owner: XAOC [...] cpan.org
Requestors: HMBRAND [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Load GdkPixdata introspection data if gdk-pixbuf >= 2.38.0
Subject: Gtk3.pm.diff
diff -purd a/lib/Gtk3.pm b/lib/Gtk3.pm --- a/lib/Gtk3.pm 2018-05-22 05:18:14.000000000 +0200 +++ b/lib/Gtk3.pm 2019-04-25 17:37:24.647266796 +0200 @@ -84,6 +84,10 @@ my $_GDK_PIXBUF_BASENAME = 'GdkPixbuf'; my $_GDK_PIXBUF_VERSION = '2.0'; my $_GDK_PIXBUF_PACKAGE = 'Gtk3::Gdk'; +my $_GDK_PIXDATA_BASENAME = 'GdkPixdata'; +my $_GDK_PIXDATA_VERSION = '2.0'; +my $_GDK_PIXDATA_PACKAGE = 'Gtk3::Gdk'; + my $_PANGO_BASENAME = 'Pango'; my $_PANGO_VERSION = '1.0'; my $_PANGO_PACKAGE = 'Pango'; @@ -471,6 +475,15 @@ sub import { package => $_GDK_PIXBUF_PACKAGE, flatten_array_ref_return_for => \@_GDK_PIXBUF_FLATTEN_ARRAY_REF_RETURN_FOR); + # In gdk-pixbuf 2.38.0, the GdkPixdata introspection information was split + # out into its own file. + if (Gtk3::Gdk::Pixbuf::CHECK_VERSION (2, 38, 0)) { + Glib::Object::Introspection->setup ( + basename => $_GDK_PIXDATA_BASENAME, + version => $_GDK_PIXDATA_VERSION, + package => $_GDK_PIXDATA_PACKAGE); + } + Glib::Object::Introspection->setup ( basename => $_PANGO_BASENAME, version => $_PANGO_VERSION,
On Thu Apr 25 11:42:44 2019, HMBRAND wrote: Show quoted text
> See also https://gitlab.gnome.org/GNOME/perl- > gtk3/commit/88bc49e7a21da0131b10546aa07ebdf98d18a37e > > See attached patch
Sorry, I must be missing something obvious; your patch has the same contents as commit 88bc49e7a. What are you asking for here? In February, I posted to the list [1] that I was having troubles building Gtk3 after pulling this commit... however, it wants to work now after updates to the GTK+3/GDK-Pixbuf C libraries on my system. Thanks, Brian [1] https://mail.gnome.org/archives/gtk-perl-list/2019-March/msg00000.html
Subject: Re: [rt.cpan.org #129310] Load GdkPixdata introspection data if gdk-pixbuf >= 2.38.0
Date: Thu, 25 Apr 2019 18:58:21 +0200
To: bug-Gtk3 [...] rt.cpan.org
From: "H.Merijn Brand" <h.m.brand [...] xs4all.nl>
On Thu, 25 Apr 2019 12:50:38 -0400, "Brian Manning via RT" <bug-Gtk3@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=129310 > > > On Thu Apr 25 11:42:44 2019, HMBRAND wrote:
> > See also https://gitlab.gnome.org/GNOME/perl- > > gtk3/commit/88bc49e7a21da0131b10546aa07ebdf98d18a37e > > > > See attached patch
> > Sorry, I must be missing something obvious; your patch has the same > contents as commit 88bc49e7a. What are you asking for here? > > In February, I posted to the list [1] that I was having troubles > building Gtk3 after pulling this commit... however, it wants to work > now after updates to the GTK+3/GDK-Pixbuf C libraries on my system. > > Thanks, > > Brian > > [1] > https://mail.gnome.org/archives/gtk-perl-list/2019-March/msg00000.html
So, maybe I am just asking for a new release then :) -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.29 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
Download (untitled)
application/pgp-signature 473b

Message body not shown because it is not plain text.

On Thu Apr 25 12:58:49 2019, h.m.brand@xs4all.nl wrote: Show quoted text
> On Thu, 25 Apr 2019 12:50:38 -0400, "Brian Manning via RT" > <bug-Gtk3@rt.cpan.org> wrote:
> > Sorry, I must be missing something obvious; your patch has the same > > contents as commit 88bc49e7a. What are you asking for here? > > > > In February, I posted to the list [1] that I was having troubles > > building Gtk3 after pulling this commit... however, it wants to work > > now after updates to the GTK+3/GDK-Pixbuf C libraries on my system.
Show quoted text
> So, maybe I am just asking for a new release then :)
Oh, that's easy enough. Deadline for releases for April is tomorrow, April 26th [1]. Do you want to keep this ticket open then? Thanks, Brian [1] https://mail.gnome.org/archives/gtk-perl-list/2019-April/msg00006.html
Subject: Re: [rt.cpan.org #129310] Load GdkPixdata introspection data if gdk-pixbuf >= 2.38.0
Date: Thu, 25 Apr 2019 22:26:45 +0200
To: bug-Gtk3 [...] rt.cpan.org
From: "H.Merijn Brand" <h.m.brand [...] xs4all.nl>
On Thu, 25 Apr 2019 13:07:13 -0400, "Brian Manning via RT" <bug-Gtk3@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=129310 > > > On Thu Apr 25 12:58:49 2019, h.m.brand@xs4all.nl wrote:
> > On Thu, 25 Apr 2019 12:50:38 -0400, "Brian Manning via RT" > > <bug-Gtk3@rt.cpan.org> wrote:
> > > Sorry, I must be missing something obvious; your patch has the > > > same contents as commit 88bc49e7a. What are you asking for here? > > > > > > In February, I posted to the list [1] that I was having troubles > > > building Gtk3 after pulling this commit... however, it wants to > > > work now after updates to the GTK+3/GDK-Pixbuf C libraries on my > > > system.
>
> > So, maybe I am just asking for a new release then :)
> > Oh, that's easy enough. Deadline for releases for April is tomorrow, > April 26th [1]. Do you want to keep this ticket open then?
Thumbs up. I don't really care about this ticket staying open. Thank you! Show quoted text
-- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.29 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
Download (untitled)
application/pgp-signature 473b

Message body not shown because it is not plain text.