| Subject: | t/02-primary_gz.t failures |
On some of my smoker systems the t/02-primary_gz.t fails like this:
...
not well-formed (invalid token) at line 1, column 0, byte 0 at /opt/perl-5.29.9/lib/site_perl/5.29.9/x86_64-linux/XML/Parser.pm line 187.
XML::Simple called at /home/cpansand/.cpan/build/2019041719/Parse-Fedora-Packages-0.06-4/blib/lib/Parse/Fedora/Packages.pm line 67.
# Looks like your test exited with 255 just after 3.
t/02-primary_gz.t ..
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 4/7 subtests
...
Looking at the test script I wonder if it should use parse_primary_gz instead of parse_primary --- otherwise this test script is identical to 01-primary.t. So:
diff --git a/t/02-primary_gz.t b/t/02-primary_gz.t
index e8f259a..a08980f 100644
--- a/t/02-primary_gz.t
+++ b/t/02-primary_gz.t
@@ -16,7 +16,7 @@ my $p = Parse::Fedora::Packages->new;
isa_ok($p, 'Parse::Fedora::Packages');
BEGIN { $tests += 2; }
-$p->parse_primary('t/files/primary.xml.gz');
+$p->parse_primary_gz('t/files/primary.xml.gz');
diag $p->count_packages;
is($p->reported_count_packages, 4, "number of packages is correct");
is($p->count_packages, 4, "number of packages is correct");
However on some systems there are pass reports even without this patch. Maybe on these systems XML parsing is possible on gzipped files without extracting them first.