Bug #129191 for DBIx-Class-UUIDColumns: Infinite Loop when Installing from cpan(1)

Mon Apr 15 06:49:46 2019 tom [...] eborcom.com - Ticket created

Subject:

Infinite Loop when Installing from cpan(1)

With a freshly installed perl-5.28.1, I ran: % cpan DBIx::Class::UUIDColumns This command hits an infinite loop and only stopped when I hit CTRL-C to stop it repeatedly writing "Please provide the location of the Apache directory:" to the console. This happens due to DBIx::Class::UUIDColumns having a dependency on APR::UUID which is part of mod_perl. In 2019 it seems odd to depend on mod_perl, particularly if it prevents your users installing your module. Would you consider removing the mod_perl dependency or perhaps fixing this problem some other way? Thanks, Tom

Mon Apr 15 08:03:06 2019 abraxxa [...] cpan.org - Correspondence added

APR::UUID is not a required dependency but a recommended one. Please review your CPAN client config regarding recommended dependencies.

Mon Apr 15 08:03:08 2019 The RT System itself - Status changed from 'new' to 'open'

Mon Apr 15 08:03:08 2019 abraxxa [...] cpan.org - Status changed from 'open' to 'stalled'

Mon Apr 15 08:51:47 2019 tom [...] eborcom.com - Correspondence added

Subject:	Re: [rt.cpan.org #129191] Infinite Loop when Installing from cpan(1)
Date:	Mon, 15 Apr 2019 12:17:14 +0000
To:	Alexander Hartmaier via RT <bug-DBIx-Class-UUIDColumns [...] rt.cpan.org>
From:	Tom Hukins <tom [...] eborcom.com>

On Mon, Apr 15, 2019 at 08:03:08AM -0400, Alexander Hartmaier via RT wrote: Show quoted text

> APR::UUID is not a required dependency but a recommended one.

True, but cpan(1) installs recommended dependencies by default nowadays: https://metacpan.org/source/ANDK/CPAN-2.26/lib/CPAN/FirstTime.pm#L910 Show quoted text

> Please review your CPAN client config regarding recommended dependencies.

The approach you suggest requires that every cpan(1) user reconfigure their client due to defaults that don't work. Please reconsider this suggestion. Tom

Mon Apr 15 08:51:49 2019 The RT System itself - Status changed from 'stalled' to 'open'

Mon Apr 15 09:01:07 2019 abraxxa [...] cpan.org - Correspondence added

I see. Patches welcome as I only took over maintainership and not even use the module myself.

Mon Apr 15 10:21:54 2019 tom [...] eborcom.com - Correspondence added

Subject:	Re: [rt.cpan.org #129191] Infinite Loop when Installing from cpan(1)
Date:	Mon, 15 Apr 2019 14:21:45 +0000
To:	Alexander Hartmaier via RT <bug-DBIx-Class-UUIDColumns [...] rt.cpan.org>
From:	Tom Hukins <tom [...] eborcom.com>

On Mon, Apr 15, 2019 at 09:01:08AM -0400, Alexander Hartmaier via RT wrote: Show quoted text

> Patches welcome as I only took over maintainership and not even use > the module myself.

What do you think of the attached patch? It's not very clever, but it works. Also, thank you for your quick replies and maintenance of this module. Tom

From 4d06b987d88c406b8b802051f12eb138a6f53c65 Mon Sep 17 00:00:00 2001 From: Tom Hukins <tom@eborcom.com> Date: Mon, 15 Apr 2019 15:17:51 +0100 Subject: [PATCH] Avoid recommending APR::UUID This module ships as part of mod_perl, whose installation process gets stuck in an infinite loop if it can't find an apxs(1) executable: https://rt.cpan.org/Ticket/Display.html?id=129191 Recent cpan(1) clients using default configuration try to install recommended modules. --- Makefile.PL | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile.PL b/Makefile.PL index ed68b4f..080c41f 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -34,7 +34,6 @@ build_requires 'DBD::SQLite' => '1.11'; recommends 'Data::UUID'; recommends 'Data::Uniqid'; -recommends 'APR::UUID'; recommends 'UUID'; recommends 'Win32::Guidgen'; recommends 'Win32API::GUID'; -- 2.21.0

Mon Apr 15 10:48:41 2019 abraxxa [...] cpan.org - Correspondence added

This isn't enough as the module is used by DBIx::Class::UUIDColumns::UUIDMaker::APR::UUID. A deprecation of the module, removal of the test etc. is necessary.

Mon Apr 15 12:51:31 2019 tom [...] eborcom.com - Correspondence added

Subject:	Re: [rt.cpan.org #129191] Infinite Loop when Installing from cpan(1)
Date:	Mon, 15 Apr 2019 16:51:22 +0000
To:	Alexander Hartmaier via RT <bug-DBIx-Class-UUIDColumns [...] rt.cpan.org>
From:	Tom Hukins <tom [...] eborcom.com>

On Mon, Apr 15, 2019 at 10:48:43AM -0400, Alexander Hartmaier via RT wrote: Show quoted text

> This isn't enough as the module is used by > DBIx::Class::UUIDColumns::UUIDMaker::APR::UUID.

I don't understand why. The lib/DBIx/Class/UUIDColumns/UUIDMaker/ directory contains several modules the wrap their corresponding CPAN modules. Each of these UUIDMaker modules is a wrapper around something that may or may not be installed. I have an environment with ::UUIDColumns installed: % perl -MDBIx::Class::UUIDColumns -wE 1 And it has Data::UUID installed: % perl -MDBIx::Class::UUIDColumns::UUIDMaker::Data::UUID -wE 1 But as it's not a Windows enviornment, it lacks Win32::Guidgen: % perl -MDBIx::Class::UUIDColumns::UUIDMaker::Win32::Guidgen -wE 1 Can't locate Win32/Guidgen.pm in @INC (you may need to install the Win32::Guidgen module) Different environments will lack different modules. The lack of them on any given environment is no reason to remove the corresponding UUIDMaker, as they will be installed on other environments. Show quoted text

> A deprecation of the module, removal of the test etc. is necessary.

I disagree. If someone happens to have mod_perl installed on their environment, they should have the option of using ::UIDMaker::APR::UUID. Tom

Tue Apr 16 03:10:52 2019 abraxxa [...] cpan.org - Correspondence added

So you suggest to install a module (UIDMaker::APR::UUID) but not listing its requirements at all?

Tue Apr 16 04:12:47 2019 tom [...] eborcom.com - Correspondence added

Subject:	Re: [rt.cpan.org #129191] Infinite Loop when Installing from cpan(1)
Date:	Tue, 16 Apr 2019 08:12:38 +0000
To:	Alexander Hartmaier via RT <bug-DBIx-Class-UUIDColumns [...] rt.cpan.org>
From:	Tom Hukins <tom [...] eborcom.com>

On Tue, Apr 16, 2019 at 03:10:55AM -0400, Alexander Hartmaier via RT wrote: Show quoted text

> So you suggest to install a module (UIDMaker::APR::UUID) but not > listing its requirements at all?

Reluctantly, yes, because we don't have a better fix yet. Tom

Fri May 10 08:31:36 2019 tom [...] eborcom.com - Correspondence added

On 2019-04-16 09:12:47, TOMHUKINS wrote: Show quoted text

> On Tue, Apr 16, 2019 at 03:10:55AM -0400, Alexander Hartmaier via RT wrote:

> > So you suggest to install a module (UIDMaker::APR::UUID) but not > > listing its requirements at all?

> > Reluctantly, yes, because we don't have a better fix yet.

It's been more than three weeks since I wrote this. Do you consider the following a fair summary of the situation? This module does not currently install using the cpan(1) command, one of the most popular ways to install Perl modules, with its default settings. Instead, the installation gets stuck in an infinite loop. We have an imperfect patch that avoids this problem and introduces no significant new problems but that patch has not been applied. We have no alternative proposed solutions. Again, thank you for maintaining this module. I appreciate it's not easy to address problems like this in a satisfying way. Tom

Thu May 23 10:40:56 2019 ETJ [...] cpan.org - Correspondence added

As requested, adding this to the ticket. One possibility would be not to delete the "recommends" of APR::UUID, but instead to change it to a "suggests".