Skip Menu |

This queue is for tickets about the B-Hooks-Parser CPAN distribution.

Report information
The Basics
Id: 129173
Status: resolved
Priority: 0/
Queue: B-Hooks-Parser
People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.20
Fixed in: (no value)

History Show all quoted text
  Sun Apr 14 05:56:06 2019 SREZIC [...] cpan.org - Ticket created
Subject: Compilation error with threaded perls
The new version cannot be compiled with threaded perls. Excerpt of the build log: ... cc -c -I/home/cpansand/.cpan/build/2019041418/B-Hooks-OP-Check-0.22-0/blib/arch/B/Hooks/OP/Check/Install -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_FORTIFY_SOURCE=2 -O2 -pipe -fstack-protector -fno-strict-aliasing -DVERSION=\"0.20\" -DXS_VERSION=\"0.20\" -DPIC -fPIC "-I/usr/local/lib/perl5/5.28/mach/CORE" Parser.c In file included from Parser.xs:21: ./stolen_chunk_of_toke.c:132:13: error: unexpected type name 'PerlInterpreter': expected identifier filter_read(pTHX_ int idx, SV *buf_sv, int maxlen) ^ /usr/local/lib/perl5/5.28/mach/CORE/perl.h:187:18: note: expanded from macro 'pTHX_' # define pTHX_ pTHX, ^ /usr/local/lib/perl5/5.28/mach/CORE/perl.h:174:17: note: expanded from macro 'pTHX' # define pTHX tTHX my_perl PERL_UNUSED_DECL ^ /usr/local/lib/perl5/5.28/mach/CORE/perl.h:173:16: note: expanded from macro 'tTHX' # define tTHX PerlInterpreter* ^ ... (etc) ...
  Sun Apr 14 12:56:29 2019 ether [...] cpan.org - Correspondence added
On 2019-04-14 02:56:06, SREZIC wrote: Show quoted text
> The new version cannot be compiled with threaded perls. Excerpt of the > build log:
Thanks. Karl Williamson has helped me to figure out what needs to be fixed here - it is related to my changes in https://github.com/karenetheridge/B-Hooks-Parser/commit/66a934c02168048cebeb5a95d6ad3bbbe6e8f707 which did not take threaded builds into consideration. We will likely need to push the fixes up into Devel::PPPort as well. I will also add threaded builds to travis for additional insight.
  Sun Apr 14 12:56:31 2019 The RT System itself - Status changed from 'new' to 'open'
  Sun Apr 14 14:17:32 2019 ether [...] cpan.org - Correspondence added
I have filed https://rt.perl.org/Ticket/Display.html?id=134032 for the Devel::PPPort issue, and reverted stolen_chunk_of_toke.c to use the older Perl_filter_read. This is released in B-Hooks-Parser 0.21.
  Sun Apr 14 14:17:34 2019 ether [...] cpan.org - Status changed from 'open' to 'resolved'