Skip Menu |

This queue is for tickets about the Log-Dispatch-Email-Siffra CPAN distribution.

Report information
The Basics
Id: 129069
Status: open
Priority: 0/
Queue: Log-Dispatch-Email-Siffra
People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.01
Fixed in: (no value)

History Show all quoted text
  Mon Apr 08 13:36:12 2019 SREZIC [...] cpan.org - Ticket created
Subject: Perl::Critic tests may fail
On some of my smokers: ... PERL_DL_NONLAZY=1 "/usr/perl5.16.3t/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/001_load.t ...... ok # Failed test 'Test::Perl::Critic for "blib/lib/Log/Dispatch/Email/Siffra.pm"' # at /usr/perl5.16.3t/lib/site_perl/5.16.3/Test/Perl/Critic.pm line 121. # # Use of "require" is not allowed at line 20, column 5. Use Require() method of MainObject instead. (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 28, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 29, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 35, column 1. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 37, column 10. (no explanation). (Severity: 5) ... # Variable, subroutine, and package names have to be in CamelCase at line 73, column 9. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 73, column 39. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 74, column 9. (no explanation). (Severity: 5) t/perlcritic.t .... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests ...
  Mon Apr 08 23:47:44 2019 ether [...] cpan.org - Correspondence added
On 2019-04-08 10:36:12, SREZIC wrote: Show quoted text
> On some of my smokers: > > ... > PERL_DL_NONLAZY=1 "/usr/perl5.16.3t/bin/perl" "- > MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef > *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" > t/*.t > t/001_load.t ...... ok > > # Failed test 'Test::Perl::Critic for > "blib/lib/Log/Dispatch/Email/Siffra.pm"' > # at /usr/perl5.16.3t/lib/site_perl/5.16.3/Test/Perl/Critic.pm line > 121.
While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};
  Mon Apr 08 23:47:44 2019 The RT System itself - Status changed from 'new' to 'open'
  Mon May 13 01:41:48 2019 SREZIC [...] cpan.org - Correspondence added
On 2019-04-08 13:36:12, SREZIC wrote: Show quoted text
> On some of my smokers: > > ... > PERL_DL_NONLAZY=1 "/usr/perl5.16.3t/bin/perl" "- > MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef > *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" > t/*.t > t/001_load.t ...... ok > > # Failed test 'Test::Perl::Critic for > "blib/lib/Log/Dispatch/Email/Siffra.pm"' > # at /usr/perl5.16.3t/lib/site_perl/5.16.3/Test/Perl/Critic.pm line > 121. > # > # Use of "require" is not allowed at line 20, column 5. Use > Require() method of MainObject instead. (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 28, column 5. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 29, column 5. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 35, column 1. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 37, column 10. (no explanation). (Severity: 5) > ... > # Variable, subroutine, and package names have to be in CamelCase at > line 73, column 9. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 73, column 39. (no explanation). (Severity: 5) > # Variable, subroutine, and package names have to be in CamelCase at > line 74, column 9. (no explanation). (Severity: 5) > t/perlcritic.t .... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/1 subtests > ...
Also tests fail if Test::Perl::Critic is not installed at all.