Bug #129066 for Mail-DKIM: Mail::DKIM::ARC::Signer cannot find SrvId

Mon Apr 08 03:49:57 2019 ikeda [...] conversion.co.jp - Ticket created

Subject:	Mail::DKIM::ARC::Signer cannot find SrvId
From:	ikeda [...] conversion.co.jp

If Authentication-Results field is as below: Show quoted text

> Authentication-Results: xxxx.xxx.xxxx-xxxxxx.fr (amavisd-new); > dkim=pass (1024-bit key) header.d=ies.univ-montp2.fr

Mail::DKIM::ARC::Signer cannot find SrvId in the field, and following warning issued: Show quoted text

> Use of uninitialized value $ardom in lc at /usr/share/perl5/vendor_perl/Mail/DKIM/ARC/Signer.pm line 255.

Mon Apr 08 04:50:57 2019 ikeda [...] conversion.co.jp - Broken in 0.54 added

Mon Apr 08 06:08:39 2019 mbradshaw [...] cpan.org - Taken

Mon Apr 08 07:00:29 2019 mbradshaw [...] cpan.org - Correspondence added

Hi ikedas, Thanks for the report, and the suggested fix to the regex in the linked github issue. Annoyingly, the ABNF for the Authentication-Results header is as follows authres-header = "Authentication-Results:" [CFWS] authserv-id [ CFWS authres-version ] ( no-result / 1*resinfo ) [CFWS] CRLF Meaning that it is legal for the comment to also appear before the authserv-id. Although I have never seen an instance of this in the wild. A fix has been released to github which uses Mail::AuthenticationResults to parse out the authserv-id, this should cover all valid headers. https://github.com/marcbradshaw/mail-dkim Let me know if this works for you and I'll release it to CPAN. Bug also filed with arc_test_suite which should help catch this in other arc implementations. https://github.com/ValiMail/arc_test_suite/issues/25

Mon Apr 08 07:00:31 2019 The RT System itself - Status changed from 'new' to 'open'

Mon Apr 08 07:10:59 2019 ikeda [...] conversion.co.jp - Correspondence added

Hi MBRADSHAW, On 2019-4月-08 月 07:00:29, MBRADSHAW wrote: Show quoted text

> Hi ikedas, > > Thanks for the report, and the suggested fix to the regex in the > linked github issue. > > Annoyingly, the ABNF for the Authentication-Results header is as > follows > > authres-header = "Authentication-Results:" [CFWS] authserv-id > [ CFWS authres-version ] > ( no-result / 1*resinfo ) [CFWS] CRLF > > Meaning that it is legal for the comment to also appear before the > authserv-id. Although I have never seen an instance of this in the > wild. > > A fix has been released to github which uses > Mail::AuthenticationResults to parse out the authserv-id, this should > cover all valid headers. > > https://github.com/marcbradshaw/mail-dkim > > Let me know if this works for you and I'll release it to CPAN.

Sympa also parses A-R in the other place. I fixed it by doing like: $ardom = MIME::Field::ParamVal->parse("Value of A-R")->('_'); Show quoted text

> Bug also filed with arc_test_suite which should help catch this in > other arc implementations. > https://github.com/ValiMail/arc_test_suite/issues/25

Thanks!

Mon Apr 08 07:18:48 2019 ikeda [...] conversion.co.jp - Correspondence added

Hi again, On 2019-4月-08 月 07:10:59, ikeda@conversion.co.jp wrote: Show quoted text

> Hi MBRADSHAW, > > On 2019-4月-08 月 07:00:29, MBRADSHAW wrote:

> > Hi ikedas, > > > > Thanks for the report, and the suggested fix to the regex in the > > linked github issue. > > > > Annoyingly, the ABNF for the Authentication-Results header is as > > follows > > > > authres-header = "Authentication-Results:" [CFWS] authserv-id > > [ CFWS authres-version ] > > ( no-result / 1*resinfo ) [CFWS] CRLF > > > > Meaning that it is legal for the comment to also appear before the > > authserv-id. Although I have never seen an instance of this in the > > wild. > > > > A fix has been released to github which uses > > Mail::AuthenticationResults to parse out the authserv-id, this should > > cover all valid headers. > > > > https://github.com/marcbradshaw/mail-dkim > > > > Let me know if this works for you and I'll release it to CPAN.

I was hasty. I ask Sympa folks to check it. Thanks again!

Mon Apr 08 23:08:45 2019 ikeda [...] conversion.co.jp - Correspondence added

Hi MBRADSHAW, It looks working fine. Thanks for quick response! On 2019-4月-08 月 07:00:29, MBRADSHAW wrote: Show quoted text

> Hi ikedas, > > Thanks for the report, and the suggested fix to the regex in the > linked github issue. > > Annoyingly, the ABNF for the Authentication-Results header is as > follows > > authres-header = "Authentication-Results:" [CFWS] authserv-id > [ CFWS authres-version ] > ( no-result / 1*resinfo ) [CFWS] CRLF > > Meaning that it is legal for the comment to also appear before the > authserv-id. Although I have never seen an instance of this in the > wild. > > A fix has been released to github which uses > Mail::AuthenticationResults to parse out the authserv-id, this should > cover all valid headers. > > https://github.com/marcbradshaw/mail-dkim > > Let me know if this works for you and I'll release it to CPAN. > > > > Bug also filed with arc_test_suite which should help catch this in > other arc implementations. > https://github.com/ValiMail/arc_test_suite/issues/25

Tue Apr 16 22:46:22 2019 mbradshaw [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Apr 16 22:46:22 2019 mbradshaw [...] cpan.org - Fixed in 0.55 added