| Subject: | odsxml: properly set version attribute |
urn:oasis:names:tc:opendocument:xmlns:office:1.0="version" appears in the content.xml document-content element, when it was meant to be office:version="1.0". Using setAttributeNS instead of setAttribute fixes this.
Patch attached.
| Subject: | 0001-odsxml-properly-set-version-attribute.patch |
From 7947d5be1e1e66a3efc8701ab8eb412771e8faaf Mon Sep 17 00:00:00 2001
From: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Date: Sat, 23 Mar 2019 05:43:05 -0300
Subject: [PATCH] odsxml: properly set version attribute
The version attribute uses the office namespace. setAttributeNS should be used
to set it instead of setAttribute.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
---
lib/Spreadsheet/Wright/OpenDocumentXML.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/Spreadsheet/Wright/OpenDocumentXML.pm b/lib/Spreadsheet/Wright/OpenDocumentXML.pm
index 1f44cf4f1075..4bd70fb50009 100644
--- a/lib/Spreadsheet/Wright/OpenDocumentXML.pm
+++ b/lib/Spreadsheet/Wright/OpenDocumentXML.pm
@@ -59,7 +59,7 @@ sub _prepare
$self->{'document'}->documentElement->setNamespace($nsuri, $prefix, $prefix eq 'office' ? 1 : 0);
}
$self->{'document'}->documentElement->setNodeName('office:document-content');
- $self->{'document'}->documentElement->setAttribute(OFFICE_NS, 'version', '1.0');
+ $self->{'document'}->documentElement->setAttributeNS(OFFICE_NS, 'version', '1.0');
$self->{'body'} = $self->{'document'}->documentElement
->addNewChild(OFFICE_NS, 'body')
->addNewChild(OFFICE_NS, 'spreadsheet');
@@ -133,4 +133,4 @@ sub _make_output
return $self->{'document'}->toString;
}
-1;
\ No newline at end of file
+1;
--
2.20.1