Skip Menu |

This queue is for tickets about the Siffra-Logger CPAN distribution.

Report information
The Basics
Id: 128865
Status: open
Priority: 0/
Queue: Siffra-Logger

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.01
Fixed in: (no value)



Subject: Perl::Critic tests may fail
Another test suite with the perlcritic test possibly failing (probably depending on installed perlcritic policies): # Failed test 'Test::Perl::Critic for "blib/lib/Siffra/Logger.pm"' # at /usr/perl5.16.3t/lib/site_perl/5.16.3/Test/Perl/Critic.pm line 121. # # Variable, subroutine, and package names have to be in CamelCase at line 19, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 20, column 5. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 35, column 10. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 35, column 21. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 35, column 37. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 36, column 8. (no explanation). (Severity: 5) ...
On 2019-03-17 07:25:10, SREZIC wrote: Show quoted text
> Another test suite with the perlcritic test possibly failing (probably > depending on installed perlcritic policies):
While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};