Skip Menu |

This queue is for tickets about the App-SpreadRevolutionaryDate CPAN distribution.

Report information
The Basics
Id: 128733
Status: resolved
Priority: 0/
Queue: App-SpreadRevolutionaryDate
People
Owner: GIBUS [...] cpan.org
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.04

History Show all quoted text
  Wed Mar 06 15:38:02 2019 SREZIC [...] cpan.org - Ticket created
Subject: t/objects.t fails (without Net::OAuth?) (0.03)
On some of my smokers the test suite fails: ... # Failed test 'Twitter no connection with fake credentials' # at t/objects.t line 41. # got: 'Install Net::OAuth 0.25 or later for OAuth support at t/objects.t line 40. # ' # expected: '401: Authorization Required' # Looks like you planned 9 tests but ran 8. # Looks like you failed 1 test of 8 run. t/objects.t ..... Dubious, test returned 1 (wstat 256, 0x100) Failed 2/9 subtests ...
  Wed Mar 06 17:29:55 2019 GIBUS [...] cpan.org - Taken
  Wed Mar 06 17:32:48 2019 GIBUS [...] cpan.org - Correspondence added
Thanks for the report. I've added Net::OAuth as dependency, this should fix the issue. Published in 0.04.
  Wed Mar 06 17:32:49 2019 The RT System itself - Status changed from 'new' to 'open'
  Thu Mar 07 02:40:40 2019 GIBUS [...] cpan.org - Correspondence added
Just for the record, I've checked the source code of Net::Twitter::Lite and found the following comment: # This is a hack. Rather than making Net::OAuth an install requirement for # Net::Twitter::Lite, require it at runtime if any OAuth methods are used. It # simply returns the string 'Net::OAuth' after successfully requiring # Net::OAuth. And the submodule Net::Twitter::Lite::WithAPIv1_1, which is required by App::SpreadRevolutionaryDate has this documentation: "With Twitter API version 1.1, all API calls require OAuth. Other Twitter compatible services, like Identi.ca, accept Basic Authentication." Since App::SpreadRevolutionaryDate uses Twitter, Net::OAuth is indeed a requirement. Dist::Zilla::Plugin::AutoPrereqs wouldn't find it because it is only required at runtime by Net::Twitter::Lite. Therefore, the fix released in App::SpreadRevolutionaryDate 0.04 is actually the good solution.
  Thu Mar 07 02:40:41 2019 GIBUS [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu Mar 07 02:40:41 2019 GIBUS [...] cpan.org - Fixed in 0.04 added