Skip Menu |

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 128724
Status: open
Priority: 0/
Queue: Module-CPANTS-Analyse
People
Owner: Nobody in particular
Requestors: RURBAN [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Wed Mar 06 03:00:11 2019 RURBAN [...] cpan.org - Ticket created
Subject: Allow generated modules from Files in MANIFEST.SKIP
Files generated in Makefile.PL such as Storable.pm are generated on the fly. But many Kwalitee tests will fail when in the main module is skipped, such as -has_license_in_source_file -has_abstract_in_pod Turning off $Module::CPANTS::Kwalitee::Files::RespectManiskip in Test::Kwalitee does not help either, as this will report no_files_to_be_skipped errors. Unfortunately I need a MANIFEST.SKIP file to detect skipped files for Test::CheckManifest, and MANIFEST.SKIP must contain the generated modules. -- Reini Urban
  Wed Mar 06 03:01:05 2019 RURBAN [...] cpan.org - Correspondence added
This directly conflicts with the feature request in #126918 and is already broken in the latest release.
  Wed Mar 06 03:10:46 2019 ishigaki [...] cpan.org - Correspondence added
On Wed Mar 06 17:01:05 2019, RURBAN wrote: Show quoted text
> This directly conflicts with the feature request in #126918 > and is already broken in the latest release.
Would it help if I introduce a new variable ($IgnoreManiskip) to skip this block? https://github.com/cpants/Module-CPANTS-Analyse/blob/master/lib/Module/CPANTS/Kwalitee/Files.pm#L51-L56
  Wed Mar 06 03:10:46 2019 The RT System itself - Status changed from 'new' to 'open'
  Wed Mar 06 09:07:04 2019 reini.urban [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #128724] Allow generated modules from Files in MANIFEST.SKIP
Date: Wed, 6 Mar 2019 15:06:44 +0100
To: bug-Module-CPANTS-Analyse [...] rt.cpan.org
From: Reini Urban <reini.urban [...] gmail.com>
Kenichi Ishigaki via RT <bug-Module-CPANTS-Analyse@rt.cpan.org> schrieb am Mi., 6. März 2019, 09:10: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=128724 > > > On Wed Mar 06 17:01:05 2019, RURBAN wrote:
> > This directly conflicts with the feature request in #126918 > > and is already broken in the latest release.
> > > Would it help if I introduce a new variable ($IgnoreManiskip) to skip this > block? > > > https://github.com/cpants/Module-CPANTS-Analyse/blob/master/lib/Module/CPANTS/Kwalitee/Files.pm#L51-L56
But then it would clash with hmbrand's test case. It really should know about all configure-time and build-time expanded files and accept these. esp. scripts and modules. no idea how, yet. Show quoted text
> >
  Wed Mar 06 13:03:07 2019 ishigaki [...] cpan.org - Correspondence added
On Wed Mar 06 17:10:46 2019, ISHIGAKI wrote: Show quoted text
> On Wed Mar 06 17:01:05 2019, RURBAN wrote:
> > This directly conflicts with the feature request in #126918 > > and is already broken in the latest release.
> > > Would it help if I introduce a new variable ($IgnoreManiskip) to skip > this block? > > https://github.com/cpants/Module-CPANTS- > Analyse/blob/master/lib/Module/CPANTS/Kwalitee/Files.pm#L51-L56
I think I find what is a real issue: MANIFEST.SKIP for Storable is written in a .gitignore style, but each line of it is actually treated as a regular expression. So you need to add "$"s (and maybe "\") to "Makefile" and "Storable.pm" lines if you don't want to skip "Makefile.PL" nor "Storable_pm.PL" (see ExtUtils::Manifest for details).
  Wed Mar 06 13:21:00 2019 ishigaki [...] cpan.org - Correspondence added
On Thu Mar 07 03:03:07 2019, ISHIGAKI wrote: Show quoted text
> On Wed Mar 06 17:10:46 2019, ISHIGAKI wrote:
> > On Wed Mar 06 17:01:05 2019, RURBAN wrote:
> > > This directly conflicts with the feature request in #126918 > > > and is already broken in the latest release.
> > > > > > Would it help if I introduce a new variable ($IgnoreManiskip) to skip > > this block? > > > > https://github.com/cpants/Module-CPANTS- > > Analyse/blob/master/lib/Module/CPANTS/Kwalitee/Files.pm#L51-L56
> > > I think I find what is a real issue: MANIFEST.SKIP for Storable is > written in a .gitignore style, but each line of it is actually treated > as a regular expression. So you need to add "$"s (and maybe "\") to > "Makefile" and "Storable.pm" lines if you don't want to skip > "Makefile.PL" nor "Storable_pm.PL" (see ExtUtils::Manifest for > details).
Also, https://github.com/cpants/Module-CPANTS-Analyse/commit/f8a8d2e87b3229247e879a18b171729fe777ab22 should fix the has_license_in_source_file issue. (not released yet)