Bug #128704 for PiFlash: Segmentation fault in test suite

Mon Mar 04 15:34:50 2019 SREZIC [...] cpan.org - Ticket created

Subject:

Segmentation fault in test suite

t/010_PiFlash_State.t segfaults on most of my Linux smokers (various debian and ubuntu distributions): ... t/010_PiFlash_State.t .... Failed 42/54 subtests ... Test Summary Report ------------------- t/010_PiFlash_State.t (Wstat: 11 Tests: 12 Failed: 0) Non-zero wait status: 11 Parse errors: Bad plan. You planned 54 tests but ran 12. ... The only pass reports happen on some RH-based systems (fedora 28 and centos 7).

Mon Mar 04 22:08:29 2019 ikluft-cpan [...] thunder.sbay.org - Correspondence added

Accepted for investigation... no info yet.

Mon Mar 04 22:08:30 2019 The RT System itself - Status changed from 'new' to 'open'

Mon Mar 04 22:08:30 2019 ikluft-cpan [...] thunder.sbay.org - Taken

Thu Mar 07 06:55:51 2019 ikluft-cpan [...] thunder.sbay.org - Correspondence added

On Mon Mar 04 22:08:29 2019, IKLUFT wrote: Show quoted text

> Accepted for investigation... no info yet.

Confirmed, fixed in PiFlash 0.2.1. Tested on Fedora and Raspbian. The segfault came from a non-portable insertion to a symbol table which worked in Perl 5.28 but broke a can_ok() test in Perl 5.24 and probably others. Fix: https://github.com/ikluft/piflash/commit/917ffa3f1699e4f7f9b325f714e6860200b9cc78 Another error which caused tests to fail on Debian and probably other distributions was a hard-coded path "/usr/bin/true" as a sample of a program which is supposed to exist for the test, but didn't. It now searches standard Linux Filesystem directories for it. https://github.com/ikluft/piflash/commit/03e742cfa881badd03e060c24ee0e7ffd2a17a75

Thu Mar 07 08:42:03 2019 ikluft-cpan [...] thunder.sbay.org - Severity Important added

Thu Mar 07 16:15:41 2019 SREZIC [...] cpan.org - Correspondence added

On 2019-03-07 06:55:51, IKLUFT wrote: Show quoted text

> On Mon Mar 04 22:08:29 2019, IKLUFT wrote:

> > Accepted for investigation... no info yet.

> > Confirmed, fixed in PiFlash 0.2.1. Tested on Fedora and Raspbian. > > The segfault came from a non-portable insertion to a symbol table > which worked in Perl 5.28 but broke a can_ok() test in Perl 5.24 and > probably others. Fix: > https://github.com/ikluft/piflash/commit/917ffa3f1699e4f7f9b325f714e6860200b9cc78 > > Another error which caused tests to fail on Debian and probably other > distributions was a hard-coded path "/usr/bin/true" as a sample of a > program which is supposed to exist for the test, but didn't. It now > searches standard Linux Filesystem directories for it. > https://github.com/ikluft/piflash/commit/03e742cfa881badd03e060c24ee0e7ffd2a17a75

Also looks good at CPAN Testers: http://fast-matrix.cpantesters.org/?dist=PiFlash%200.2.1 Marking ticket as resolved.

Thu Mar 07 16:15:42 2019 SREZIC [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Mar 07 16:15:42 2019 SREZIC [...] cpan.org - Fixed in 0.2.1 added