Bug #128603 for Test-PerlTidy: t/exclude_perltidy.t and t/perltidy.t fail with perl-5.29.8

Sat Feb 23 10:18:31 2019 jkeenan [...] pobox.com - Ticket created

CC:	Chad Granum <exodist7 [...] gmail.com>
Subject:	t/exclude_perltidy.t and t/perltidy.t fail with perl-5.29.8
Date:	Sat, 23 Feb 2019 10:18:18 -0500
To:	bug-Test-PerlTidy [...] rt.cpan.org
From:	James E Keenan <jkeenan [...] pobox.com>

In the course of testing the 'CPAN River 3000' against the latest perl 5 monthly development release, I encountered these test failures: ##### { author => "LARRYL", dist => "Test-PerlTidy", distname => "Test-PerlTidy-20130104", distversion => 20130104, grade => "FAIL", prereqs => undef, test_output => [ "Building and testing Test-PerlTidy-20130104", "cp lib/Test/PerlTidy.pm blib/lib/Test/PerlTidy.pm", "PERL_DL_NONLAZY=1 \"/usr/home/jkeenan/var/tad/testing/perl-5.29.8/bin/perl\" \"-MExtUtils::Command::MM\" \"-MTest::Harness\" \"-e\" \"undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')\" t/*.t", "t/critic.t ............ skipped: Set \$ENV{TEST_AUTHOR} to a true value to run critic tests.", "t/exclude_files.t ..... ok", "# The file 'lib/Test/PerlTidy.pm' is not tidy", "# +----+---------------------------------------------------------------+-------------------------------------------------------------------+", "# | 80| # Do not worry about trailing newlines. | # Do not worry about trailing newlines. |", "# | 81| # | # |", "# | 82| \$code_to_tidy =~ s/[\\r\\n]+\$//; | \$code_to_tidy =~ s/[\\r\\n]+\$//; |", "# * 83| \$tidied_code =~ s/[\\r\\n]+\$//; | \$tidied_code =~ s/[\\r\\n]+\$//; *", "# | 84| if ( \$code_to_tidy eq \$tidied_code ) { | if ( \$code_to_tidy eq \$tidied_code ) { |", "# | 85| return 1; | return 1; |", "# | 86| } | } |", "# +----+---------------------------------------------------------------+-------------------------------------------------------------------+", "# | 131| \$finder->{options}->{untaint} = 1; | \$finder->{options}->{untaint} = 1; |", "# | 132| my \@files = \$finder->in(\$path); | my \@files = \$finder->in(\$path); |", "# | 133| | |", "# * 134| my %keep = map { File::Spec->canonpath(\$_) => 1 } \@files; | my %keep = map { File::Spec->canonpath(\$_) => 1 } \@files; *", "# | 135| my \@excluded = (); | my \@excluded = (); |", "# | 136| | |", "# | 137| foreach my \$file ( keys %keep ) { | foreach my \$file ( keys %keep ) { |", "# +----+---------------------------------------------------------------+-------------------------------------------------------------------+", "", "# Failed test ''lib/Test/PerlTidy.pm''", "# at t/exclude_perltidy.t line 11.", "# Looks like you failed 1 test of 11.", "t/exclude_perltidy.t .. ", "Dubious, test returned 1 (wstat 256, 0x100)", "Failed 1/11 subtests ", "t/is_file_tidy.t ...... ok", "t/list_files.t ........ ok", "# The file 'lib/Test/PerlTidy.pm' is not tidy", "# +----+---------------------------------------------------------------+-------------------------------------------------------------------+", "# | 80| # Do not worry about trailing newlines. | # Do not worry about trailing newlines. |", "# | 81| # | # |", "# | 82| \$code_to_tidy =~ s/[\\r\\n]+\$//; | \$code_to_tidy =~ s/[\\r\\n]+\$//; |", "# * 83| \$tidied_code =~ s/[\\r\\n]+\$//; | \$tidied_code =~ s/[\\r\\n]+\$//; *", "# | 84| if ( \$code_to_tidy eq \$tidied_code ) { | if ( \$code_to_tidy eq \$tidied_code ) { |", "# | 85| return 1; | return 1; |", "# | 86| } | } |", "# +----+---------------------------------------------------------------+-------------------------------------------------------------------+", "# | 131| \$finder->{options}->{untaint} = 1; | \$finder->{options}->{untaint} = 1; |", "# | 132| my \@files = \$finder->in(\$path); | my \@files = \$finder->in(\$path); |", "# | 133| | |", "# * 134| my %keep = map { File::Spec->canonpath(\$_) => 1 } \@files; | my %keep = map { File::Spec->canonpath(\$_) => 1 } \@files; *", "# | 135| my \@excluded = (); | my \@excluded = (); |", "# | 136| | |", "# | 137| foreach my \$file ( keys %keep ) { | foreach my \$file ( keys %keep ) { |", "# +----+---------------------------------------------------------------+-------------------------------------------------------------------+", "", "# Failed test ''lib/Test/PerlTidy.pm''", "# at t/perltidy.t line 11.", "# Looks like you failed 1 test of 11.", "t/perltidy.t .......... ", "Dubious, test returned 1 (wstat 256, 0x100)", "Failed 1/11 subtests ", "t/pod-coverage.t ...... skipped: Set \$ENV{TEST_AUTHOR} to a true value to run POD tests.", "t/pod.t ............... skipped: Set \$ENV{TEST_AUTHOR} to a true value to run POD tests.", "t/strict.t ............ skipped: Set \$ENV{TEST_AUTHOR} to a true value to run strict tests.", "", "Test Summary Report", "-------------------", "t/exclude_perltidy.t (Wstat: 256 Tests: 11 Failed: 1)", " Failed test: 2", " Non-zero exit status: 1", "t/perltidy.t (Wstat: 256 Tests: 11 Failed: 1)", " Failed test: 2", " Non-zero exit status: 1", "Files=9, Tests=26, 4 wallclock secs ( 0.02 usr 0.03 sys + 3.37 cusr 0.48 csys = 3.91 CPU)", "Result: FAIL", ], via => "App::cpanminus::reporter 0.17 (1.7044)", } ##### These failures were observed on both FreeBSD-11.1 and Linux. This test relies upon modules from the Test-Simple distribution. That distribution is shipped with the Perl 5 core distribution and the version shipped with core was upgraded during the past month. You may wish to communicate with the people maintaining Test-Simple to see whether the tests in your test suite need modification. See also previously reported problem in https://rt.cpan.org/Ticket/Display.html?id=127688. Thank you very much. Jim Keenan

Sun Feb 24 12:44:54 2019 SREZIC [...] cpan.org - Correspondence added

RT-Send-CC:

exodist7 [...] gmail.com

On 2019-02-23 10:18:31, jkeenan@pobox.com wrote: Show quoted text

> In the course of testing the 'CPAN River 3000' against the latest perl > 5 > monthly development release, I encountered these test failures: > > ##### > { > author => "LARRYL", > dist => "Test-PerlTidy", > distname => "Test-PerlTidy-20130104", > distversion => 20130104, > grade => "FAIL", > prereqs => undef, > test_output => [ > "Building and testing Test-PerlTidy-20130104", > "cp lib/Test/PerlTidy.pm blib/lib/Test/PerlTidy.pm", > "PERL_DL_NONLAZY=1 > \"/usr/home/jkeenan/var/tad/testing/perl-5.29.8/bin/perl\" > \"-MExtUtils::Command::MM\" \"-MTest::Harness\" \"-e\" \"undef > *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')\" > t/*.t", > "t/critic.t ............ skipped: Set \$ENV{TEST_AUTHOR} to a > true > value to run critic tests.", > "t/exclude_files.t ..... ok", > "# The file 'lib/Test/PerlTidy.pm' is not tidy", > "# > +----+--------------------------------------------------------------- > +------------------------------------------------------------------- > +", > "# | 80| # Do not worry about trailing newlines. > | # Do not worry about trailing newlines. > |", > "# | 81| # > | # > |", > "# | 82| \$code_to_tidy =~ s/[\\r\\n]+\$//; > | \$code_to_tidy =~ s/[\\r\\n]+\$//; > |", > "# * 83| \$tidied_code =~ s/[\\r\\n]+\$//; > | \$tidied_code =~ s/[\\r\\n]+\$//; > *", > "# | 84| if ( \$code_to_tidy eq \$tidied_code ) { > | if ( \$code_to_tidy eq \$tidied_code ) { > |", > "# | 85| return 1; > | return 1; > |", > "# | 86| } > | } > |", > "# > +----+--------------------------------------------------------------- > +------------------------------------------------------------------- > +", > "# | 131| \$finder->{options}->{untaint} = 1; > | \$finder->{options}->{untaint} = 1; > |", > "# | 132| my \@files = \$finder->in(\$path); > | my \@files = \$finder->in(\$path); > |", > "# | 133| > | > |", > "# * 134| my %keep = map { File::Spec->canonpath(\$_) => 1 } > \@files; | my %keep = map { File::Spec->canonpath(\$_) => 1 } > \@files; *", > "# | 135| my \@excluded = (); > | my \@excluded = (); > |", > "# | 136| > | > |", > "# | 137| foreach my \$file ( keys %keep ) { > | foreach my \$file ( keys %keep ) { > |", > "# > +----+--------------------------------------------------------------- > +------------------------------------------------------------------- > +", > "", > "# Failed test ''lib/Test/PerlTidy.pm''", > "# at t/exclude_perltidy.t line 11.", > "# Looks like you failed 1 test of 11.", > "t/exclude_perltidy.t .. ", > "Dubious, test returned 1 (wstat 256, 0x100)", > "Failed 1/11 subtests ", > "t/is_file_tidy.t ...... ok", > "t/list_files.t ........ ok", > "# The file 'lib/Test/PerlTidy.pm' is not tidy", > "# > +----+--------------------------------------------------------------- > +------------------------------------------------------------------- > +", > "# | 80| # Do not worry about trailing newlines. > | # Do not worry about trailing newlines. > |", > "# | 81| # > | # > |", > "# | 82| \$code_to_tidy =~ s/[\\r\\n]+\$//; > | \$code_to_tidy =~ s/[\\r\\n]+\$//; > |", > "# * 83| \$tidied_code =~ s/[\\r\\n]+\$//; > | \$tidied_code =~ s/[\\r\\n]+\$//; > *", > "# | 84| if ( \$code_to_tidy eq \$tidied_code ) { > | if ( \$code_to_tidy eq \$tidied_code ) { > |", > "# | 85| return 1; > | return 1; > |", > "# | 86| } > | } > |", > "# > +----+--------------------------------------------------------------- > +------------------------------------------------------------------- > +", > "# | 131| \$finder->{options}->{untaint} = 1; > | \$finder->{options}->{untaint} = 1; > |", > "# | 132| my \@files = \$finder->in(\$path); > | my \@files = \$finder->in(\$path); > |", > "# | 133| > | > |", > "# * 134| my %keep = map { File::Spec->canonpath(\$_) => 1 } > \@files; | my %keep = map { File::Spec->canonpath(\$_) => 1 } > \@files; *", > "# | 135| my \@excluded = (); > | my \@excluded = (); > |", > "# | 136| > | > |", > "# | 137| foreach my \$file ( keys %keep ) { > | foreach my \$file ( keys %keep ) { > |", > "# > +----+--------------------------------------------------------------- > +------------------------------------------------------------------- > +", > "", > "# Failed test ''lib/Test/PerlTidy.pm''", > "# at t/perltidy.t line 11.", > "# Looks like you failed 1 test of 11.", > "t/perltidy.t .......... ", > "Dubious, test returned 1 (wstat 256, 0x100)", > "Failed 1/11 subtests ", > "t/pod-coverage.t ...... skipped: Set \$ENV{TEST_AUTHOR} to a > true > value to run POD tests.", > "t/pod.t ............... skipped: Set \$ENV{TEST_AUTHOR} to a > true > value to run POD tests.", > "t/strict.t ............ skipped: Set \$ENV{TEST_AUTHOR} to a > true > value to run strict tests.", > "", > "Test Summary Report", > "-------------------", > "t/exclude_perltidy.t (Wstat: 256 Tests: 11 Failed: 1)", > " Failed test: 2", > " Non-zero exit status: 1", > "t/perltidy.t (Wstat: 256 Tests: 11 Failed: 1)", > " Failed test: 2", > " Non-zero exit status: 1", > "Files=9, Tests=26, 4 wallclock secs ( 0.02 usr 0.03 sys + > 3.37 > cusr 0.48 csys = 3.91 CPU)", > "Result: FAIL", > ], > via => "App::cpanminus::reporter 0.17 (1.7044)", > } > ##### > > These failures were observed on both FreeBSD-11.1 and Linux. This > test > relies upon modules from the Test-Simple distribution. That > distribution > is shipped with the Perl 5 core distribution and the version shipped > with core was upgraded during the past month. You may wish to > communicate with the people maintaining Test-Simple to see > whether the tests in your test suite need modification. > > See also previously reported problem in > https://rt.cpan.org/Ticket/Display.html?id=127688.

It is very likely that RT #127688 is the only reason for the failures --- there is no indication that Test-Simple is causing problems here. I propose to close this ticket with a reference to RT #127688.

Sun Feb 24 12:44:54 2019 The RT System itself - Status changed from 'new' to 'open'

Fri Mar 08 18:39:49 2019 SHLOMIF [...] cpan.org - Correspondence added

On Sat Feb 23 10:18:31 2019, jkeenan@pobox.com wrote: Show quoted text

> In the course of testing the 'CPAN River 3000' against the latest perl > 5 > monthly development release, I encountered these test failures: >

should be ok now. Show quoted text

> ##### > { > author => "LARRYL", > dist => "Test-PerlTidy", > distname => "Test-PerlTidy-20130104", > distversion => 20130104, > grade => "FAIL", > prereqs => undef, > test_output => [ > "Building and testing Test-PerlTidy-20130104", > "cp lib/Test/PerlTidy.pm blib/lib/Test/PerlTidy.pm", > "PERL_DL_NONLAZY=1 > \"/usr/home/jkeenan/var/tad/testing/perl-5.29.8/bin/perl\" > \"-MExtUtils::Command::MM\" \"-MTest::Harness\" \"-e\" \"undef > *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')\" > t/*.t", > "t/critic.t ............ skipped: Set \$ENV{TEST_AUTHOR} to a > true > value to run critic tests.", > "t/exclude_files.t ..... ok", > "# The file 'lib/Test/PerlTidy.pm' is not tidy", > "# > +----+--------------------------------------------------------------- > +------------------------------------------------------------------- > +", > "# | 80| # Do not worry about trailing newlines. > | # Do not worry about trailing newlines. > |", > "# | 81| # > | # > |", > "# | 82| \$code_to_tidy =~ s/[\\r\\n]+\$//; > | \$code_to_tidy =~ s/[\\r\\n]+\$//; > |", > "# * 83| \$tidied_code =~ s/[\\r\\n]+\$//; > | \$tidied_code =~ s/[\\r\\n]+\$//; > *", > "# | 84| if ( \$code_to_tidy eq \$tidied_code ) { > | if ( \$code_to_tidy eq \$tidied_code ) { > |", > "# | 85| return 1; > | return 1; > |", > "# | 86| } > | } > |", > "# > +----+--------------------------------------------------------------- > +------------------------------------------------------------------- > +", > "# | 131| \$finder->{options}->{untaint} = 1; > | \$finder->{options}->{untaint} = 1; > |", > "# | 132| my \@files = \$finder->in(\$path); > | my \@files = \$finder->in(\$path); > |", > "# | 133| > | > |", > "# * 134| my %keep = map { File::Spec->canonpath(\$_) => 1 } > \@files; | my %keep = map { File::Spec->canonpath(\$_) => 1 } > \@files; *", > "# | 135| my \@excluded = (); > | my \@excluded = (); > |", > "# | 136| > | > |", > "# | 137| foreach my \$file ( keys %keep ) { > | foreach my \$file ( keys %keep ) { > |", > "# > +----+--------------------------------------------------------------- > +------------------------------------------------------------------- > +", > "", > "# Failed test ''lib/Test/PerlTidy.pm''", > "# at t/exclude_perltidy.t line 11.", > "# Looks like you failed 1 test of 11.", > "t/exclude_perltidy.t .. ", > "Dubious, test returned 1 (wstat 256, 0x100)", > "Failed 1/11 subtests ", > "t/is_file_tidy.t ...... ok", > "t/list_files.t ........ ok", > "# The file 'lib/Test/PerlTidy.pm' is not tidy", > "# > +----+--------------------------------------------------------------- > +------------------------------------------------------------------- > +", > "# | 80| # Do not worry about trailing newlines. > | # Do not worry about trailing newlines. > |", > "# | 81| # > | # > |", > "# | 82| \$code_to_tidy =~ s/[\\r\\n]+\$//; > | \$code_to_tidy =~ s/[\\r\\n]+\$//; > |", > "# * 83| \$tidied_code =~ s/[\\r\\n]+\$//; > | \$tidied_code =~ s/[\\r\\n]+\$//; > *", > "# | 84| if ( \$code_to_tidy eq \$tidied_code ) { > | if ( \$code_to_tidy eq \$tidied_code ) { > |", > "# | 85| return 1; > | return 1; > |", > "# | 86| } > | } > |", > "# > +----+--------------------------------------------------------------- > +------------------------------------------------------------------- > +", > "# | 131| \$finder->{options}->{untaint} = 1; > | \$finder->{options}->{untaint} = 1; > |", > "# | 132| my \@files = \$finder->in(\$path); > | my \@files = \$finder->in(\$path); > |", > "# | 133| > | > |", > "# * 134| my %keep = map { File::Spec->canonpath(\$_) => 1 } > \@files; | my %keep = map { File::Spec->canonpath(\$_) => 1 } > \@files; *", > "# | 135| my \@excluded = (); > | my \@excluded = (); > |", > "# | 136| > | > |", > "# | 137| foreach my \$file ( keys %keep ) { > | foreach my \$file ( keys %keep ) { > |", > "# > +----+--------------------------------------------------------------- > +------------------------------------------------------------------- > +", > "", > "# Failed test ''lib/Test/PerlTidy.pm''", > "# at t/perltidy.t line 11.", > "# Looks like you failed 1 test of 11.", > "t/perltidy.t .......... ", > "Dubious, test returned 1 (wstat 256, 0x100)", > "Failed 1/11 subtests ", > "t/pod-coverage.t ...... skipped: Set \$ENV{TEST_AUTHOR} to a > true > value to run POD tests.", > "t/pod.t ............... skipped: Set \$ENV{TEST_AUTHOR} to a > true > value to run POD tests.", > "t/strict.t ............ skipped: Set \$ENV{TEST_AUTHOR} to a > true > value to run strict tests.", > "", > "Test Summary Report", > "-------------------", > "t/exclude_perltidy.t (Wstat: 256 Tests: 11 Failed: 1)", > " Failed test: 2", > " Non-zero exit status: 1", > "t/perltidy.t (Wstat: 256 Tests: 11 Failed: 1)", > " Failed test: 2", > " Non-zero exit status: 1", > "Files=9, Tests=26, 4 wallclock secs ( 0.02 usr 0.03 sys + > 3.37 > cusr 0.48 csys = 3.91 CPU)", > "Result: FAIL", > ], > via => "App::cpanminus::reporter 0.17 (1.7044)", > } > ##### > > These failures were observed on both FreeBSD-11.1 and Linux. This > test > relies upon modules from the Test-Simple distribution. That > distribution > is shipped with the Perl 5 core distribution and the version shipped > with core was upgraded during the past month. You may wish to > communicate with the people maintaining Test-Simple to see > whether the tests in your test suite need modification. > > See also previously reported problem in > https://rt.cpan.org/Ticket/Display.html?id=127688. > > Thank you very much. > Jim Keenan

Fri Mar 08 18:39:49 2019 SHLOMIF [...] cpan.org - Status changed from 'open' to 'resolved'