Bug #128573 for Devel-PatchPerl: exit from a function?

Thu Feb 21 02:17:29 2019 ANDK [...] cpan.org - Ticket created

Subject:

exit from a function?

eval { Devel::PatchPerl->patch_source($perlversion, "."); }; ^^ should it return or not? It may? It may not? Reading Changes for version 1.54 : : Change: 498fcff11abd4e5f06a4e916c2296323c1125ced Author: Chris 'BinGOs' Williams <chris@bingosnet.co.uk> Date : 2019-02-18 11:06:49 +0000 : Updated hints and added certified perl version : If perl to be patched is greater than or equal to certified perl version than patchperl will exit doing nothing It seems to me that it exits. Bug or feature?

Thu Feb 21 03:36:46 2019 ANDK [...] cpan.org - Correspondence added

Sorry, I was a bit in hurry, when I wrote above. Looking in the code I see in commit 498fcff11abd4e5f06a4e916c2296323c1125ced that there is an exit within patch_source() in line 290 of lib/Devel/PatchPerl.pm It is not documented in the manpage of Devel::PatchPerl. Pleas clarify. Thanks!

Tue Feb 26 08:43:29 2019 HMBRAND [...] cpan.org - Correspondence added

I wholeheartedly agree that the "exit" on line 292 should be a "return". I also think this is a critical issue, as it will break all build scripts that now exit if there is no patch due

Tue Feb 26 08:43:30 2019 The RT System itself - Status changed from 'new' to 'open'

Tue Feb 26 08:43:43 2019 HMBRAND [...] cpan.org - Severity Critical added

Wed Feb 27 03:25:58 2019 ANDK [...] cpan.org - Correspondence added

I note it is fixed in 1.56. Thank you!

Wed Feb 27 03:25:58 2019 ANDK [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Feb 27 03:25:59 2019 ANDK [...] cpan.org - Fixed in 1.56 added