Skip Menu |

This queue is for tickets about the Log-Report CPAN distribution.

Report information
The Basics
Id: 128413
Status: resolved
Priority: 0/
Queue: Log-Report
People
Owner: Nobody in particular
Requestors: james2vegas [...] aim.com
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 1.27
Fixed in: (no value)

History Show all quoted text
  Sun Feb 03 02:11:30 2019 james2vegas [...] aim.com - Ticket created
Subject: t/70dancer2.t fails with older versions of Dancer installed
t/00use.t .............
Perl 5.024003
Dancer2 version 0.166001
Log::Dispatch version 2.51
Log::Log4perl version 1.40
Mojolicious version 7.70
POSIX version 1.65_01
PPI version 1.236
Plack::Test version unknown
String::Print version 0.93
Sys::Syslog version 0.33_01
Test::Pod version 1.51    
...                         
t/70dancer2.t ......... Dancer2 version 0.166001
syntax error at /home/perl/.cpanm/work/1549175997.86578/Log-Report-1.27/blib/lib/Dancer2/Plugin/LogReport.pm line 164, near "plugin_keywords fatal_handler"                    
Can't use global @_ in "my" at /home/perl/.cpanm/work/1549175997.86578/Log-Report-1.27/blib/lib/Dancer2/Plugin/LogReport.pm line 165, near "= @_"                              
Global symbol "$sub" requires explicit package name (did you forget to declare "my $sub"?) at /home/perl/.cpanm/work/1549175997.86578/Log-Report-1.27/blib/lib/Dancer2/Plugin/LogReport.pm line 166.
syntax error at /home/perl/.cpanm/work/1549175997.86578/Log-Report-1.27/blib/lib/Dancer2/Plugin/LogReport.pm line 167, near "}"                                                
BEGIN not safe after errors--compilation aborted at /home/perl/.cpanm/work/1549175997.86578/Log-Report-1.27/blib/lib/Dancer2/Plugin/LogReport.pm line 176.                     
Compilation failed in require at t/70dancer2.t line 35.
BEGIN failed--compilation aborted at t/70dancer2.t line 35.
Show quoted text
# Looks like your test exited with 255 before it could output anything.

Upgrading to Dancer2-0.207000 allowed the tests to succeed
Log::Report@1.26 was not affected by the version of Dancer2 installed
  Sun Feb 03 03:03:43 2019 Mark [...] Overmeer.net - Correspondence added
CC: ;
Subject: Re: [rt.cpan.org #128413] t/70dancer2.t fails with older versions of Dancer installed
Date: Sun, 3 Feb 2019 08:39:15 +0100
To: James Wright via RT <bug-Log-Report [...] rt.cpan.org>
From: Mark Overmeer <mark [...] overmeer.net>
Hi James, * James Wright via RT (bug-Log-Report@rt.cpan.org) [190203 07:11]: Show quoted text
> Sun Feb 03 02:11:30 2019: Request 128413 was acted upon. > Queue: Log-Report > Subject: t/70dancer2.t fails with older versions of Dancer installed > Broken in: 1.27
Show quoted text
> t/70dancer2.t ......... Dancer2 version 0.166001 > syntax error at > /home/perl/.cpanm/work/1549175997.86578/Log-Report-1.27/blib/lib/Dancer2/Plugin/LogReport.pm > line 164, near "plugin_keywords fatal_handler" > Can't use global @_ in "my" at
The test script has a number of protections against running with too old versions... but that's always a bit hard to test: as developer you always run the latest version. The issue is that the test script itself contains syntax of Dancer2 which is only supported after 0.166001 So, we get into a perl parser error. So, before plan skip_all => "Dancer2 is too old: $Dancer2::VERSION" if $Dancer2::VERSION <= 0.166001; # for to_app() It all croaks. Any suggestions how make this work? Put the whole code inside an eval 'code' block? -- Thanks for reporting, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions drs Mark A.C.J. Overmeer MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
  Sun Feb 03 03:03:43 2019 The RT System itself - Status changed from 'new' to 'open'
  Sat Jul 20 07:43:59 2019 MARKOV [...] cpan.org - Correspondence added
No solution provided. Closing
  Sat Jul 20 07:43:59 2019 MARKOV [...] cpan.org - Status changed from 'open' to 'resolved'