Skip Menu |

This queue is for tickets about the GD CPAN distribution.

Report information
The Basics
Id: 128167
Status: resolved
Worked: 30 min
Priority: 0/
Queue: GD

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.69
Fixed in: (no value)



Subject: Compilation failure on Fedora 28 with system perl (-Wformat=0?)
See subject. A sample report at CPAN Testers may be found here: http://www.cpantesters.org/cpan/report/df308cb6-081e-11e9-a4dc-96702f49dc66 It seems that the extra -Wformat=0 in GD's ccflags is causing the problem. If I remove this option, e.g. like this: diff --git a/Makefile.PL b/Makefile.PL index dd0ad64..6929314 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -259,7 +259,7 @@ print F $DEFINES,"\n"; close F; my $CCFLAGS = $Config{ccflags}; -$CCFLAGS .= " -Wall -Wextra -Wformat=0" if $Config{gccversion} and $] > 5.020; +$CCFLAGS .= " -Wall -Wextra" if $Config{gccversion} and $] > 5.020; my %WriteMakefileArgs = ( 'NAME' => 'GD', --- then compilation is successful.
Subject: Re: [rt.cpan.org #128167] Compilation failure on Fedora 28 with system perl (-Wformat=0?)
Date: Sat, 5 Jan 2019 09:12:43 +0100
To: bug-GD [...] rt.cpan.org
From: Reini Urban <reini.urban [...] gmail.com>
Thanks, they added a -Werror=format-security. Am Fr., 4. Jan. 2019, 22:30 hat Slaven_Rezic via RT <bug-GD@rt.cpan.org> geschrieben: Show quoted text
> Fri Jan 04 16:30:23 2019: Request 128167 was acted upon. > Transaction: Ticket created by SREZIC > Queue: GD > Subject: Compilation failure on Fedora 28 with system perl > (-Wformat=0?) > Broken in: 2.69 > Severity: (no value) > Owner: Nobody > Requestors: SREZIC@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=128167 > > > > See subject. A sample report at CPAN Testers may be found here: > http://www.cpantesters.org/cpan/report/df308cb6-081e-11e9-a4dc-96702f49dc66 > > It seems that the extra -Wformat=0 in GD's ccflags is causing the problem. > If I remove this option, e.g. like this: > > diff --git a/Makefile.PL b/Makefile.PL > index dd0ad64..6929314 100644 > --- a/Makefile.PL > +++ b/Makefile.PL > @@ -259,7 +259,7 @@ print F $DEFINES,"\n"; > close F; > > my $CCFLAGS = $Config{ccflags}; > -$CCFLAGS .= " -Wall -Wextra -Wformat=0" if $Config{gccversion} and $] > > 5.020; > +$CCFLAGS .= " -Wall -Wextra" if $Config{gccversion} and $] > 5.020; > > my %WriteMakefileArgs = ( > 'NAME' => 'GD', > > > --- then compilation is successful. >
Fixed with 2.70 -- Reini Urban