Bug #128149 for DBIx-Class-Schema-Loader: Please ignore Oracle recycle bin

Tue Jan 01 10:02:43 2019 MTHURN [...] cpan.org - Ticket created

Subject:

Please ignore Oracle recycle bin

When loading a schema from Oracle, you should really, really ignore tables that are in the recycle bin. They come out with garbage names like "BIN$pyWpLnQwTbOUB9rQrbwgPA==$0" and often cause problems like Unable to load schema - chosen moniker/class naming style results in moniker clashes. Change the naming style, or supply an explicit moniker_map

Tue Jan 01 17:41:17 2019 ilmari [...] ilmari.org - Correspondence added

Subject:	Re: [rt.cpan.org #128149] Please ignore Oracle recycle bin
Date:	Tue, 01 Jan 2019 22:20:18 +0000
To:	bug-DBIx-Class-Schema-Loader [...] rt.cpan.org
From:	ilmari [...] ilmari.org (Dagfinn Ilmari Mannsåker)

"Martin Thurn via RT" <bug-DBIx-Class-Schema-Loader@rt.cpan.org> writes: Show quoted text

> When loading a schema from Oracle, you should really, really ignore > tables that are in the recycle bin. They come out with garbage names > like "BIN$pyWpLnQwTbOUB9rQrbwgPA==$0" and often cause problems like > > Unable to load schema - chosen moniker/class naming style results in > moniker clashes. Change the naming style, or supply an explicit > moniker_map

Thanks for the report. I don't currently have access to an Oracle instance, could you test if the attached patch works for you? - ilmari -- "I use RMS as a guide in the same way that a boat captain would use a lighthouse. It's good to know where it is, but you generally don't want to find yourself in the same spot." - Tollef Fog Heen

From 05420dd84fc7b004d853b56f39b8a118bfc4b026 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dagfinn=20Ilmari=20Manns=C3=A5ker?= <ilmari@ilmari.org> Date: Tue, 1 Jan 2019 23:14:32 +0100 Subject: [PATCH] Exclude tables in the Oracle Recycle Bin --- lib/DBIx/Class/Schema/Loader/DBI/Oracle.pm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/DBIx/Class/Schema/Loader/DBI/Oracle.pm b/lib/DBIx/Class/Schema/Loader/DBI/Oracle.pm index 6de246d..9b5d7c6 100644 --- a/lib/DBIx/Class/Schema/Loader/DBI/Oracle.pm +++ b/lib/DBIx/Class/Schema/Loader/DBI/Oracle.pm @@ -57,7 +57,11 @@ sub _system_schemas { sub _system_tables { my $self = shift; - return ($self->next::method(@_), 'PLAN_TABLE'); + return ( + $self->next::method(@_), + 'PLAN_TABLE', + qr/\ABIN\$.*\$\d+\z/, # Tables in the recycle bin + ); } sub _dbh_tables { -- 2.20.1

Tue Jan 01 17:41:19 2019 The RT System itself - Status changed from 'new' to 'open'

Wed Jan 02 09:27:13 2019 MTHURN [...] cpan.org - Correspondence added

Works great. However, dbicdump now dies with segmentation fault after writing the pm files. I don't think that was happening before (but I don't see how it could be related to your patch). Thank you!

Thu Jan 03 06:27:07 2019 ilmari [...] ilmari.org - Correspondence added

Subject:	Re: [rt.cpan.org #128149] Please ignore Oracle recycle bin
Date:	Thu, 03 Jan 2019 11:26:49 +0000
To:	bug-DBIx-Class-Schema-Loader [...] rt.cpan.org
From:	ilmari [...] ilmari.org (Dagfinn Ilmari Mannsåker)

"Martin Thurn via RT" <bug-DBIx-Class-Schema-Loader@rt.cpan.org> writes: Show quoted text

> Works great.

Thanks, I'll include it in the next release. Show quoted text

> However, dbicdump now dies with segmentation fault after writing the > pm files. I don't think that was happening before (but I don't see > how it could be related to your patch).

I've occasionally seen segfaults during global destruction, they usually originate in the DBD module. Show quoted text

> Thank you!

Thank you for the report! - ilmari -- "A disappointingly low fraction of the human race is, at any given time, on fire." - Stig Sandbeck Mathisen

Sun Jan 06 15:01:21 2019 ilmari+cpan [...] ilmari.org - Status changed from 'open' to 'patched'