Bug #128132 for DBIx-Class: JSON access support

I have a module that I use internally for generating JSON dereferencing in postgres (col->'foo'->0->>'bar'). I would like to publish this as a standalone helper module or perhaps integrate into DBIC core depending on what you think of it. MySQL has similar syntax (col->>'$.foo[0].bar'), and something similar could probably implemented using LHS functions in sqlite and other databases (although I am only aware of Pg that can do true index functionality on these type of queries). The syntax I am currently using is: $rs->search({ 'col::foo.0.bar::type' => 123 }) As in Pg most of these require type casts to be able to do the compare. Additionally specifying a type of json(b) generates col->'foo'->'bar' which means you can do more advanced Pg queries like: $rs->search({ 'col::foo.0.bar::json' => { '@>' => ... }) The code for this is not too difficult, just some SQLMaker extensions. I have the following questions: 1) is the above syntax reasonable or would you suggest something different? I don't think this type of syntax would be a problem for most existing db schema? Given the difference between key names and array offsets I'd think that the mysql syntax of []s around array offsets may be better. ::'s are obviously inspired by postgres, but it may be worth choosing a different identifier (-> ?) so that in the future support for pg LHS casting could be added. So that would mean syntax would be something like ->search({ 'col->foo[0].bar::type' => ... }). 2) What are the chances of getting this extension into the core dbic SQLMaker code ? It's currently only about 50 lines for Pg/Mysql support. 3) The one issue I have found so far is that in order to enable joins to work correctly I need to do a s/::.*// on the key names in DBIx::Class::Relationship::HasOne::_validate_has_one_condition . Hence asking about 1/2 as I'd rather avoid having to patch that routine on the fly... Mark