Skip Menu |

This queue is for tickets about the Text-Trim CPAN distribution.

Report information
The Basics
Id: 128092
Status: resolved
Priority: 0/
Queue: Text-Trim
People
Owner: matt.lawrence [...] virgin.net
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.02
Fixed in: 1.02_01

History Show all quoted text
  Sat Dec 22 05:13:20 2018 SREZIC [...] cpan.org - Ticket created
Subject: Makefile.PL: compat code does not work everywhere
There are situations where the compat code in Makefile.PL does not work, e.g. if a test-only smoker system without permissions to install is running. Nowadays it's probably better to use configure_requires or don't have a Makefile.PL at all, as cpan installers are smart enough to provide Module::Build automatically if it's missing (and this works even for test-only smokers).
  Mon Dec 24 10:40:04 2018 matt.lawrence [...] virgin.net - Taken
  Fri Sep 20 17:51:34 2019 RJT [...] cpan.org - Status changed from 'new' to 'open'
  Sat Sep 21 13:52:45 2019 RJT [...] cpan.org - Status changed from 'open' to 'patched'
  Sun Sep 22 02:35:09 2019 RJT [...] cpan.org - Correspondence added
On Sat Dec 22 10:13:20 2018, SREZIC wrote: Show quoted text
> There are situations where the compat code in Makefile.PL does not > work, e.g. if a test-only smoker system without permissions to install > is running. Nowadays it's probably better to use configure_requires or > don't have a Makefile.PL at all, as cpan installers are smart enough > to provide Module::Build automatically if it's missing (and this works > even for test-only smokers).
Co-maintainer of Text::Trim here. I've kept Makefile.PL, but reworked it to conform to more recent E:MM usage. The compat code is gone, so the issue should be resolved and tests fine on my systems. I realize it has been awhile, but if you still have a way to retest, and are inclined to do so, would you mind giving the dev release 1.02_01 a quick buzz? Available from either link: https://metacpan.org/release/RJT/Text-Trim-1.02_01 --OR-- http://cpan.org/authors/id/R/RJ/RJT/Text-Trim-1.02_01.tar.gz Either way, thanks for the report! - Ryan
  Sun Sep 22 08:14:40 2019 SREZIC [...] cpan.org - Correspondence added
On 2019-09-22 02:35:09, RJT wrote: Show quoted text
> On Sat Dec 22 10:13:20 2018, SREZIC wrote:
> > There are situations where the compat code in Makefile.PL does not > > work, e.g. if a test-only smoker system without permissions to > > install > > is running. Nowadays it's probably better to use configure_requires > > or > > don't have a Makefile.PL at all, as cpan installers are smart enough > > to provide Module::Build automatically if it's missing (and this > > works > > even for test-only smokers).
> > Co-maintainer of Text::Trim here. I've kept Makefile.PL, but reworked > it to conform to more recent E:MM usage. The compat code is gone, so > the issue should be resolved and tests fine on my systems. I realize > it has been awhile, but if you still have a way to retest, and are > inclined to do so, would you mind giving the dev release 1.02_01 a > quick buzz? Available from either link: > > https://metacpan.org/release/RJT/Text-Trim-1.02_01 --OR-- > http://cpan.org/authors/id/R/RJ/RJT/Text-Trim-1.02_01.tar.gz > > Either way, thanks for the report!
So far 1.02_01 looks fine on my smoker systems. Regards, Slaven
  Sun Sep 22 16:44:03 2019 RJT [...] cpan.org - Correspondence added
On Sun Sep 22 12:14:40 2019, SREZIC wrote: Show quoted text
> > So far 1.02_01 looks fine on my smoker systems. > > Regards, > Slaven
Many thanks, Slaven. 1.03 is now indexed. - Ryan
  Sun Sep 22 16:44:04 2019 RJT [...] cpan.org - Status changed from 'patched' to 'resolved'
  Sun Sep 22 16:44:04 2019 RJT [...] cpan.org - Fixed in 1.02_01 added