Skip Menu |

This queue is for tickets about the autodie CPAN distribution.

Report information
The Basics
Id: 128072
Status: resolved
Priority: 0/
Queue: autodie
People
Owner: Nobody in particular
Requestors: me [...] eboxr.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Thu Dec 20 15:36:26 2018 me [...] eboxr.com - Ticket created
Subject: hash hint should not be used to store references
autodial::Scope::GuardStack::push_hook is using the hint hash %^H to store some references... this is a bad idea. The hints hash (%^H) cannot be used to store hashrefs as values, so any implementation that relies on putting hashrefs in %^H is intrinsically broken. See "Implementation details" in the perlpragma manpage. https://perldoc.perl.org/perlpragma.html#Implementation-details noticed issues there: https://github.com/pjf/autodie/blob/master/lib/autodie/Scope/GuardStack.pm#L28 and POD also suggest to store references in hash hint https://github.com/pjf/autodie/blob/master/lib/autodie/Scope/Guard.pm#L35 also discussed there: https://github.com/pjf/autodie/issues/84 but looks like RT is the official bug tracker so opening a case there too
  Wed Jan 08 10:43:44 2020 TODDR [...] cpan.org - Correspondence added
Response from reporter: "we should close it, I think I opened that case wrongly and this is a sane usage of %^H"
  Wed Jan 08 10:43:45 2020 The RT System itself - Status changed from 'new' to 'open'
  Wed Jan 08 10:43:45 2020 TODDR [...] cpan.org - Status changed from 'open' to 'resolved'