Bug #128067 for HTTP-PublicKeyPins: t/01-pin.t started to fail

Thu Dec 20 02:27:30 2018 SREZIC [...] cpan.org - Ticket created

CC:	MRSCOTTY [...] cpan.org
Subject:	t/01-pin.t started to fail

The tet suite started to fail: .... unable to load certificate 1085054976:error:0909006C:PEM routines:get_name:no start line:/usr/home/projects/freebsd/crypto/openssl/crypto/pem/pem_lib.c:745:Expecting: TRUSTED CERTIFICATE Can't call method "subjectPublicKey" on an undefined value at /usr/home/cpansand/.cpan/build/2018122007/HTTP-PublicKeyPins-0.14-0/blib/lib/HTTP/PublicKeyPins.pm line 121. # Looks like your test exited with 2 just after 24. t/01-pin.t ........ Dubious, test returned 2 (wstat 512, 0x200) Failed 16/40 subtests (less 4 skipped subtests: 20 okay) .... Statistical analysis suggests that this happens with the latest Crypt::PKCS10 version: **************************************************************** Regression 'mod:Crypt::PKCS10' **************************************************************** Name Theta StdErr T-stat [0='const'] 1.0000 0.0000 150310668398078016.00 [1='eq_1.6'] 0.0000 0.0000 0.99 [2='eq_1.8001'] 0.0000 0.0000 1.39 [3='eq_1.8002'] 0.0000 0.0000 1.69 [4='eq_1.800201'] 0.0000 0.0000 5.32 [5='eq_1.9'] 0.0000 0.0000 0.00 [6='eq_2.001'] -1.0000 0.0000 -86781904861702944.00 R^2= 1.000, N= 172, K= 7 ****************************************************************

Thu Dec 20 02:44:03 2018 SREZIC [...] cpan.org - Correspondence added

RT-Send-CC:

MRSCOTTY [...] cpan.org

On 2018-12-20 02:27:30, SREZIC wrote: Show quoted text

> The tet suite started to fail: > > .... > unable to load certificate > 1085054976:error:0909006C:PEM routines:get_name:no start > line:/usr/home/projects/freebsd/crypto/openssl/crypto/pem/pem_lib.c:745:Expecting: > TRUSTED CERTIFICATE > Can't call method "subjectPublicKey" on an undefined value at > /usr/home/cpansand/.cpan/build/2018122007/HTTP-PublicKeyPins-0.14- > 0/blib/lib/HTTP/PublicKeyPins.pm line 121. > # Looks like your test exited with 2 just after 24. > t/01-pin.t ........ > Dubious, test returned 2 (wstat 512, 0x200) > Failed 16/40 subtests > (less 4 skipped subtests: 20 okay) > .... > > Statistical analysis suggests that this happens with the latest > Crypt::PKCS10 version: > > **************************************************************** > Regression 'mod:Crypt::PKCS10' > **************************************************************** > Name Theta StdErr T-stat > [0='const'] 1.0000 0.0000 150310668398078016.00 > [1='eq_1.6'] 0.0000 0.0000 0.99 > [2='eq_1.8001'] 0.0000 0.0000 1.39 > [3='eq_1.8002'] 0.0000 0.0000 1.69 > [4='eq_1.800201'] 0.0000 0.0000 5.32 > [5='eq_1.9'] 0.0000 0.0000 0.00 > [6='eq_2.001'] -1.0000 0.0000 -86781904861702944.00 > > R^2= 1.000, N= 172, K= 7 > ****************************************************************

Well, with more test reports coming in the situation is not that clear. I have also some fresh pass reports, even with Crypt::PKCS10 2.001 installed. So probably something else is causing the failures.

Wed Mar 20 05:16:13 2019 DDICK [...] cpan.org - Status changed from 'new' to 'resolved'

Wed Mar 20 05:16:14 2019 DDICK [...] cpan.org - Fixed in 0.14 added

Mon Apr 15 02:23:56 2019 SREZIC [...] cpan.org - Correspondence added

On 2018-12-20 02:44:03, SREZIC wrote: Show quoted text

> On 2018-12-20 02:27:30, SREZIC wrote:

> > The tet suite started to fail: > > > > .... > > unable to load certificate > > 1085054976:error:0909006C:PEM routines:get_name:no start > > line:/usr/home/projects/freebsd/crypto/openssl/crypto/pem/pem_lib.c:745:Expecting: > > TRUSTED CERTIFICATE > > Can't call method "subjectPublicKey" on an undefined value at > > /usr/home/cpansand/.cpan/build/2018122007/HTTP-PublicKeyPins-0.14- > > 0/blib/lib/HTTP/PublicKeyPins.pm line 121. > > # Looks like your test exited with 2 just after 24. > > t/01-pin.t ........ > > Dubious, test returned 2 (wstat 512, 0x200) > > Failed 16/40 subtests > > (less 4 skipped subtests: 20 okay) > > .... > > > > Statistical analysis suggests that this happens with the latest > > Crypt::PKCS10 version: > > > > **************************************************************** > > Regression 'mod:Crypt::PKCS10' > > **************************************************************** > > Name Theta StdErr T-stat > > [0='const'] 1.0000 0.0000 150310668398078016.00 > > [1='eq_1.6'] 0.0000 0.0000 0.99 > > [2='eq_1.8001'] 0.0000 0.0000 1.39 > > [3='eq_1.8002'] 0.0000 0.0000 1.69 > > [4='eq_1.800201'] 0.0000 0.0000 5.32 > > [5='eq_1.9'] 0.0000 0.0000 0.00 > > [6='eq_2.001'] -1.0000 0.0000 -86781904861702944.00 > > > > R^2= 1.000, N= 172, K= 7 > > ****************************************************************

> > Well, with more test reports coming in the situation is not that > clear. I have also some fresh pass reports, even with Crypt::PKCS10 > 2.001 installed. So probably something else is causing the failures.

Changing again from resolved -> open --- for me it does not look fixed, I still see the error on some of my smokers.

Mon Apr 15 02:23:57 2019 SREZIC [...] cpan.org - Status changed from 'resolved' to 'open'

Mon Apr 15 02:23:57 2019 SREZIC [...] cpan.org - Fixed in 0.14 deleted

Mon Apr 15 05:21:07 2019 DDICK [...] cpan.org - Correspondence added

On Mon Apr 15 16:23:56 2019, SREZIC wrote: Show quoted text

> Changing again from resolved -> open --- for me it does not look > fixed, I still see the error on some of my smokers.

Yeah. Thanks for following up. I've added more debugging to HTTP::PublicKeyPins. Looks like an undeclared dependency in Crypt::PKCS10 for the CryptX module. I've included CryptX as a dependency for HTTP::PublicKeyPins. This is not beautiful, but it will work for the time being. Happy to remove the CryptX dependency when Crypt::PKCS10 updates deps.

Mon Apr 15 05:25:43 2019 DDICK [...] cpan.org - Correspondence added

On Mon Apr 15 19:21:07 2019, DDICK wrote: Show quoted text

> On Mon Apr 15 16:23:56 2019, SREZIC wrote:

> > Changing again from resolved -> open --- for me it does not look > > fixed, I still see the error on some of my smokers.

> > Yeah. Thanks for following up. I've added more debugging to > HTTP::PublicKeyPins. Looks like an undeclared dependency in > Crypt::PKCS10 for the CryptX module. I've included CryptX as a > dependency for HTTP::PublicKeyPins. This is not beautiful, but it > will work for the time being. Happy to remove the CryptX dependency > when Crypt::PKCS10 updates deps.

Reading the INSTALLATION section of Crypt::PKCS10, it mentions the CryptX dependency as only required for some methods. Looks to be an intentional omission by the author. Therefore, this patch will probably stay here.

Tue Apr 16 16:18:51 2019 DDICK [...] cpan.org - Correspondence added

On Mon Apr 15 19:25:43 2019, DDICK wrote: Show quoted text

> On Mon Apr 15 19:21:07 2019, DDICK wrote:

> > On Mon Apr 15 16:23:56 2019, SREZIC wrote:

> > > Changing again from resolved -> open --- for me it does not look > > > fixed, I still see the error on some of my smokers.

> > > > Yeah. Thanks for following up. I've added more debugging to > > HTTP::PublicKeyPins. Looks like an undeclared dependency in > > Crypt::PKCS10 for the CryptX module. I've included CryptX as a > > dependency for HTTP::PublicKeyPins. This is not beautiful, but it > > will work for the time being. Happy to remove the CryptX dependency > > when Crypt::PKCS10 updates deps.

> > Reading the INSTALLATION section of Crypt::PKCS10, it mentions the > CryptX dependency as only required for some methods. Looks to be an > intentional omission by the author. Therefore, this patch will > probably stay here.

Tue Apr 16 16:18:52 2019 DDICK [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Apr 16 16:18:52 2019 DDICK [...] cpan.org - Fixed in 0.15 added