Skip Menu |

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 128030
Status: resolved
Priority: 0/
Queue: Net-SSLeay
People
Owner: chrisn [...] cpan.org
Requestors: PLICEASE [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.83
Fixed in: 1.86_08

History Show all quoted text
  Sun Dec 16 08:52:45 2018 PLICEASE [...] cpan.org - Ticket created
Subject: Fails to build on Perl 5.8.7 and older
Key diagnostics from the log: SSLeay.xs: In function 'ssleay_set_psk_client_callback_invoke': /opt/perl/5.8.1/lib/5.8.1/x86_64-linux/CORE/pp.h:136:29: error: 'n_a' undeclared (first use in this function) #define POPpx (SvPVx(POPs, n_a)) ^ SSLeay.xs: In function 'ssleay_ctx_set_psk_client_callback_invoke': /opt/perl/5.8.1/lib/5.8.1/x86_64-linux/CORE/pp.h:136:29: error: 'n_a' undeclared (first use in this function) #define POPpx (SvPVx(POPs, n_a)) ^ same can be found in cpantesters fails here: http://matrix.cpantesters.org/?dist=Net-SSLeay%201.85;os=linux;perl=5.8.7;reports=1 1.82 was the newest version that built for me. I used cpanm -v Net::SSLeay@1.82 to install.
  Sun Dec 16 11:14:10 2018 chrisn [...] cpan.org - Correspondence added
On Sun Dec 16 13:52:45 2018, PLICEASE wrote: Show quoted text
> Key diagnostics from the log: > > SSLeay.xs: In function 'ssleay_set_psk_client_callback_invoke': > /opt/perl/5.8.1/lib/5.8.1/x86_64-linux/CORE/pp.h:136:29: error: 'n_a' > undeclared (first use in this function) > #define POPpx (SvPVx(POPs, n_a)) > ^ > > SSLeay.xs: In function 'ssleay_ctx_set_psk_client_callback_invoke': > /opt/perl/5.8.1/lib/5.8.1/x86_64-linux/CORE/pp.h:136:29: error: 'n_a' > undeclared (first use in this function) > #define POPpx (SvPVx(POPs, n_a)) > > ^ > > same can be found in cpantesters fails here: > http://matrix.cpantesters.org/?dist=Net- > SSLeay%201.85;os=linux;perl=5.8.7;reports=1 > > 1.82 was the newest version that built for me. I used cpanm -v > Net::SSLeay@1.82 to install.
Thanks for the report, Graham. The use of POPpx in these functions requires a STRLEN variable n_a to be in scope on Perl 5.8.7 and below, due to an API-breaking change that was made in Perl 5.8.8 (see [1] for a discussion about it on p5p). Other functions in SSLeay.xs that use POPpx declare an n_a variable, but those two functions don't. I've now rectified that: https://github.com/radiator-software/p5-net-ssleay/pull/108 This will be included in the next developer release (1.86_08) and the next stable release after that. [1] https://www.nntp.perl.org/group/perl.perl5.porters/2006/03/msg110764.html
  Sun Dec 16 11:14:11 2018 The RT System itself - Status changed from 'new' to 'open'
  Sun Dec 16 11:14:11 2018 chrisn [...] cpan.org - Status changed from 'open' to 'patched'
  Sun Dec 16 11:14:11 2018 chrisn [...] cpan.org - Taken
  Tue Mar 12 14:40:19 2019 chrisn [...] cpan.org - Status changed from 'patched' to 'resolved'
  Tue Mar 12 14:40:19 2019 chrisn [...] cpan.org - Fixed in 1.86_08 added