| Subject: | make test always fails |
make test will always fail because of a bug in test.pl. In the test for stderr and stdout handling for the noninteractive child, the arguments are not specified correctly, leading POE::Wheel::Run to think that the argument of echosrv is part of the Perl executable path. Because this error is reported via stderr and causes an unsuccessful return code, the stderr and died tests work (even though it doesn't happen as expected), but the done test never happens. The arguments to run should either all be in a list or all in a single string. The following patch fixes the problem.
--- test.pl 2004-05-31 23:10:07.000000000 -0500
+++ test.pl.new 2005-05-14 23:02:36.000000000 -0500
@@ -131,12 +131,12 @@
my ($self, $args) = @_[ARG0 .. $#_];
if ($t1n++ == 0) {
- $t1->run("$^X echosrv", "--stderr");
+ $t1->run("$^X echosrv --stderr");
}
else {
ok(1, "done event");
- $t1->run("$^X echosrv", "--die");
+ $t1->run("$^X echosrv --die");
}
}
Thanks for your work on this great module, it made writing PoCo::Player::Musicus a lot easier!