Skip Menu |

This queue is for tickets about the Dancer-Plugin-Database-Core CPAN distribution.

Report information
The Basics
Id: 127745
Status: open
Priority: 0/
Queue: Dancer-Plugin-Database-Core

People
Owner: Nobody in particular
Requestors: mshipper [...] yahoo.com
Cc: davidp [...] preshweb.co.uk
John.G.Fehr [...] charter.com
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.20
Fixed in: (no value)

Attachments


CC: John.G.Fehr [...] charter.com, davidp [...] preshweb.co.uk
Subject: Dancer::Plugin::Database::Core/Dancer2::Plugin::Database - Enhancement (patched files attached)
Hello, My name is Michael Shipper Cpan user is "akalinux". Happy holidays and thank you for the wonderful Perl code you have contributed over the years! I have a use case ( mostly dealing with oracle ) where I need to have my process run code prior to the connection. My apologies for listing this as a bug, I didn't know of a way to provide a patch or enhancement through rt.cpan.org. I would like to propose the following patchs to this module and another patch to the "Dancer2::Plugin::Database" module. I have attached a patched version of both cpan dists to this rt.cpan.org bug. diff Dancer-Plugin-Database-Core-0.20/lib/Dancer/Plugin/Database/Core.pm Dancer-Plugin-Database-Core-0.20c/lib/Dancer/Plugin/Database/Core.pm 13c13 < our $VERSION = '0.20'; --- Show quoted text
> our $VERSION = '0.20c';
204a205 Show quoted text
> $hook_exec->('database_connection_new', $settings);
diff Dancer2-Plugin-Database-2.17/lib/Dancer2/Plugin/Database.pm Dancer2-Plugin-Database-2.17c/lib/Dancer2/Plugin/Database.pm 19c19 < our $VERSION = '2.17'; --- Show quoted text
> our $VERSION = '2.17c';
24c24,25 < database_error); --- Show quoted text
> database_error > database_connection_new);
338a340,345 Show quoted text
> > =item C<database_connection_new> > > Called when a new database connection is about to be created. Receives a hashref of > connection settings as a parameter, containing the settings the plugin will be using > to connect (as obtained from the config file).
Subject: Dancer-Plugin-Database-Core-0.20c.tar.gz

Message body not shown because it is not plain text.

Subject: Dancer2-Plugin-Database-2.17c.tar.gz

Message body not shown because it is not plain text.

RT-Send-CC: davidp [...] preshweb.co.uk, John.G.Fehr [...] charter.com
It seems I could have contributed this patch via a git pull request. Here is the git pull request. https://github.com/bigpresh/Dancer-Plugin-Database/pull/98