Bug #127741 for JSON: Test failures (with JSON::XS 4.0?)

Mon Nov 19 15:42:01 2018 SREZIC [...] cpan.org - Ticket created

CC:	MLEHMANN [...] cpan.org
Subject:	Test failures (with JSON::XS 4.0?)

Some of my smokers report the following new failures: ... # Failed test at t/x02_error.t line 31. # Looks like you failed 1 test of 31. t/x02_error.t ......................... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/31 subtests ... # Failed test at t/xe20_croak_message.t line 19. # '' # doesn't match '(?^:line 1\.)' # Looks like you failed 1 test of 1. t/xe20_croak_message.t ................ Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests ... It seems that this happens if JSON::XS 4.00 is installed.

Mon Nov 19 16:20:17 2018 ishigaki [...] cpan.org - Correspondence added

On Tue Nov 20 05:42:01 2018, SREZIC wrote: Show quoted text

> Some of my smokers report the following new failures: > > ... > # Failed test at t/x02_error.t line 31. > # Looks like you failed 1 test of 31. > t/x02_error.t ......................... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/31 subtests > ... > # Failed test at t/xe20_croak_message.t line 19. > # '' > # doesn't match '(?^:line 1\.)' > # Looks like you failed 1 test of 1. > t/xe20_croak_message.t ................ > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/1 subtests > ... > > It seems that this happens if JSON::XS 4.00 is installed.

Thanks for the report. I believe so as JSON::XS changed its policy about nonref recently. I'll follow the example soonish, though I'll give users more time than usual to fix their applications.

Mon Nov 19 16:20:17 2018 The RT System itself - Status changed from 'new' to 'open'

Sun Dec 02 05:06:37 2018 SREZIC [...] cpan.org - Correspondence added

On 2018-11-19 16:20:17, ISHIGAKI wrote: Show quoted text

> On Tue Nov 20 05:42:01 2018, SREZIC wrote:

> > Some of my smokers report the following new failures: > > > > ... > > # Failed test at t/x02_error.t line 31. > > # Looks like you failed 1 test of 31. > > t/x02_error.t ......................... > > Dubious, test returned 1 (wstat 256, 0x100) > > Failed 1/31 subtests > > ... > > # Failed test at t/xe20_croak_message.t line 19. > > # '' > > # doesn't match '(?^:line 1\.)' > > # Looks like you failed 1 test of 1. > > t/xe20_croak_message.t ................ > > Dubious, test returned 1 (wstat 256, 0x100) > > Failed 1/1 subtests > > ... > > > > It seems that this happens if JSON::XS 4.00 is installed.

> > Thanks for the report. I believe so as JSON::XS changed its policy > about nonref recently. I'll follow the example soonish, though I'll > give users more time than usual to fix their applications.

To keep my smokers running I will apply the following patch: http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/JSON-2.97001-RT127741.patch This is part of my distroprefs file for JSON.pm: https://github.com/eserte/srezic-cpan-distroprefs/blob/7f058774c6431f9986dc2da45482229bbab785c9/JSON.yml#L17

Sun Dec 02 06:17:56 2018 SREZIC [...] cpan.org - Correspondence added

On 2018-12-02 05:06:37, SREZIC wrote: Show quoted text

> On 2018-11-19 16:20:17, ISHIGAKI wrote:

> > On Tue Nov 20 05:42:01 2018, SREZIC wrote:

> > > Some of my smokers report the following new failures: > > > > > > ... > > > # Failed test at t/x02_error.t line 31. > > > # Looks like you failed 1 test of 31. > > > t/x02_error.t ......................... > > > Dubious, test returned 1 (wstat 256, 0x100) > > > Failed 1/31 subtests > > > ... > > > # Failed test at t/xe20_croak_message.t line 19. > > > # '' > > > # doesn't match '(?^:line 1\.)' > > > # Looks like you failed 1 test of 1. > > > t/xe20_croak_message.t ................ > > > Dubious, test returned 1 (wstat 256, 0x100) > > > Failed 1/1 subtests > > > ... > > > > > > It seems that this happens if JSON::XS 4.00 is installed.

> > > > Thanks for the report. I believe so as JSON::XS changed its policy > > about nonref recently. I'll follow the example soonish, though I'll > > give users more time than usual to fix their applications.

> > To keep my smokers running I will apply the following patch: > > http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/JSON- > 2.97001-RT127741.patch > > This is part of my distroprefs file for JSON.pm: > > https://github.com/eserte/srezic-cpan- > distroprefs/blob/7f058774c6431f9986dc2da45482229bbab785c9/JSON.yml#L17

The number of skipped tests in the non-XS case is wrong. Additional patch is needed: http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/JSON-2.97001-RT127741-2.patch The amended distroprefs file: https://github.com/eserte/srezic-cpan-distroprefs/blob/15cd865618833fc9a872a840ec73129370ad1930/JSON.yml#L16

Sun Dec 02 06:49:32 2018 ishigaki [...] cpan.org - Correspondence added

On Sun Dec 02 20:17:56 2018, SREZIC wrote: Show quoted text

> On 2018-12-02 05:06:37, SREZIC wrote:

> > On 2018-11-19 16:20:17, ISHIGAKI wrote:

> > > On Tue Nov 20 05:42:01 2018, SREZIC wrote:

> > > > Some of my smokers report the following new failures: > > > > > > > > ... > > > > # Failed test at t/x02_error.t line 31. > > > > # Looks like you failed 1 test of 31. > > > > t/x02_error.t ......................... > > > > Dubious, test returned 1 (wstat 256, 0x100) > > > > Failed 1/31 subtests > > > > ... > > > > # Failed test at t/xe20_croak_message.t line 19. > > > > # '' > > > > # doesn't match '(?^:line 1\.)' > > > > # Looks like you failed 1 test of 1. > > > > t/xe20_croak_message.t ................ > > > > Dubious, test returned 1 (wstat 256, 0x100) > > > > Failed 1/1 subtests > > > > ... > > > > > > > > It seems that this happens if JSON::XS 4.00 is installed.

> > > > > > Thanks for the report. I believe so as JSON::XS changed its policy > > > about nonref recently. I'll follow the example soonish, though I'll > > > give users more time than usual to fix their applications.

> > > > To keep my smokers running I will apply the following patch: > > > > http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/JSON- > > 2.97001-RT127741.patch > > > > This is part of my distroprefs file for JSON.pm: > > > > https://github.com/eserte/srezic-cpan- > > distroprefs/blob/7f058774c6431f9986dc2da45482229bbab785c9/JSON.yml#L17

> > The number of skipped tests in the non-XS case is wrong. Additional > patch is needed: > > http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/JSON- > 2.97001-RT127741-2.patch > > The amended distroprefs file: > > https://github.com/eserte/srezic-cpan- > distroprefs/blob/15cd865618833fc9a872a840ec73129370ad1930/JSON.yml#L16

Thanks for the patches. I'm preparing 4.0-compatible versions both for JSON and JSON::PP now, which I hope will be out in a day or two.

Mon Dec 03 09:09:45 2018 ishigaki [...] cpan.org - Correspondence added

On Sun Dec 02 20:49:32 2018, ISHIGAKI wrote: Show quoted text

> On Sun Dec 02 20:17:56 2018, SREZIC wrote:

> > On 2018-12-02 05:06:37, SREZIC wrote:

> > > On 2018-11-19 16:20:17, ISHIGAKI wrote:

> > > > On Tue Nov 20 05:42:01 2018, SREZIC wrote:

> > > > > Some of my smokers report the following new failures: > > > > > > > > > > ... > > > > > # Failed test at t/x02_error.t line 31. > > > > > # Looks like you failed 1 test of 31. > > > > > t/x02_error.t ......................... > > > > > Dubious, test returned 1 (wstat 256, 0x100) > > > > > Failed 1/31 subtests > > > > > ... > > > > > # Failed test at t/xe20_croak_message.t line 19. > > > > > # '' > > > > > # doesn't match '(?^:line 1\.)' > > > > > # Looks like you failed 1 test of 1. > > > > > t/xe20_croak_message.t ................ > > > > > Dubious, test returned 1 (wstat 256, 0x100) > > > > > Failed 1/1 subtests > > > > > ... > > > > > > > > > > It seems that this happens if JSON::XS 4.00 is installed.

> > > > > > > > Thanks for the report. I believe so as JSON::XS changed its > > > > policy > > > > about nonref recently. I'll follow the example soonish, though > > > > I'll > > > > give users more time than usual to fix their applications.

> > > > > > To keep my smokers running I will apply the following patch: > > > > > > http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/JSON- > > > 2.97001-RT127741.patch > > > > > > This is part of my distroprefs file for JSON.pm: > > > > > > https://github.com/eserte/srezic-cpan- > > > distroprefs/blob/7f058774c6431f9986dc2da45482229bbab785c9/JSON.yml#L17

> > > > The number of skipped tests in the non-XS case is wrong. Additional > > patch is needed: > > > > http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/JSON- > > 2.97001-RT127741-2.patch > > > > The amended distroprefs file: > > > > https://github.com/eserte/srezic-cpan- > > distroprefs/blob/15cd865618833fc9a872a840ec73129370ad1930/JSON.yml#L16

> > > Thanks for the patches. I'm preparing 4.0-compatible versions both for > JSON and JSON::PP now, which I hope will be out in a day or two.

Shipped both JSON and JSON::PP as 3.99_01. I'll ship 4.0 when I get enough testers reports (in a few days, I hope).

Thu Dec 06 12:57:04 2018 ishigaki [...] cpan.org - Correspondence added

On Mon Dec 03 23:09:45 2018, ISHIGAKI wrote: Show quoted text

> On Sun Dec 02 20:49:32 2018, ISHIGAKI wrote:

> > On Sun Dec 02 20:17:56 2018, SREZIC wrote:

> > > On 2018-12-02 05:06:37, SREZIC wrote:

> > > > On 2018-11-19 16:20:17, ISHIGAKI wrote:

> > > > > On Tue Nov 20 05:42:01 2018, SREZIC wrote:

> > > > > > Some of my smokers report the following new failures: > > > > > > > > > > > > ... > > > > > > # Failed test at t/x02_error.t line 31. > > > > > > # Looks like you failed 1 test of 31. > > > > > > t/x02_error.t ......................... > > > > > > Dubious, test returned 1 (wstat 256, 0x100) > > > > > > Failed 1/31 subtests > > > > > > ... > > > > > > # Failed test at t/xe20_croak_message.t line 19. > > > > > > # '' > > > > > > # doesn't match '(?^:line 1\.)' > > > > > > # Looks like you failed 1 test of 1. > > > > > > t/xe20_croak_message.t ................ > > > > > > Dubious, test returned 1 (wstat 256, 0x100) > > > > > > Failed 1/1 subtests > > > > > > ... > > > > > > > > > > > > It seems that this happens if JSON::XS 4.00 is installed.

> > > > > > > > > > Thanks for the report. I believe so as JSON::XS changed its > > > > > policy > > > > > about nonref recently. I'll follow the example soonish, though > > > > > I'll > > > > > give users more time than usual to fix their applications.

> > > > > > > > To keep my smokers running I will apply the following patch: > > > > > > > > http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/JSON- > > > > 2.97001-RT127741.patch > > > > > > > > This is part of my distroprefs file for JSON.pm: > > > > > > > > https://github.com/eserte/srezic-cpan- > > > > distroprefs/blob/7f058774c6431f9986dc2da45482229bbab785c9/JSON.yml#L17

> > > > > > The number of skipped tests in the non-XS case is wrong. Additional > > > patch is needed: > > > > > > http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/JSON- > > > 2.97001-RT127741-2.patch > > > > > > The amended distroprefs file: > > > > > > https://github.com/eserte/srezic-cpan- > > > distroprefs/blob/15cd865618833fc9a872a840ec73129370ad1930/JSON.yml#L16

> > > > > > Thanks for the patches. I'm preparing 4.0-compatible versions both > > for > > JSON and JSON::PP now, which I hope will be out in a day or two.

> > > Shipped both JSON and JSON::PP as 3.99_01. I'll ship 4.0 when I get > enough testers reports (in a few days, I hope).

Shipped 4.00 for both. Thanks.

Thu Dec 06 12:57:04 2018 ishigaki [...] cpan.org - Status changed from 'open' to 'resolved'