Skip Menu |

This queue is for tickets about the Perl-Tidy CPAN distribution.

Report information
The Basics
Id: 127679
Status: resolved
Priority: 0/
Queue: Perl-Tidy

People
Owner: Nobody in particular
Requestors: SHLOMIF [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: "cpan -i Perl::Tidy" fails the tests on Linux
example output: --------------- cp lib/Perl/Tidy/VerticalAligner.pm blib/lib/Perl/Tidy/VerticalAligner.pm cp lib/Perl/Tidy/Debugger.pm blib/lib/Perl/Tidy/Debugger.pm cp lib/Perl/Tidy/Formatter.pm blib/lib/Perl/Tidy/Formatter.pm cp lib/Perl/Tidy/VerticalAligner/Alignment.pm blib/lib/Perl/Tidy/VerticalAligner/Alignment.pm cp lib/Perl/Tidy/LineSink.pm blib/lib/Perl/Tidy/LineSink.pm cp lib/Perl/Tidy/Logger.pm blib/lib/Perl/Tidy/Logger.pm cp lib/Perl/Tidy.pod blib/lib/Perl/Tidy.pod cp lib/Perl/Tidy/IOScalarArray.pm blib/lib/Perl/Tidy/IOScalarArray.pm cp lib/Perl/Tidy/FileWriter.pm blib/lib/Perl/Tidy/FileWriter.pm cp lib/Perl/Tidy/Diagnostics.pm blib/lib/Perl/Tidy/Diagnostics.pm cp lib/Perl/Tidy/VerticalAligner/Line.pm blib/lib/Perl/Tidy/VerticalAligner/Line.pm cp lib/Perl/Tidy/IndentationItem.pm blib/lib/Perl/Tidy/IndentationItem.pm cp lib/Perl/Tidy/Tokenizer.pm blib/lib/Perl/Tidy/Tokenizer.pm cp lib/Perl/Tidy/IOScalar.pm blib/lib/Perl/Tidy/IOScalar.pm cp lib/Perl/Tidy/DevNull.pm blib/lib/Perl/Tidy/DevNull.pm cp lib/Perl/Tidy/HtmlWriter.pm blib/lib/Perl/Tidy/HtmlWriter.pm cp lib/Perl/Tidy/LineSource.pm blib/lib/Perl/Tidy/LineSource.pm cp lib/Perl/Tidy/LineBuffer.pm blib/lib/Perl/Tidy/LineBuffer.pm cp lib/Perl/Tidy.pm blib/lib/Perl/Tidy.pm Manifying 3 pod documents SHANCOCK/Perl-Tidy-20181117.tar.gz /usr/bin/make -- OK Running make test PERL_DL_NONLAZY=1 "/home/shlomif/apps/perl/brew/perls/perl-5.26.2/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/filter_example.t .. 1/1 # Test 1 got: "use Method::Signatures::Simple;\nmethod foo1 { $self->bar }\n\n# with signature\nmethod foo2 ( $bar, %opts )\n{\n $self->bar( reverse $bar ) if $opts{rev};\n}\n\n# attributes\nmethod foo3 : lvalue\n{\n $self->{foo};\n}\n\n# change invocant name\nmethod foo4 ($class: $bar) { $class->bar($bar) }\n" (t/filter_example.t at line 65) # Expected: "use Method::Signatures::Simple;\nmethod foo1 { $self->bar }\n\n# with signature\nmethod foo2 ( $bar, %opts ) {\n $self->bar( reverse $bar ) if $opts{rev};\n}\n\n# attributes\nmethod foo3 : lvalue {\n $self->{foo};\n}\n\n# change invocant name\nmethod foo4 ($class: $bar) { $class->bar($bar) }\n" # (Install the Algorithm::Diff module to have differences in multiline # output explained. You might also set the PERL_TEST_DIFF environment # variable to run a diff program on the output.) # t/filter_example.t line 65 is: ok( $output, $expect ); t/filter_example.t .. Failed 1/1 subtests t/snippets1.t ....... ok t/snippets10.t ...... ok t/snippets11.t ...... ok t/snippets12.t ...... ok t/snippets13.t ...... ok t/snippets2.t ....... ok t/snippets3.t ....... ok t/snippets4.t ....... ok t/snippets5.t ....... ok t/snippets6.t ....... ok t/snippets7.t ....... ok t/snippets8.t ....... ok t/snippets9.t ....... ok t/test.t ............ ok t/testsa.t .......... ok t/testss.t .......... ok t/testwide.t ........ ok Test Summary Report ------------------- t/filter_example.t (Wstat: 0 Tests: 1 Failed: 1) Failed test: 1 Files=18, Tests=261, 19 wallclock secs ( 0.12 usr 0.03 sys + 19.19 cusr 0.23 csys = 19.57 CPU) Result: FAIL Failed 1/18 test programs. 1/261 subtests failed. make: *** [Makefile:859: test_dynamic] Error 255 SHANCOCK/Perl-Tidy-20181117.tar.gz /usr/bin/make test -- NOT OK //hint// to see the cpan-testers results for installing this module, try: reports SHANCOCK/Perl-Tidy-20181117.tar.gz [shlomif@telaviv1 ~]$ ------------ tried with both perl 5.28.0 and 5.26.2 from perlbrew.
On Sat Nov 17 06:33:29 2018, SHLOMIF wrote: Show quoted text
> example output: > > --------------- > cp lib/Perl/Tidy/VerticalAligner.pm > blib/lib/Perl/Tidy/VerticalAligner.pm > cp lib/Perl/Tidy/Debugger.pm blib/lib/Perl/Tidy/Debugger.pm > cp lib/Perl/Tidy/Formatter.pm blib/lib/Perl/Tidy/Formatter.pm > cp lib/Perl/Tidy/VerticalAligner/Alignment.pm > blib/lib/Perl/Tidy/VerticalAligner/Alignment.pm > cp lib/Perl/Tidy/LineSink.pm blib/lib/Perl/Tidy/LineSink.pm > cp lib/Perl/Tidy/Logger.pm blib/lib/Perl/Tidy/Logger.pm > cp lib/Perl/Tidy.pod blib/lib/Perl/Tidy.pod > cp lib/Perl/Tidy/IOScalarArray.pm blib/lib/Perl/Tidy/IOScalarArray.pm > cp lib/Perl/Tidy/FileWriter.pm blib/lib/Perl/Tidy/FileWriter.pm > cp lib/Perl/Tidy/Diagnostics.pm blib/lib/Perl/Tidy/Diagnostics.pm > cp lib/Perl/Tidy/VerticalAligner/Line.pm > blib/lib/Perl/Tidy/VerticalAligner/Line.pm > cp lib/Perl/Tidy/IndentationItem.pm > blib/lib/Perl/Tidy/IndentationItem.pm > cp lib/Perl/Tidy/Tokenizer.pm blib/lib/Perl/Tidy/Tokenizer.pm > cp lib/Perl/Tidy/IOScalar.pm blib/lib/Perl/Tidy/IOScalar.pm > cp lib/Perl/Tidy/DevNull.pm blib/lib/Perl/Tidy/DevNull.pm > cp lib/Perl/Tidy/HtmlWriter.pm blib/lib/Perl/Tidy/HtmlWriter.pm > cp lib/Perl/Tidy/LineSource.pm blib/lib/Perl/Tidy/LineSource.pm > cp lib/Perl/Tidy/LineBuffer.pm blib/lib/Perl/Tidy/LineBuffer.pm > cp lib/Perl/Tidy.pm blib/lib/Perl/Tidy.pm > Manifying 3 pod documents > SHANCOCK/Perl-Tidy-20181117.tar.gz > /usr/bin/make -- OK > Running make test > PERL_DL_NONLAZY=1 "/home/shlomif/apps/perl/brew/perls/perl- > 5.26.2/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" > "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', > 'blib/arch')" t/*.t > t/filter_example.t .. 1/1 # Test 1 got: "use > Method::Signatures::Simple;\nmethod foo1 { $self->bar }\n\n# with > signature\nmethod foo2 ( $bar, %opts )\n{\n $self->bar( reverse > $bar ) if $opts{rev};\n}\n\n# attributes\nmethod foo3 : lvalue\n{\n > $self->{foo};\n}\n\n# change invocant name\nmethod foo4 ($class: $bar) > { $class->bar($bar) }\n" (t/filter_example.t at line 65) > # Expected: "use Method::Signatures::Simple;\nmethod foo1 { $self-
> >bar }\n\n# with signature\nmethod foo2 ( $bar, %opts ) {\n $self- > >bar( reverse $bar ) if $opts{rev};\n}\n\n# attributes\nmethod foo3 :
> lvalue {\n $self->{foo};\n}\n\n# change invocant name\nmethod > foo4 ($class: $bar) { $class->bar($bar) }\n" > # (Install the Algorithm::Diff module to have differences in > multiline > # output explained. You might also set the PERL_TEST_DIFF > environment > # variable to run a diff program on the output.) > # t/filter_example.t line 65 is: ok( $output, $expect ); > t/filter_example.t .. Failed 1/1 subtests > t/snippets1.t ....... ok > t/snippets10.t ...... ok > t/snippets11.t ...... ok > t/snippets12.t ...... ok > t/snippets13.t ...... ok > t/snippets2.t ....... ok > t/snippets3.t ....... ok > t/snippets4.t ....... ok > t/snippets5.t ....... ok > t/snippets6.t ....... ok > t/snippets7.t ....... ok > t/snippets8.t ....... ok > t/snippets9.t ....... ok > t/test.t ............ ok > t/testsa.t .......... ok > t/testss.t .......... ok > t/testwide.t ........ ok > > Test Summary Report > ------------------- > t/filter_example.t (Wstat: 0 Tests: 1 Failed: 1) > Failed test: 1 > Files=18, Tests=261, 19 wallclock secs ( 0.12 usr 0.03 sys + 19.19 > cusr 0.23 csys = 19.57 CPU) > Result: FAIL > Failed 1/18 test programs. 1/261 subtests failed. > make: *** [Makefile:859: test_dynamic] Error 255 > SHANCOCK/Perl-Tidy-20181117.tar.gz > /usr/bin/make test -- NOT OK > //hint// to see the cpan-testers results for installing this module, > try: > reports SHANCOCK/Perl-Tidy-20181117.tar.gz > [shlomif@telaviv1 ~]$ > ------------ > > tried with both perl 5.28.0 and 5.26.2 from perlbrew.
Note that the tests fail on mageia v7 x86-64 and on a fedora 29 x64 vm, but pass on an ubuntu 18.04 x64 VM.
On Sat Nov 17 08:31:52 2018, SHLOMIF wrote: Show quoted text
> On Sat Nov 17 06:33:29 2018, SHLOMIF wrote:
> > example output: > > > > --------------- > > cp lib/Perl/Tidy/VerticalAligner.pm > > blib/lib/Perl/Tidy/VerticalAligner.pm > > cp lib/Perl/Tidy/Debugger.pm blib/lib/Perl/Tidy/Debugger.pm > > cp lib/Perl/Tidy/Formatter.pm blib/lib/Perl/Tidy/Formatter.pm > > cp lib/Perl/Tidy/VerticalAligner/Alignment.pm > > blib/lib/Perl/Tidy/VerticalAligner/Alignment.pm > > cp lib/Perl/Tidy/LineSink.pm blib/lib/Perl/Tidy/LineSink.pm > > cp lib/Perl/Tidy/Logger.pm blib/lib/Perl/Tidy/Logger.pm > > cp lib/Perl/Tidy.pod blib/lib/Perl/Tidy.pod > > cp lib/Perl/Tidy/IOScalarArray.pm blib/lib/Perl/Tidy/IOScalarArray.pm > > cp lib/Perl/Tidy/FileWriter.pm blib/lib/Perl/Tidy/FileWriter.pm > > cp lib/Perl/Tidy/Diagnostics.pm blib/lib/Perl/Tidy/Diagnostics.pm > > cp lib/Perl/Tidy/VerticalAligner/Line.pm > > blib/lib/Perl/Tidy/VerticalAligner/Line.pm > > cp lib/Perl/Tidy/IndentationItem.pm > > blib/lib/Perl/Tidy/IndentationItem.pm > > cp lib/Perl/Tidy/Tokenizer.pm blib/lib/Perl/Tidy/Tokenizer.pm > > cp lib/Perl/Tidy/IOScalar.pm blib/lib/Perl/Tidy/IOScalar.pm > > cp lib/Perl/Tidy/DevNull.pm blib/lib/Perl/Tidy/DevNull.pm > > cp lib/Perl/Tidy/HtmlWriter.pm blib/lib/Perl/Tidy/HtmlWriter.pm > > cp lib/Perl/Tidy/LineSource.pm blib/lib/Perl/Tidy/LineSource.pm > > cp lib/Perl/Tidy/LineBuffer.pm blib/lib/Perl/Tidy/LineBuffer.pm > > cp lib/Perl/Tidy.pm blib/lib/Perl/Tidy.pm > > Manifying 3 pod documents > > SHANCOCK/Perl-Tidy-20181117.tar.gz > > /usr/bin/make -- OK > > Running make test > > PERL_DL_NONLAZY=1 "/home/shlomif/apps/perl/brew/perls/perl- > > 5.26.2/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" > > "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', > > 'blib/arch')" t/*.t > > t/filter_example.t .. 1/1 # Test 1 got: "use > > Method::Signatures::Simple;\nmethod foo1 { $self->bar }\n\n# with > > signature\nmethod foo2 ( $bar, %opts )\n{\n $self->bar( reverse > > $bar ) if $opts{rev};\n}\n\n# attributes\nmethod foo3 : lvalue\n{\n > > $self->{foo};\n}\n\n# change invocant name\nmethod foo4 ($class: > > $bar) > > { $class->bar($bar) }\n" (t/filter_example.t at line 65) > > # Expected: "use Method::Signatures::Simple;\nmethod foo1 { $self-
> > > bar }\n\n# with signature\nmethod foo2 ( $bar, %opts ) {\n > > > $self- > > > bar( reverse $bar ) if $opts{rev};\n}\n\n# attributes\nmethod foo3 > > > :
> > lvalue {\n $self->{foo};\n}\n\n# change invocant name\nmethod > > foo4 ($class: $bar) { $class->bar($bar) }\n" > > # (Install the Algorithm::Diff module to have differences in > > multiline > > # output explained. You might also set the PERL_TEST_DIFF > > environment > > # variable to run a diff program on the output.) > > # t/filter_example.t line 65 is: ok( $output, $expect ); > > t/filter_example.t .. Failed 1/1 subtests > > t/snippets1.t ....... ok > > t/snippets10.t ...... ok > > t/snippets11.t ...... ok > > t/snippets12.t ...... ok > > t/snippets13.t ...... ok > > t/snippets2.t ....... ok > > t/snippets3.t ....... ok > > t/snippets4.t ....... ok > > t/snippets5.t ....... ok > > t/snippets6.t ....... ok > > t/snippets7.t ....... ok > > t/snippets8.t ....... ok > > t/snippets9.t ....... ok > > t/test.t ............ ok > > t/testsa.t .......... ok > > t/testss.t .......... ok > > t/testwide.t ........ ok > > > > Test Summary Report > > ------------------- > > t/filter_example.t (Wstat: 0 Tests: 1 Failed: 1) > > Failed test: 1 > > Files=18, Tests=261, 19 wallclock secs ( 0.12 usr 0.03 sys + 19.19 > > cusr 0.23 csys = 19.57 CPU) > > Result: FAIL > > Failed 1/18 test programs. 1/261 subtests failed. > > make: *** [Makefile:859: test_dynamic] Error 255 > > SHANCOCK/Perl-Tidy-20181117.tar.gz > > /usr/bin/make test -- NOT OK > > //hint// to see the cpan-testers results for installing this module, > > try: > > reports SHANCOCK/Perl-Tidy-20181117.tar.gz > > [shlomif@telaviv1 ~]$ > > ------------ > > > > tried with both perl 5.28.0 and 5.26.2 from perlbrew.
> > Note that the tests fail on mageia v7 x86-64 and on a fedora 29 x64 > vm, but pass on an ubuntu 18.04 x64 VM.
Hi! I think I found what the problem is. I had this under ~/.perltidyrc : shlomif[rpms]:$mageia/perltidy$ cat ~/.perltidyrc.bak -ci=4 -bl -cti=0 shlomif[rpms]:$mageia/perltidy$ Renaming it made the tests pass.
Subject: Re: [rt.cpan.org #127679] "cpan -i Perl::Tidy" fails the tests on Linux
Date: Sat, 17 Nov 2018 07:05:27 -0800
To: bug-Perl-Tidy [...] rt.cpan.org
From: Steven Hancock <s7078hancock [...] gmail.com>
Hi Schlomi, Thanks for he notes - I'm not sure what what is going on - do I need to make a change? Steve On Sat, Nov 17, 2018 at 3:33 AM Shlomi Fish via RT < bug-Perl-Tidy@rt.cpan.org> wrote: Show quoted text
> Sat Nov 17 06:33:29 2018: Request 127679 was acted upon. > Transaction: Ticket created by SHLOMIF > Queue: Perl-Tidy > Subject: "cpan -i Perl::Tidy" fails the tests on Linux > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: SHLOMIF@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=127679 > > > > example output: > > --------------- > cp lib/Perl/Tidy/VerticalAligner.pm blib/lib/Perl/Tidy/VerticalAligner.pm > cp lib/Perl/Tidy/Debugger.pm blib/lib/Perl/Tidy/Debugger.pm > cp lib/Perl/Tidy/Formatter.pm blib/lib/Perl/Tidy/Formatter.pm > cp lib/Perl/Tidy/VerticalAligner/Alignment.pm > blib/lib/Perl/Tidy/VerticalAligner/Alignment.pm > cp lib/Perl/Tidy/LineSink.pm blib/lib/Perl/Tidy/LineSink.pm > cp lib/Perl/Tidy/Logger.pm blib/lib/Perl/Tidy/Logger.pm > cp lib/Perl/Tidy.pod blib/lib/Perl/Tidy.pod > cp lib/Perl/Tidy/IOScalarArray.pm blib/lib/Perl/Tidy/IOScalarArray.pm > cp lib/Perl/Tidy/FileWriter.pm blib/lib/Perl/Tidy/FileWriter.pm > cp lib/Perl/Tidy/Diagnostics.pm blib/lib/Perl/Tidy/Diagnostics.pm > cp lib/Perl/Tidy/VerticalAligner/Line.pm > blib/lib/Perl/Tidy/VerticalAligner/Line.pm > cp lib/Perl/Tidy/IndentationItem.pm blib/lib/Perl/Tidy/IndentationItem.pm > cp lib/Perl/Tidy/Tokenizer.pm blib/lib/Perl/Tidy/Tokenizer.pm > cp lib/Perl/Tidy/IOScalar.pm blib/lib/Perl/Tidy/IOScalar.pm > cp lib/Perl/Tidy/DevNull.pm blib/lib/Perl/Tidy/DevNull.pm > cp lib/Perl/Tidy/HtmlWriter.pm blib/lib/Perl/Tidy/HtmlWriter.pm > cp lib/Perl/Tidy/LineSource.pm blib/lib/Perl/Tidy/LineSource.pm > cp lib/Perl/Tidy/LineBuffer.pm blib/lib/Perl/Tidy/LineBuffer.pm > cp lib/Perl/Tidy.pm blib/lib/Perl/Tidy.pm > Manifying 3 pod documents > SHANCOCK/Perl-Tidy-20181117.tar.gz > /usr/bin/make -- OK > Running make test > PERL_DL_NONLAZY=1 > "/home/shlomif/apps/perl/brew/perls/perl-5.26.2/bin/perl" > "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef > *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t > t/filter_example.t .. 1/1 # Test 1 got: "use > Method::Signatures::Simple;\nmethod foo1 { $self->bar }\n\n# with > signature\nmethod foo2 ( $bar, %opts )\n{\n $self->bar( reverse $bar ) > if $opts{rev};\n}\n\n# attributes\nmethod foo3 : lvalue\n{\n > $self->{foo};\n}\n\n# change invocant name\nmethod foo4 ($class: $bar) { > $class->bar($bar) }\n" (t/filter_example.t at line 65) > # Expected: "use Method::Signatures::Simple;\nmethod foo1 { $self->bar > }\n\n# with signature\nmethod foo2 ( $bar, %opts ) {\n $self->bar( > reverse $bar ) if $opts{rev};\n}\n\n# attributes\nmethod foo3 : lvalue {\n > $self->{foo};\n}\n\n# change invocant name\nmethod > foo4 ($class: $bar) { $class->bar($bar) }\n" > # (Install the Algorithm::Diff module to have differences in multiline > # output explained. You might also set the PERL_TEST_DIFF environment > # variable to run a diff program on the output.) > # t/filter_example.t line 65 is: ok( $output, $expect ); > t/filter_example.t .. Failed 1/1 subtests > t/snippets1.t ....... ok > t/snippets10.t ...... ok > t/snippets11.t ...... ok > t/snippets12.t ...... ok > t/snippets13.t ...... ok > t/snippets2.t ....... ok > t/snippets3.t ....... ok > t/snippets4.t ....... ok > t/snippets5.t ....... ok > t/snippets6.t ....... ok > t/snippets7.t ....... ok > t/snippets8.t ....... ok > t/snippets9.t ....... ok > t/test.t ............ ok > t/testsa.t .......... ok > t/testss.t .......... ok > t/testwide.t ........ ok > > Test Summary Report > ------------------- > t/filter_example.t (Wstat: 0 Tests: 1 Failed: 1) > Failed test: 1 > Files=18, Tests=261, 19 wallclock secs ( 0.12 usr 0.03 sys + 19.19 cusr > 0.23 csys = 19.57 CPU) > Result: FAIL > Failed 1/18 test programs. 1/261 subtests failed. > make: *** [Makefile:859: test_dynamic] Error 255 > SHANCOCK/Perl-Tidy-20181117.tar.gz > /usr/bin/make test -- NOT OK > //hint// to see the cpan-testers results for installing this module, try: > reports SHANCOCK/Perl-Tidy-20181117.tar.gz > [shlomif@telaviv1 ~]$ > ------------ > > tried with both perl 5.28.0 and 5.26.2 from perlbrew. > >
Subject: Re: [rt.cpan.org #127679] "cpan -i Perl::Tidy" fails the tests on Linux
Date: Sat, 17 Nov 2018 07:14:34 -0800
To: bug-Perl-Tidy [...] rt.cpan.org
From: Steven Hancock <s7078hancock [...] gmail.com>
Okay, I think I reproduced it. It looks like I need to include a dummy .perltidyrc file with the distribution and apply it in the filter_example.t script. I'll do that in the next release. I do include testing at Travis CI as you suggested last time. Steve On Sat, Nov 17, 2018 at 7:06 AM Steven Hancock via RT < bug-Perl-Tidy@rt.cpan.org> wrote: Show quoted text
> Queue: Perl-Tidy > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=127679 > > > Hi Schlomi, > Thanks for he notes - I'm not sure what what is going on - do I need to > make a change? > Steve > > On Sat, Nov 17, 2018 at 3:33 AM Shlomi Fish via RT < > bug-Perl-Tidy@rt.cpan.org> wrote: >
> > Sat Nov 17 06:33:29 2018: Request 127679 was acted upon. > > Transaction: Ticket created by SHLOMIF > > Queue: Perl-Tidy > > Subject: "cpan -i Perl::Tidy" fails the tests on Linux > > Broken in: (no value) > > Severity: (no value) > > Owner: Nobody > > Requestors: SHLOMIF@cpan.org > > Status: new > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=127679 > > > > > > > example output: > > > > --------------- > > cp lib/Perl/Tidy/VerticalAligner.pm blib/lib/Perl/Tidy/VerticalAligner.pm > > cp lib/Perl/Tidy/Debugger.pm blib/lib/Perl/Tidy/Debugger.pm > > cp lib/Perl/Tidy/Formatter.pm blib/lib/Perl/Tidy/Formatter.pm > > cp lib/Perl/Tidy/VerticalAligner/Alignment.pm > > blib/lib/Perl/Tidy/VerticalAligner/Alignment.pm > > cp lib/Perl/Tidy/LineSink.pm blib/lib/Perl/Tidy/LineSink.pm > > cp lib/Perl/Tidy/Logger.pm blib/lib/Perl/Tidy/Logger.pm > > cp lib/Perl/Tidy.pod blib/lib/Perl/Tidy.pod > > cp lib/Perl/Tidy/IOScalarArray.pm blib/lib/Perl/Tidy/IOScalarArray.pm > > cp lib/Perl/Tidy/FileWriter.pm blib/lib/Perl/Tidy/FileWriter.pm > > cp lib/Perl/Tidy/Diagnostics.pm blib/lib/Perl/Tidy/Diagnostics.pm > > cp lib/Perl/Tidy/VerticalAligner/Line.pm > > blib/lib/Perl/Tidy/VerticalAligner/Line.pm > > cp lib/Perl/Tidy/IndentationItem.pm blib/lib/Perl/Tidy/IndentationItem.pm > > cp lib/Perl/Tidy/Tokenizer.pm blib/lib/Perl/Tidy/Tokenizer.pm > > cp lib/Perl/Tidy/IOScalar.pm blib/lib/Perl/Tidy/IOScalar.pm > > cp lib/Perl/Tidy/DevNull.pm blib/lib/Perl/Tidy/DevNull.pm > > cp lib/Perl/Tidy/HtmlWriter.pm blib/lib/Perl/Tidy/HtmlWriter.pm > > cp lib/Perl/Tidy/LineSource.pm blib/lib/Perl/Tidy/LineSource.pm > > cp lib/Perl/Tidy/LineBuffer.pm blib/lib/Perl/Tidy/LineBuffer.pm > > cp lib/Perl/Tidy.pm blib/lib/Perl/Tidy.pm > > Manifying 3 pod documents > > SHANCOCK/Perl-Tidy-20181117.tar.gz > > /usr/bin/make -- OK > > Running make test > > PERL_DL_NONLAZY=1 > > "/home/shlomif/apps/perl/brew/perls/perl-5.26.2/bin/perl" > > "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef > > *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t > > t/filter_example.t .. 1/1 # Test 1 got: "use > > Method::Signatures::Simple;\nmethod foo1 { $self->bar }\n\n# with > > signature\nmethod foo2 ( $bar, %opts )\n{\n $self->bar( reverse $bar ) > > if $opts{rev};\n}\n\n# attributes\nmethod foo3 : lvalue\n{\n > > $self->{foo};\n}\n\n# change invocant name\nmethod foo4 ($class: $bar) { > > $class->bar($bar) }\n" (t/filter_example.t at line 65) > > # Expected: "use Method::Signatures::Simple;\nmethod foo1 { $self->bar > > }\n\n# with signature\nmethod foo2 ( $bar, %opts ) {\n $self->bar( > > reverse $bar ) if $opts{rev};\n}\n\n# attributes\nmethod foo3 : lvalue
> {\n
> > $self->{foo};\n}\n\n# change invocant name\nmethod > > foo4 ($class: $bar) { $class->bar($bar) }\n" > > # (Install the Algorithm::Diff module to have differences in
> multiline
> > # output explained. You might also set the PERL_TEST_DIFF
> environment
> > # variable to run a diff program on the output.) > > # t/filter_example.t line 65 is: ok( $output, $expect ); > > t/filter_example.t .. Failed 1/1 subtests > > t/snippets1.t ....... ok > > t/snippets10.t ...... ok > > t/snippets11.t ...... ok > > t/snippets12.t ...... ok > > t/snippets13.t ...... ok > > t/snippets2.t ....... ok > > t/snippets3.t ....... ok > > t/snippets4.t ....... ok > > t/snippets5.t ....... ok > > t/snippets6.t ....... ok > > t/snippets7.t ....... ok > > t/snippets8.t ....... ok > > t/snippets9.t ....... ok > > t/test.t ............ ok > > t/testsa.t .......... ok > > t/testss.t .......... ok > > t/testwide.t ........ ok > > > > Test Summary Report > > ------------------- > > t/filter_example.t (Wstat: 0 Tests: 1 Failed: 1) > > Failed test: 1 > > Files=18, Tests=261, 19 wallclock secs ( 0.12 usr 0.03 sys + 19.19 cusr > > 0.23 csys = 19.57 CPU) > > Result: FAIL > > Failed 1/18 test programs. 1/261 subtests failed. > > make: *** [Makefile:859: test_dynamic] Error 255 > > SHANCOCK/Perl-Tidy-20181117.tar.gz > > /usr/bin/make test -- NOT OK > > //hint// to see the cpan-testers results for installing this module, try: > > reports SHANCOCK/Perl-Tidy-20181117.tar.gz > > [shlomif@telaviv1 ~]$ > > ------------ > > > > tried with both perl 5.28.0 and 5.26.2 from perlbrew. > > > >
> >
CC: SHLOMIF [...] cpan.org
Subject: Re: [rt.cpan.org #127679] "cpan -i Perl::Tidy" fails the tests on Linux
Date: Sun, 18 Nov 2018 12:39:24 +0200
To: "Steven Hancock via RT" <bug-Perl-Tidy [...] rt.cpan.org>
From: Shlomi Fish <shlomif [...] shlomifish.org>
On Sat, 17 Nov 2018 10:14:58 -0500 "Steven Hancock via RT" <bug-Perl-Tidy@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=127679 > > > Okay, I think I reproduced it. It looks like I need to include a dummy > .perltidyrc file > with the distribution and apply it in the filter_example.t script. I'll do > that in the > next release. > > I do include testing at Travis CI as you suggested last time. > Steve >
Thanks, Steve! BTW, see https://www.shlomifish.org/meta/FAQ/#your_name regarding "Schlomi". Show quoted text
> On Sat, Nov 17, 2018 at 7:06 AM Steven Hancock via RT < > bug-Perl-Tidy@rt.cpan.org> wrote: >
> > Queue: Perl-Tidy > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=127679 > > > > > Hi Schlomi, > > Thanks for he notes - I'm not sure what what is going on - do I need to > > make a change? > > Steve > > > > On Sat, Nov 17, 2018 at 3:33 AM Shlomi Fish via RT < > > bug-Perl-Tidy@rt.cpan.org> wrote: > >
> > > Sat Nov 17 06:33:29 2018: Request 127679 was acted upon. > > > Transaction: Ticket created by SHLOMIF > > > Queue: Perl-Tidy > > > Subject: "cpan -i Perl::Tidy" fails the tests on Linux > > > Broken in: (no value) > > > Severity: (no value) > > > Owner: Nobody > > > Requestors: SHLOMIF@cpan.org > > > Status: new > > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=127679 > > > > > > > > > > example output: > > > > > > --------------- > > > cp lib/Perl/Tidy/VerticalAligner.pm blib/lib/Perl/Tidy/VerticalAligner.pm > > > cp lib/Perl/Tidy/Debugger.pm blib/lib/Perl/Tidy/Debugger.pm > > > cp lib/Perl/Tidy/Formatter.pm blib/lib/Perl/Tidy/Formatter.pm > > > cp lib/Perl/Tidy/VerticalAligner/Alignment.pm > > > blib/lib/Perl/Tidy/VerticalAligner/Alignment.pm > > > cp lib/Perl/Tidy/LineSink.pm blib/lib/Perl/Tidy/LineSink.pm > > > cp lib/Perl/Tidy/Logger.pm blib/lib/Perl/Tidy/Logger.pm > > > cp lib/Perl/Tidy.pod blib/lib/Perl/Tidy.pod > > > cp lib/Perl/Tidy/IOScalarArray.pm blib/lib/Perl/Tidy/IOScalarArray.pm > > > cp lib/Perl/Tidy/FileWriter.pm blib/lib/Perl/Tidy/FileWriter.pm > > > cp lib/Perl/Tidy/Diagnostics.pm blib/lib/Perl/Tidy/Diagnostics.pm > > > cp lib/Perl/Tidy/VerticalAligner/Line.pm > > > blib/lib/Perl/Tidy/VerticalAligner/Line.pm > > > cp lib/Perl/Tidy/IndentationItem.pm blib/lib/Perl/Tidy/IndentationItem.pm > > > cp lib/Perl/Tidy/Tokenizer.pm blib/lib/Perl/Tidy/Tokenizer.pm > > > cp lib/Perl/Tidy/IOScalar.pm blib/lib/Perl/Tidy/IOScalar.pm > > > cp lib/Perl/Tidy/DevNull.pm blib/lib/Perl/Tidy/DevNull.pm > > > cp lib/Perl/Tidy/HtmlWriter.pm blib/lib/Perl/Tidy/HtmlWriter.pm > > > cp lib/Perl/Tidy/LineSource.pm blib/lib/Perl/Tidy/LineSource.pm > > > cp lib/Perl/Tidy/LineBuffer.pm blib/lib/Perl/Tidy/LineBuffer.pm > > > cp lib/Perl/Tidy.pm blib/lib/Perl/Tidy.pm > > > Manifying 3 pod documents > > > SHANCOCK/Perl-Tidy-20181117.tar.gz > > > /usr/bin/make -- OK > > > Running make test > > > PERL_DL_NONLAZY=1 > > > "/home/shlomif/apps/perl/brew/perls/perl-5.26.2/bin/perl" > > > "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef > > > *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t > > > t/filter_example.t .. 1/1 # Test 1 got: "use > > > Method::Signatures::Simple;\nmethod foo1 { $self->bar }\n\n# with > > > signature\nmethod foo2 ( $bar, %opts )\n{\n $self->bar( reverse $bar ) > > > if $opts{rev};\n}\n\n# attributes\nmethod foo3 : lvalue\n{\n > > > $self->{foo};\n}\n\n# change invocant name\nmethod foo4 ($class: $bar) { > > > $class->bar($bar) }\n" (t/filter_example.t at line 65) > > > # Expected: "use Method::Signatures::Simple;\nmethod foo1 { $self->bar > > > }\n\n# with signature\nmethod foo2 ( $bar, %opts ) {\n $self->bar( > > > reverse $bar ) if $opts{rev};\n}\n\n# attributes\nmethod foo3 : lvalue
> > {\n
> > > $self->{foo};\n}\n\n# change invocant name\nmethod > > > foo4 ($class: $bar) { $class->bar($bar) }\n" > > > # (Install the Algorithm::Diff module to have differences in
> > multiline
> > > # output explained. You might also set the PERL_TEST_DIFF
> > environment
> > > # variable to run a diff program on the output.) > > > # t/filter_example.t line 65 is: ok( $output, $expect ); > > > t/filter_example.t .. Failed 1/1 subtests > > > t/snippets1.t ....... ok > > > t/snippets10.t ...... ok > > > t/snippets11.t ...... ok > > > t/snippets12.t ...... ok > > > t/snippets13.t ...... ok > > > t/snippets2.t ....... ok > > > t/snippets3.t ....... ok > > > t/snippets4.t ....... ok > > > t/snippets5.t ....... ok > > > t/snippets6.t ....... ok > > > t/snippets7.t ....... ok > > > t/snippets8.t ....... ok > > > t/snippets9.t ....... ok > > > t/test.t ............ ok > > > t/testsa.t .......... ok > > > t/testss.t .......... ok > > > t/testwide.t ........ ok > > > > > > Test Summary Report > > > ------------------- > > > t/filter_example.t (Wstat: 0 Tests: 1 Failed: 1) > > > Failed test: 1 > > > Files=18, Tests=261, 19 wallclock secs ( 0.12 usr 0.03 sys + 19.19 cusr > > > 0.23 csys = 19.57 CPU) > > > Result: FAIL > > > Failed 1/18 test programs. 1/261 subtests failed. > > > make: *** [Makefile:859: test_dynamic] Error 255 > > > SHANCOCK/Perl-Tidy-20181117.tar.gz > > > /usr/bin/make test -- NOT OK > > > //hint// to see the cpan-testers results for installing this module, try: > > > reports SHANCOCK/Perl-Tidy-20181117.tar.gz > > > [shlomif@telaviv1 ~]$ > > > ------------ > > > > > > tried with both perl 5.28.0 and 5.26.2 from perlbrew. > > > > > >
> > > >
-- ----------------------------------------------------------------- Shlomi Fish http://www.shlomifish.org/ https://github.com/shlomif/validate-your-html - Validate Your HTML Jessica on the phone: Sel, you’re getting strange lately, but you are becoming more amusing in the process. — http://www.shlomifish.org/humour/Selina-Mandrake/ Please reply to list if it's a mailing list post - http://shlom.in/reply .
I'll mark this as resolved. I have made a re-release without this test file just to be sure installations go smoothly.