Bug #127678 for Text-Hoborg: t/01.readability.t started to fail (with newer Lingua::EN::Fathom?)

Sat Nov 17 05:22:56 2018 SREZIC [...] cpan.org - Ticket created

CC:	kimryan [...] cpan.org
Subject:	t/01.readability.t started to fail (with newer Lingua::EN::Fathom?)

On my smokers the test suite started to fail: ... # Testing Text::Hoborg 0.0.6 # Fog = 8.54621273430978 # Kincaid = 5.85545877846095 # Flesch = 80.1582067557828 # Failed test 'Kincaid value 5.85545877846095 better than 6' # at t/01.readability.t line 24. # '5.85545877846095' # > # '6' # Failed test 'Flesch better 80.1582067557828 better than 80' # at t/01.readability.t line 27. # '80.1582067557828' # < # '80' # Looks like you failed 2 tests of 6. t/01.readability.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/6 subtests ... Statistical analysis suggests that this happens with Lingua::EN::Fathom 1.22: **************************************************************** Regression 'mod:Lingua::EN::Fathom' **************************************************************** Name Theta StdErr T-stat [0='const'] 1.0000 0.0000 12386971615704800.00 [1='eq_1.18'] 0.0000 0.0000 4.61 [2='eq_1.19'] 0.0000 0.0000 2.73 [3='eq_1.22'] -1.0000 0.0000 -12227133027394554.00 R^2= 1.000, N= 110, K= 4 ****************************************************************

Sat Nov 17 05:34:43 2018 kimryan [...] cpan.org - Correspondence added

This bug was only in version 1.2.1. It has already been fixed in 1.22

Sat Nov 17 05:34:43 2018 The RT System itself - Status changed from 'new' to 'open'

Sat Nov 17 11:22:28 2018 SREZIC [...] cpan.org - Correspondence added

RT-Send-CC:

kimryan [...] cpan.org

On 2018-11-17 05:34:43, KIMRYAN wrote: Show quoted text

> This bug was only in version 1.2.1. It has already been fixed in 1.22

I assume you mean 1.21 instead of 1.2.1, and I assume you are referring to Lingua::EN::Fathom versions, and not to Text::Hoborg versions (which this issue is about). Was there a behaviour change between Lingua::En::Sentence 1.19 and 1.22? Could it be that using Lingua::En::Sentence now changed something which causes the Text-Hoborg test suite now to fail?

Sun Nov 18 17:22:05 2018 kimryan [...] cpan.org - Correspondence added

On Sat Nov 17 11:22:28 2018, SREZIC wrote: Show quoted text

> On 2018-11-17 05:34:43, KIMRYAN wrote:

> > This bug was only in version 1.2.1. It has already been fixed in 1.22

> > I assume you mean 1.21 instead of 1.2.1, and I assume you are > referring to Lingua::EN::Fathom versions, and not to Text::Hoborg > versions (which this issue is about). > > Was there a behaviour change between Lingua::En::Sentence 1.19 and > 1.22? Could it be that using Lingua::En::Sentence now changed > something which causes the Text-Hoborg test suite now to fail?

Sorry, didn't look at the error message carefully enough. I have enhanced the way sentences are counted, but this means that all the statistical values have changed slightly. So the tests for Text-Hoborg will either need to be updated to these new values, or removed. I have found tests based on floating point calcualtions a bit problematic, so I just test for the underlying constants and not the derived calculations.