Skip Menu |

This queue is for tickets about the Data-TreeDumper-Utils CPAN distribution.

Report information
The Basics
Id: 127670
Status: open
Priority: 0/
Queue: Data-TreeDumper-Utils
People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.04.4
Fixed in: (no value)

History Show all quoted text
  Sat Nov 17 04:05:15 2018 SREZIC [...] cpan.org - Ticket created
Subject: 'no warnings' test started to fail
On my smokers the test suite started to fail: ... # Failed test 'no warnings' # at /usr/local/lib/perl5/5.26/Test/Builder.pm line 135. # There were 66 warning(s) # Previous test 0 '' # Use of uninitialized value $columns in string eq at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40-3/blib/lib/Data/TreeDumper.pm line 786. # at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40-3/blib/lib/Data/TreeDumper.pm line 786. # Data::TreeDumper::RenderNode(1, "ZZZ", 0, "", "|- ", "| ", 3, 1, ...) called at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40-3/blib/lib/Data/TreeDumper.pm line 575 # Data::TreeDumper::RenderElementName(ARRAY(0x43674a38), 1, "ZZZ", 1, SCALAR(0x43795120), 0, ARRAY(0x437fa090), HASH(0x437fa0c0), ...) called at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40-3/blib/lib/Data/TreeDumper.pm line 368 # Data::TreeDumper::TreeDumper(HASH(0x41e314b0), HASH(0x437f8d38)) called at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40-3/blib/lib/Data/TreeDumper.pm line 228 # Data::TreeDumper::DumpTree(HASH(0x41e314b0), "structure:", "FILTER", CODE(0x42cf9750), "FILTER_ARGUMENT", HASH(0x41e65210)) called at t/002_utils.t line 21 # # ---------- # Previous test 0 '' # Use of uninitialized value $columns in string eq at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40-3/blib/lib/Data/TreeDumper.pm line 786. # at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40-3/blib/lib/Data/TreeDumper.pm line 786. # Data::TreeDumper::RenderNode(1, "A", 0, "", "|- ", "| ", 3, 1, ...) called at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40-3/blib/lib/Data/TreeDumper.pm line 575 # Data::TreeDumper::RenderElementName(ARRAY(0x43674a38), 1, "A", 1, SCALAR(0x42bfd258), 0, ARRAY(0x437fa090), HASH(0x437fa0c0), ...) called at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40-3/blib/lib/Data/TreeDumper.pm line 368 # Data::TreeDumper::TreeDumper(HASH(0x41e314b0), HASH(0x437f8d38)) called at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40-3/blib/lib/Data/TreeDumper.pm line 228 # Data::TreeDumper::DumpTree(HASH(0x41e314b0), "structure:", "FILTER", CODE(0x42cf9750), "FILTER_ARGUMENT", HASH(0x41e65210)) called at t/002_utils.t line 21 # # ---------- ... (snip) ... # # Looks like you failed 1 test of 8. t/002_utils.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests ...
  Sat Nov 17 04:54:23 2018 SREZIC [...] cpan.org - Correspondence added
RT-Send-CC: ferreira [...] cpan.org
On 2018-11-17 04:05:15, SREZIC wrote: Show quoted text
> On my smokers the test suite started to fail: > > ... > # Failed test 'no warnings' > # at /usr/local/lib/perl5/5.26/Test/Builder.pm line 135. > # There were 66 warning(s) > # Previous test 0 '' > # Use of uninitialized value $columns in string eq at > /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40- > 3/blib/lib/Data/TreeDumper.pm line 786. > # at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40- > 3/blib/lib/Data/TreeDumper.pm line 786. > # Data::TreeDumper::RenderNode(1, "ZZZ", 0, "", "|- ", "| ", 3, > 1, ...) called at /home/cpansand/.cpan/build/2018111706/Data- > TreeDumper-0.40-3/blib/lib/Data/TreeDumper.pm line 575 > # Data::TreeDumper::RenderElementName(ARRAY(0x43674a38), 1, > "ZZZ", 1, SCALAR(0x43795120), 0, ARRAY(0x437fa090), HASH(0x437fa0c0), > ...) called at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper- > 0.40-3/blib/lib/Data/TreeDumper.pm line 368 > # Data::TreeDumper::TreeDumper(HASH(0x41e314b0), > HASH(0x437f8d38)) called at > /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40- > 3/blib/lib/Data/TreeDumper.pm line 228 > # Data::TreeDumper::DumpTree(HASH(0x41e314b0), "structure:", > "FILTER", CODE(0x42cf9750), "FILTER_ARGUMENT", HASH(0x41e65210)) > called at t/002_utils.t line 21 > # > # ---------- > # Previous test 0 '' > # Use of uninitialized value $columns in string eq at > /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40- > 3/blib/lib/Data/TreeDumper.pm line 786. > # at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40- > 3/blib/lib/Data/TreeDumper.pm line 786. > # Data::TreeDumper::RenderNode(1, "A", 0, "", "|- ", "| ", 3, > 1, ...) called at /home/cpansand/.cpan/build/2018111706/Data- > TreeDumper-0.40-3/blib/lib/Data/TreeDumper.pm line 575 > # Data::TreeDumper::RenderElementName(ARRAY(0x43674a38), 1, "A", > 1, SCALAR(0x42bfd258), 0, ARRAY(0x437fa090), HASH(0x437fa0c0), ...) > called at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40- > 3/blib/lib/Data/TreeDumper.pm line 368 > # Data::TreeDumper::TreeDumper(HASH(0x41e314b0), > HASH(0x437f8d38)) called at > /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40- > 3/blib/lib/Data/TreeDumper.pm line 228 > # Data::TreeDumper::DumpTree(HASH(0x41e314b0), "structure:", > "FILTER", CODE(0x42cf9750), "FILTER_ARGUMENT", HASH(0x41e65210)) > called at t/002_utils.t line 21 > # > # ---------- > ... (snip) ... > # > # Looks like you failed 1 test of 8. > t/002_utils.t .. > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/8 subtests > ...
Looking at the code it seems that an undefined $columns may happen only in this line: eval "(\$columns, \$rows) = Term::Size::chars *STDOUT{IO} ;" ; Indeed, if I install a recent Term::Size, then it always fails.
  Tue Jun 09 10:03:33 2020 ste+cpan [...] junkomatic.net - Correspondence added
On Sat Nov 17 04:54:23 2018, SREZIC wrote: Show quoted text
> On 2018-11-17 04:05:15, SREZIC wrote:
> > On my smokers the test suite started to fail: > > > > ... > > # Failed test 'no warnings' > > # at /usr/local/lib/perl5/5.26/Test/Builder.pm line 135. > > # There were 66 warning(s) > > # Previous test 0 '' > > # Use of uninitialized value $columns in string eq at > > /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40- > > 3/blib/lib/Data/TreeDumper.pm line 786. > > # at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40- > > 3/blib/lib/Data/TreeDumper.pm line 786. > > # Data::TreeDumper::RenderNode(1, "ZZZ", 0, "", "|- ", "| ", > > 3, > > 1, ...) called at /home/cpansand/.cpan/build/2018111706/Data- > > TreeDumper-0.40-3/blib/lib/Data/TreeDumper.pm line 575 > > # Data::TreeDumper::RenderElementName(ARRAY(0x43674a38), 1, > > "ZZZ", 1, SCALAR(0x43795120), 0, ARRAY(0x437fa090), HASH(0x437fa0c0), > > ...) called at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper- > > 0.40-3/blib/lib/Data/TreeDumper.pm line 368 > > # Data::TreeDumper::TreeDumper(HASH(0x41e314b0), > > HASH(0x437f8d38)) called at > > /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40- > > 3/blib/lib/Data/TreeDumper.pm line 228 > > # Data::TreeDumper::DumpTree(HASH(0x41e314b0), "structure:", > > "FILTER", CODE(0x42cf9750), "FILTER_ARGUMENT", HASH(0x41e65210)) > > called at t/002_utils.t line 21 > > # > > # ---------- > > # Previous test 0 '' > > # Use of uninitialized value $columns in string eq at > > /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40- > > 3/blib/lib/Data/TreeDumper.pm line 786. > > # at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40- > > 3/blib/lib/Data/TreeDumper.pm line 786. > > # Data::TreeDumper::RenderNode(1, "A", 0, "", "|- ", "| ", 3, > > 1, ...) called at /home/cpansand/.cpan/build/2018111706/Data- > > TreeDumper-0.40-3/blib/lib/Data/TreeDumper.pm line 575 > > # Data::TreeDumper::RenderElementName(ARRAY(0x43674a38), 1, > > "A", > > 1, SCALAR(0x42bfd258), 0, ARRAY(0x437fa090), HASH(0x437fa0c0), ...) > > called at /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40- > > 3/blib/lib/Data/TreeDumper.pm line 368 > > # Data::TreeDumper::TreeDumper(HASH(0x41e314b0), > > HASH(0x437f8d38)) called at > > /home/cpansand/.cpan/build/2018111706/Data-TreeDumper-0.40- > > 3/blib/lib/Data/TreeDumper.pm line 228 > > # Data::TreeDumper::DumpTree(HASH(0x41e314b0), "structure:", > > "FILTER", CODE(0x42cf9750), "FILTER_ARGUMENT", HASH(0x41e65210)) > > called at t/002_utils.t line 21 > > # > > # ---------- > > ... (snip) ... > > # > > # Looks like you failed 1 test of 8. > > t/002_utils.t .. > > Dubious, test returned 1 (wstat 256, 0x100) > > Failed 1/8 subtests > > ...
> > Looking at the code it seems that an undefined $columns may happen > only in this line: > > eval "(\$columns, \$rows) = Term::Size::chars *STDOUT{IO} ;" ; > > Indeed, if I install a recent Term::Size, then it always fails.
No doubt due to this change in Term::Size: 0.208 2018-08-20 Term-Size ( TRIAL VERSION ) - use PerlIO instead of FILE* RT#38594 - On error, Term::Size functions now return undef in scalar context, or an empty list on list context RT#76292 Suggest changing TreeDumper.pm L786 to: if(! $columns || $columns eq '')
  Tue Jun 09 10:03:34 2020 The RT System itself - Status changed from 'new' to 'open'