Bug #127595 for App-GitHub-Repository: Perl::Critic tests may fail

Wed Nov 07 14:00:39 2018 SREZIC [...] cpan.org - Ticket created

Subject:

Perl::Critic tests may fail

Probably depends on which perlcritic policies are installed: ... # Failed test 'Test::Perl::Critic for "blib/lib/App/GitHub/Repository.pm"' # at /usr/perl5.16.3t/lib/site_perl/5.16.3/Test/Perl/Critic.pm line 121. # # Variable, subroutine, and package names have to be in CamelCase at line 24, column 6. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 25, column 6. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 26, column 6. (no explanation). (Severity: 5) ... (etc) ... # Variable, subroutine, and package names have to be in CamelCase at line 99, column 6. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 100, column 10. (no explanation). (Severity: 5) t/perlcritic.t .... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests

Fri Nov 09 11:52:49 2018 ether [...] cpan.org - Correspondence added

On 2018-11-07 11:00:39, SREZIC wrote: Show quoted text

> Probably depends on which perlcritic policies are installed:

While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Fri Nov 09 11:52:50 2018 The RT System itself - Status changed from 'new' to 'open'