Skip Menu |

This queue is for tickets about the Devel-Chitin CPAN distribution.

Report information
The Basics
Id: 127414
Status: resolved
Priority: 0/
Queue: Devel-Chitin
People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.16
Fixed in: (no value)

History Show all quoted text
  Sun Oct 21 03:50:33 2018 ANDK [...] cpan.org - Ticket created
Subject: Fails on perl >= v5.29.3-62-gd8ff3e95e0
As per subject. This is the commit that breaks its testsuite: https://perl5.git.perl.org/perl.git/commitdiff/d8ff3e95e0 Sample fail report: http://www.cpantesters.org/cpan/report/7507d21a-d35b-11e8-94d2-0b623a478bbf
  Sun Oct 21 03:54:52 2018 ANDK [...] cpan.org - Correspondence added
Cross reference: https://rt.perl.org/Public/Bug/Display.html?id=133602
  Sun Oct 21 11:09:19 2018 jkeenan [...] cpan.org - Correspondence added
On Sun Oct 21 03:50:33 2018, ANDK wrote: Show quoted text
> As per subject. This is the commit that breaks its testsuite: > https://perl5.git.perl.org/perl.git/commitdiff/d8ff3e95e0 Sample fail > report: http://www.cpantesters.org/cpan/report/7507d21a-d35b-11e8- > 94d2-0b623a478bbf
Anthony Brummett: In most cases a simple replacement of 'dump' with 'CORE::dump' has been sufficient to mitigate this fatalization, which is now present in perl-5.29.4 and going forward. I cloned your git repository and tried that approach, but it was not sufficient in this case due to the complexity of the code. A "global search-and-replace" still left 3 test files failing. Can you investigate? Thank you very much. Jim Keenan
  Sun Oct 21 11:09:20 2018 The RT System itself - Status changed from 'new' to 'open'
  Mon Oct 22 10:45:16 2018 jkeenan [...] cpan.org - Correspondence added
On Sun Oct 21 11:09:19 2018, JKEENAN wrote: Show quoted text
> On Sun Oct 21 03:50:33 2018, ANDK wrote:
> > As per subject. This is the commit that breaks its testsuite: > > https://perl5.git.perl.org/perl.git/commitdiff/d8ff3e95e0 Sample fail > > report: http://www.cpantesters.org/cpan/report/7507d21a-d35b-11e8- > > 94d2-0b623a478bbf
> > > Anthony Brummett: > > In most cases a simple replacement of 'dump' with 'CORE::dump' has > been sufficient to mitigate this fatalization, which is now present in > perl-5.29.4 and going forward. > > I cloned your git repository and tried that approach, but it was not > sufficient in this case due to the complexity of the code. A "global > search-and-replace" still left 3 test files failing. > > Can you investigate? > > Thank you very much. > Jim Keenan
Please evaluate pull request: https://github.com/brummett/Devel-Chitin/pull/72 This passes all its tests when run against perl-5.29.4. Thank you very much. Jim Keenan
  Wed Oct 24 17:29:12 2018 BRUMMETT [...] cpan.org - Correspondence added
Merged the PR and made a new release of Devel::Chitin to CPAN that includes the fix.
  Wed Oct 24 17:29:13 2018 BRUMMETT [...] cpan.org - Status changed from 'open' to 'resolved'