Bug #127251 for HTML-DOM: Fails with bleadperl

Fri Sep 28 14:37:40 2018 ANDK [...] cpan.org - Ticket created

Subject:

Fails with bleadperl

Bisect: https://perl5.git.perl.org/perl.git/commit/c22e17d0af Sample fail report: http://www.cpantesters.org/cpan/report/adce4072-c21f-11e8-98db-990c88d669c2

Sun Oct 21 12:04:27 2018 jkeenan [...] cpan.org - Correspondence added

On Fri Sep 28 14:37:40 2018, ANDK wrote: Show quoted text

> Bisect: https://perl5.git.perl.org/perl.git/commit/c22e17d0af > > Sample fail report: http://www.cpantesters.org/cpan/report/adce4072- > c21f-11e8-98db-990c88d669c2

Failure confirmed when tested against perl-5.29.4 on FreeBSD-11.1 as part of "CPAN River 3000" testing. ##### { author => "SPROUT", dist => "HTML-DOM", distname => "HTML-DOM-0.058", distversion => 0.058, grade => "FAIL", prereqs => undef, test_output => [ "Building and testing HTML-DOM-0.058", "cp lib/HTML/DOM/Element/Form.pm blib/lib/HTML/DOM/Element/Form.pm", ... "cp lib/HTML/DOM/Comment.pm blib/lib/HTML/DOM/Comment.pm", "PERL_DL_NONLAZY=1 \"/usr/home/jkeenan/var/tad/testing/perl-5.29.4/bin/perl\" \"-MExtUtils::Command::MM\" \"-MTest::Harness\" \"-e\" \"undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')\" t/*.t", "t/attr.t ...................... ok", ... "t/html-dom-interface.t ........ ok", "Assigning non-zero to \$[ is no longer possible at t/html-dom.t line 68.", "# Looks like your test exited with 2 just after 3.", "t/html-dom.t .................. ", "Dubious, test returned 2 (wstat 512, 0x200)", "Failed 51/54 subtests ", "t/html-element.t .............. ok", ... "t/views.t ..................... ok", "", "Test Summary Report", "-------------------", "t/html-dom.t (Wstat: 512 Tests: 3 Failed: 0)", " Non-zero exit status: 2", " Parse errors: Bad plan. You planned 54 tests but ran 3.", "Files=31, Tests=3259, 5 wallclock secs ( 0.09 usr 0.28 sys + 3.55 cusr 1.30 csys = 5.21 CPU)", "Result: FAIL", ], via => "App::cpanminus::reporter 0.17 (1.7044)", ##### Thank you very much. Jim Keenan

Sun Oct 21 12:04:28 2018 The RT System itself - Status changed from 'new' to 'open'

Sun Oct 21 12:54:07 2018 jkeenan [...] cpan.org - Correspondence added

On Sun Oct 21 12:04:27 2018, JKEENAN wrote: Show quoted text

> On Fri Sep 28 14:37:40 2018, ANDK wrote:

> > Bisect: https://perl5.git.perl.org/perl.git/commit/c22e17d0af > > > > Sample fail report: http://www.cpantesters.org/cpan/report/adce4072- > > c21f-11e8-98db-990c88d669c2

> > Failure confirmed when tested against perl-5.29.4 on FreeBSD-11.1 as > part of "CPAN River 3000" testing. > > ##### > { > author => "SPROUT", > dist => "HTML-DOM", > distname => "HTML-DOM-0.058", > distversion => 0.058, > grade => "FAIL", > prereqs => undef, > test_output => [ > "Building and testing HTML-DOM-0.058", > "cp lib/HTML/DOM/Element/Form.pm > blib/lib/HTML/DOM/Element/Form.pm", > ... > "cp lib/HTML/DOM/Comment.pm blib/lib/HTML/DOM/Comment.pm", > "PERL_DL_NONLAZY=1 \"/usr/home/jkeenan/var/tad/testing/perl- > 5.29.4/bin/perl\" \"-MExtUtils::Command::MM\" \"-MTest::Harness\" \"- > e\" \"undef *Test::Harness::Switches; test_harness(0, 'blib/lib', > 'blib/arch')\" t/*.t", > "t/attr.t ...................... ok", > ... > "t/html-dom-interface.t ........ ok", > "Assigning non-zero to \$[ is no longer possible at t/html-dom.t > line 68.", > "# Looks like your test exited with 2 just after 3.", > "t/html-dom.t .................. ", > "Dubious, test returned 2 (wstat 512, 0x200)", > "Failed 51/54 subtests ", > "t/html-element.t .............. ok", > ... > "t/views.t ..................... ok", > "", > "Test Summary Report", > "-------------------", > "t/html-dom.t (Wstat: 512 Tests: 3 Failed: 0)", > " Non-zero exit status: 2", > " Parse errors: Bad plan. You planned 54 tests but ran 3.", > "Files=31, Tests=3259, 5 wallclock secs ( 0.09 usr 0.28 sys + > 3.55 cusr 1.30 csys = 5.21 CPU)", > "Result: FAIL", > ], > via => "App::cpanminus::reporter 0.17 (1.7044)", > ##### > > Thank you very much. > Jim Keenan

Please consider the patch attached. Thank you very much. Jim Keenan

Subject:

HTML-DOM-t-html-dom-t.diff

--- t/html-dom.t.orig 2018-10-21 12:42:03.151861348 -0400 +++ t/html-dom.t 2018-10-21 12:51:42.646258898 -0400 @@ -64,20 +64,17 @@ $doc->close; { - no warnings 'deprecated'; - local $[ = 1; - use warnings 'deprecated'; my @p_tags = $doc->body->childNodes; - for(1..6){ - is $p_tags[$_]->tagName, 'P', + for(0..5){ + is $p_tags[$_]->tagName, 'P', "body\'s child node no. $_ is a P elem"; isa_ok $p_tags[$_]->firstChild, 'HTML::DOM::Text', "first child of para $_"; - like $p_tags[$_]->firstChild->data, qr/Para $_\b/, + my $exp_para_number = $_ + 1; + like $p_tags[$_]->firstChild->data, qr/Para $exp_para_number\b/, "contents of para $_"; } } - { my $script = $doc->createElement('script'); $script->appendChild($doc->createTextNode('$doc->title("scred")'));