Bug #127128 for Module-Version: Random t/app.t failures

Mon Sep 17 10:11:12 2018 SREZIC [...] cpan.org - Ticket created

Subject:

Random t/app.t failures

See subject. More information: * http://matrix.cpantesters.org/?dist=Module-Version+0.13 * http://analysis.cpantesters.org/reports_by_field?distv=Module-Version-0.13;field=fail%3At%2Fapp.t

Tue Sep 18 11:11:14 2018 hasch-cpan [...] cozap.com - Correspondence added

Subject:

[PATCH] Random t/app.t failures

Looks like a simple mistake in the test suite. I'd suggest to remove a line with no plausible meaning. -Martin

Subject:

Module-Version-0.13-MHASCH-01.patch

diff -rup Module-Version-0.13.orig/t/app.t Module-Version-0.13/t/app.t --- Module-Version-0.13.orig/t/app.t 2018-08-26 22:55:37.000000000 +0200 +++ Module-Version-0.13/t/app.t 2018-09-18 16:57:34.914127640 +0200 @@ -43,7 +43,6 @@ my $run = sub { $app->run() }; # check run() without input $app->{'modules'} = ['Test::More']; my $ver = $Test::More::VERSION; - $ver = '1.3021350'; $ver =~ s/0+$//; stdout_is( $run, "$ver\n", 'run() ok - regular' ); }

Tue Sep 18 11:11:14 2018 The RT System itself - Status changed from 'new' to 'open'

Tue Sep 18 11:39:35 2018 hasch-cpan [...] cozap.com - Correspondence added

It turns out that dropping the line that assigns some constant to $ver is not always sufficient. With Test::More v1.302140, say, the output actually has a trailing zero. A more robust approach might be to normalize both strings before comparing them. Anybody with deeper insights, please comment. -Martin

Thu Sep 20 10:50:23 2018 SREZIC [...] cpan.org - Correspondence added

On 2018-09-18 11:39:35, MHASCH wrote: Show quoted text

> It turns out that dropping the line that assigns some > constant to $ver is not always sufficient. > With Test::More v1.302140, say, the output actually has > a trailing zero. > > A more robust approach might be to normalize both strings > before comparing them. Anybody with deeper insights, > please comment. >

Here's an alternative patch which hopefully does not care if there's a trailing zero or not: http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/Module-Version-0.13-RT127128.patch

Thu Dec 20 01:58:38 2018 SREZIC [...] cpan.org - Broken in 0.200 added