Skip Menu |

This queue is for tickets about the MooseX-Getopt CPAN distribution.

Report information
The Basics
Id: 127096
Status: rejected
Priority: 0/
Queue: MooseX-Getopt
People
Owner: Nobody in particular
Requestors: TODDR [...] cpan.org
Cc: gregoa [...] cpan.org
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.73
Fixed in: (no value)

History Show all quoted text
  Wed Sep 12 02:36:10 2018 TODDR [...] cpan.org - Ticket created
Subject: Re-location of exit for help caused unit test failures in Catalyst
ppisar opened a ticket that Catalyst unit tests started failing when run against 0.73 of MooseX-Getopt. I confirmed this by reverting 3a5b2f44f3e31ca7a8e0dfbbfa57a2e9d89ba527 at which point the unit tests for Catalyst started passing again. The Catalyst RT ticket is: https://rt.cpan.org/Ticket/Display.html?id=127050 The commit which caused the unit test break is: https://github.com/moose/MooseX-Getopt/commit/3a5b2f44f3e31ca7a8e0dfbbfa57a2e9d89ba527 Can you advise? Thanks, Todd
  Sun Sep 16 22:46:53 2018 ether [...] cpan.org - Correspondence added
On 2018-09-11 23:36:10, TODDR wrote: Show quoted text
> ppisar opened a ticket that Catalyst unit tests started failing when > run against 0.73 of MooseX-Getopt. I confirmed this by reverting > 3a5b2f44f3e31ca7a8e0dfbbfa57a2e9d89ba527 at which point the unit tests > for Catalyst started passing again. > > The Catalyst RT ticket is: > https://rt.cpan.org/Ticket/Display.html?id=127050 > > The commit which caused the unit test break is: > https://github.com/moose/MooseX- > Getopt/commit/3a5b2f44f3e31ca7a8e0dfbbfa57a2e9d89ba527 > > Can you advise? > > Thanks, > Todd
MooseX::Getopt moved where the 'exit' happens -- it's no longer in the sub that the Catalyst tests are overwriting. I haven't heard about any other issues in other code, so as of yet I'm undecided as to whether it's necessary to provide an option to stop the exit from happening. It's always an option to override *CORE::GLOBAL::exit, and doing so would not be unreasonable in a unit test.
  Sun Sep 16 22:46:54 2018 The RT System itself - Status changed from 'new' to 'open'
  Sat Sep 22 12:55:28 2018 gregoa [...] cpan.org - Cc GREGOA added
  Sun Sep 23 20:19:26 2018 ether [...] cpan.org - Correspondence added
hearing nothing, I have made no additional changes, save for a doc update.
  Sun Sep 23 20:19:28 2018 ether [...] cpan.org - Status changed from 'open' to 'rejected'