Skip Menu |

This queue is for tickets about the Gtk3 CPAN distribution.

Report information
The Basics
Id: 127071
Status: resolved
Priority: 0/
Queue: Gtk3

People
Owner: Nobody in particular
Requestors: gregoa [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



From: gregoa [...] cpan.org
Subject: libgtk3-perl: FTBFS: t/overrides.t failure with gdk-pixbuf 2.38.0
We have the following bug reported to the Debian package of Gtk3 (https://bugs.debian.org/908323): It doesn't seem to be a bug in the packaging, so you may want to take a look. Thanks! ------8<-----------8<-----------8<-----------8<-----------8<----- Source: libgtk3-perl Version: 0.034-1 Severity: serious User: debian-perl@lists.debian.org Usertags: autopkgtest Control: block 902557 with -1 As noticed by the autopkgtest checks on ci.debian.net, this package fails its test suite on current sid, making it also fail to build from source. https://ci.debian.net/data/autopkgtest/unstable/amd64/libg/libgtk3-perl/953602/log.gz Undefined subroutine &Gtk3::Gdk::PIXDATA_HEADER_LENGTH called at /<<PKGBUILDDIR>>/blib/lib/Gtk3.pm line 2119. # Looks like your test exited with 255 just after 162. [...] Test Summary Report ------------------- t/overrides.t (Wstat: 65280 Tests: 162 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 233 tests but ran 162. Files=22, Tests=843, 5 wallclock secs ( 0.18 usr 0.03 sys + 4.58 cusr 0.46 csys = 5.25 CPU) Result: FAIL I'm guessing this regressed with gdk-pixbuf 2.38.0+dfsg-1 or so, but I haven't verified that (and the ci.debian.net machinery doesn't seem to have pinpointed it yet either.) -- Niko Tyni ntyni@debian.org ------8<-----------8<-----------8<-----------8<-----------8<----- https://bugs.debian.org/908323 contains some more debugging attempts. Thanks for considering, gregor herrmann, Debian Perl Group
It seems that Gtk3 works again - with the attached patch to adjust to the separate introspection data for the GdkPixdata API - and with (Debian's) gir1.2-gdkpixbuf-2.0 (>= 2.38.0+dfsg-5) which has a patch that fixes the gir metadata for GdkPixbuf: https://salsa.debian.org/gnome-team/gdk-pixbuf/blob/debian/master/debian/patches/build-Include-gdk-pixdata.c-when-building-GdkPixbuf-2.0.g.patch Cheers, gregor
Subject: gdk-pixbuf-2.38.patch
Description: Adjust for gdk-pixbuf 2.38 which generate separate introspection data for the GdkPixdata API Origin: vendor Bug: https://rt.cpan.org/Ticket/Display.html?id=127071 Forwarded: https://rt.cpan.org/Ticket/Display.html?id=127071 Bug-Debian: https://bugs.debian.org/908323 Author: gregor herrmann <gregoa@debian.org> Last-Update: 2018-09-13 --- a/lib/Gtk3.pm +++ b/lib/Gtk3.pm @@ -60,6 +60,7 @@ Gtk-3.0 | Gtk3 Gdk-3.0 | Gtk3::Gdk GdkPixbuf-2.0 | Gtk3::Gdk + GdkPixdata-2.0| Gtk3::Gdk Pango-1.0 | Pango =cut @@ -84,6 +85,10 @@ my $_GDK_PIXBUF_VERSION = '2.0'; my $_GDK_PIXBUF_PACKAGE = 'Gtk3::Gdk'; +my $_GDK_PIXDATA_BASENAME = 'GdkPixdata'; +my $_GDK_PIXDATA_VERSION = '2.0'; +my $_GDK_PIXDATA_PACKAGE = 'Gtk3::Gdk'; + my $_PANGO_BASENAME = 'Pango'; my $_PANGO_VERSION = '1.0'; my $_PANGO_PACKAGE = 'Pango'; @@ -472,6 +477,11 @@ flatten_array_ref_return_for => \@_GDK_PIXBUF_FLATTEN_ARRAY_REF_RETURN_FOR); Glib::Object::Introspection->setup ( + basename => $_GDK_PIXDATA_BASENAME, + version => $_GDK_PIXDATA_VERSION, + package => $_GDK_PIXDATA_PACKAGE); + + Glib::Object::Introspection->setup ( basename => $_PANGO_BASENAME, version => $_PANGO_VERSION, package => $_PANGO_PACKAGE);
Thanks for the patch. I committed a similar change with an added version check: <https://gitlab.gnome.org/GNOME/perl-gtk3/commit/88bc49e7a21da0131b10546aa07ebdf98d18a37e>.