Bug #127001 for RT-Extension-HistoryFilter: History is also filtered on other pages like the group admin page

Thu Aug 30 16:51:43 2018 BPS [...] cpan.org - Ticket created

Subject:

History is also filtered on other pages like the group admin page

Hi CLOOS, We recently noticed that the filtering happens on other pages that use the ShowHistory templates, like the group history page. I see the code currently does this check: return if $request_path =~ m{^/Ticket/History\.html}; What would you think of a patch that runs only on Ticket/Display.html rather than checking for and not running on the ticket history page? This would also then exclude all of the other places ShowHistory is used. Thanks, Jim

Wed Sep 05 03:04:54 2018 CLOOS [...] cpan.org - Taken

Wed Sep 05 03:12:11 2018 CLOOS [...] cpan.org - Correspondence added

Hi Jim, I have changed it already in my Github repo (https://github.com/cloos/RT-Extension-HistoryFilter/commit/bc5bc7f), but didn't pushed a new version to CPAN. I will do this within the next days. I tried before using a whitelist, which wasn't so simple as it sounds first, see comments removed in commit https://github.com/cloos/RT-Extension-HistoryFilter/commit/e3f275f Regards Christian On Thu Aug 30 16:51:43 2018, BPS wrote: Show quoted text

> Hi CLOOS, > > We recently noticed that the filtering happens on other pages that use > the ShowHistory templates, like the group history page. I see the code > currently does this check: > > return if $request_path =~ m{^/Ticket/History\.html}; > > What would you think of a patch that runs only on Ticket/Display.html > rather than checking for and not running on the ticket history page? > This would also then exclude all of the other places ShowHistory is > used. > > Thanks, > Jim

Wed Sep 05 03:12:12 2018 The RT System itself - Status changed from 'new' to 'open'

Wed Sep 05 03:12:29 2018 CLOOS [...] cpan.org - Broken in 2.02 added

Fri Sep 07 13:48:09 2018 BPS [...] cpan.org - Correspondence added

On Wed Sep 05 03:12:11 2018, CLOOS wrote: Show quoted text

> Hi Jim, > > I have changed it already in my Github repo > (https://github.com/cloos/RT-Extension-HistoryFilter/commit/bc5bc7f), > but didn't pushed a new version to CPAN. I will do this within the > next days.

Excellent, thanks for the update. Looks good based on our testing. We'll watch for the new release. Thanks, Jim

Fri Oct 19 09:25:12 2018 CLOOS [...] cpan.org - Fixed in 2.03 added

Fri Oct 19 09:26:54 2018 CLOOS [...] cpan.org - Correspondence added

This is fixed in version 2.03 available from CPAN.

Fri Oct 19 09:26:54 2018 CLOOS [...] cpan.org - Status changed from 'open' to 'resolved'