| Subject: | lib/Test/Smoke/Archiver.pm: typo in 4 log messages |
| Date: | Sun, 12 Aug 2018 14:09:29 -0400 |
| To: | bug-Test-Smoke [...] rt.cpan.org |
| From: | James E Keenan <jkeenan [...] pobox.com> |
In lib/Test/Smoke/Archiver.pm there are four methods pertaining to
archiving of individual generated files which have similar code:
#####
$ grep -n '^sub archive_' lib/Test/Smoke/Archiver.pm | grep -v archive_files
119:sub archive_rpt {
144:sub archive_out {
169:sub archive_jsn {
194:sub archive_log {
#####
#####
$ ack -A1 -B2 exits lib
lib/Test/Smoke/Archiver.pm
125- my $dst = catfile($self->adir, sprintf("rpt%s.rpt",
$self->patchlevel));
126- if (-f $dst) {
127: return $self->log_info("%s exits, skip archive rpt", $dst);
128- }
--
150- my $dst = catfile($self->adir, sprintf("out%s.out",
$self->patchlevel));
151- if (-f $dst) {
152: return $self->log_info("%s exits, skip archive out", $dst);
153- }
--
175- my $dst = catfile($self->adir, sprintf("jsn%s.jsn",
$self->patchlevel));
176- if (-f $dst) {
177: return $self->log_info("%s exits, skip archive jsn", $dst);
178- }
--
200- my $dst = catfile($self->adir, sprintf("log%s.log",
$self->patchlevel));
201- if (-f $dst) {
202: return $self->log_info("%s exits, skip archive log", $dst);
203- }
#####
In each case, if the log file whose name is stored in $dst already
exists, we compose a log message indicating we are skipping over the
archiving of that file and returning from the caller to
Test::Smoke::Archiver::archive_files().
In each case, the log message is incorrect. It ought to be:
#####
%s exists, skip archive ...
#####
I will provide a patch to correct the problem.
Thank you very much.
Jim Keenan