Skip Menu |

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 126028
Status: resolved
Priority: 0/
Queue: Net-SSLeay
People
Owner: chrisn [...] cpan.org
Requestors: jplesnik [...] redhat.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.85
Fixed in: 1.86_05

History Show all quoted text
  Thu Aug 09 09:52:03 2018 jplesnik [...] redhat.com - Ticket created
Subject: VARARG Errors - Coverity results
Could you please fix the error found by coverity static analysis tool results for Net-SSLeay-1.85? Error: VARARGS (CWE-237)[#def1] Net-SSLeay-1.85/SSLeay.xs:224: va_init: Initializing va_list "args". Net-SSLeay-1.85/SSLeay.xs:228: missing_va_end: va_end was not called for "args". # 226| warn("%s",buf); # 227| } # 228|-> } # 229| # 230| #include "constants.c" Possible fix is attached.
Subject: Net-SSLeay-1.85-Fix-coverity-error.patch
diff -up Net-SSLeay-1.85/SSLeay.xs.orig Net-SSLeay-1.85/SSLeay.xs --- Net-SSLeay-1.85/SSLeay.xs.orig 2018-08-09 14:11:40.536771171 +0200 +++ Net-SSLeay-1.85/SSLeay.xs 2018-08-09 14:13:13.286377460 +0200 @@ -224,6 +224,7 @@ static void TRACE(int level,char *msg,.. va_start(args,msg); vsnprintf(buf,4095,msg,args); warn("%s",buf); + va_end(args); } }
  Thu Aug 09 13:45:12 2018 chrisn [...] cpan.org - Correspondence added
On Thu Aug 09 14:52:03 2018, jplesnik wrote: Show quoted text
> Could you please fix the error found by coverity static analysis tool > results for Net-SSLeay-1.85? > > Error: VARARGS (CWE-237)[#def1] > Net-SSLeay-1.85/SSLeay.xs:224: va_init: Initializing va_list "args". > Net-SSLeay-1.85/SSLeay.xs:228: missing_va_end: va_end was not called > for "args". > # 226| warn("%s",buf); > # 227| } > # 228|-> } > # 229| > # 230| #include "constants.c" > > Possible fix is attached.
Thanks, Jitka - patch applied, with minor modifications to credit you in Changes: https://github.com/radiator-software/p5-net-ssleay/pull/30 This will be included in the next developer release (1.86_05) and the next stable release after that.
  Thu Aug 09 13:45:14 2018 The RT System itself - Status changed from 'new' to 'open'
  Thu Aug 09 13:45:15 2018 chrisn [...] cpan.org - Status changed from 'open' to 'patched'
  Thu Aug 09 13:45:15 2018 chrisn [...] cpan.org - Taken
  Fri Aug 24 12:35:13 2018 chrisn [...] cpan.org - Status changed from 'patched' to 'resolved'
  Fri Aug 24 12:35:13 2018 chrisn [...] cpan.org - Fixed in 1.86_05 added