Skip Menu |

This queue is for tickets about the Net-Ping CPAN distribution.

Report information
The Basics
Id: 126007
Status: resolved
Priority: 0/
Queue: Net-Ping
People
Owner: RURBAN [...] cpan.org
Requestors: mike [...] scottsonline.org.uk
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Aug 06 08:58:50 2018 mike [...] scottsonline.org.uk - Ticket created
Subject: bug in Net-Ping-2.68-0
Date: Mon, 6 Aug 2018 09:11:01 +0100
To: bug-Net-Ping [...] rt.cpan.org
From: Mike Scott <mike [...] scottsonline.org.uk>
Net::Ping reports Argument "2.020_03" isn't numeric in numeric ge (>=) at /usr/local/lib/perl5/5.26/Net/Ping.pm line 1801. on first call. This relates to the code segment at 1801: # address check # new way if ($Socket::VERSION >= 1.94) { my %hints = ( It's not safe to assume versions are numeric - this is on FreeBSD 11.x, where I see that % grep VERS /usr/local/lib/perl5/5.26/mach/Socket.pm our $VERSION = '2.020_03'; # patched in perl5.git XSLoader::load(__PACKAGE__, $VERSION); The intricacies of perl module version numbers are not something I'm familiar with; even if FBSD be breaking a convention, version checks ought to be done safely where rules cannot be enforced. % perl -v This is perl 5, version 26, subversion 2 (v5.26.2) built for i386-freebsd-thread-multi-64int % uname -a FreeBSD data.scotts 11.2-RELEASE FreeBSD 11.2-RELEASE #0: Wed Jul 25 10:34:56 BST 2018 mike@data.scotts:/usr/src/sys/i386/compile/DATA i386 % -- Mike Scott Harlow, Essex, England
  Mon Aug 06 09:02:39 2018 RURBAN [...] cpan.org - Taken
  Mon Aug 06 09:07:40 2018 RURBAN [...] cpan.org - Correspondence added
This was already fixed in commit 80388908f57e7b6, RT #125677 released with 2.67. $Socket_VERSION = eval { $Socket::VERSION }; ... Can you please recheck your Net::Ping version number? -- Reini Urban
  Mon Aug 06 09:07:40 2018 The RT System itself - Status changed from 'new' to 'open'
  Mon Aug 06 09:07:41 2018 RURBAN [...] cpan.org - Status changed from 'open' to 'resolved'
  Mon Aug 06 10:35:33 2018 mike [...] scottsonline.org.uk - Correspondence added
Subject: Re: [rt.cpan.org #126007] bug in Net-Ping-2.68-0
Date: Mon, 6 Aug 2018 15:35:06 +0100
To: bug-Net-Ping [...] rt.cpan.org
From: Mike Scott <mike [...] scottsonline.org.uk>
On 06/08/18 14:07, Reini Urban via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=126007 > > > This was already fixed in commit 80388908f57e7b6, RT #125677 > released with 2.67. > > $Socket_VERSION = eval { $Socket::VERSION }; > ... > > Can you please recheck your Net::Ping version number? >
Thanks for your prompt response. Something odd going on. I've been trying to load this from cpan, and ended up with 2 different versions on the machine (2.55 and 2.68). That's fixed now - but sometimes it gives an error on install, and sometimes not. I currently find, this is definitely with /usr/local/lib/perl5/site_perl/Net/Ping.pm at version "2.68" (stepping through with debug): 1854: if (defined($h{port}) && (($h{port} !~ /^\d{1,5}$/) || ($h{port} < 1) || ($h{port} > 65535))) { DB<3> Net::Ping::_resolv(/usr/local/lib/perl5/site_perl/Net/Ping.pm:1862): 1862: if ($Socket_VERSION > 1.94) { DB<3> p $Socket_VERSION 2.020_03 DB<4> n Argument "2.020_03" isn't numeric in numeric gt (>) at /usr/local/lib/perl5/site_perl/Net/Ping.pm line 1862. at /usr/local/lib/perl5/site_perl/Net/Ping.pm line 1862. ===== (That's the only one installed AFAICS; I had to use 'notest install Net::Ping' to install, otherwise I got: t/400_ping_syn.t ....... 14/14 # Failed test 'supposed to be up: http://172.29.249.249/' # at t/400_ping_syn.t line 96. # got: '0' # expected: '1' # NOTE: Network connectivity will be required for all tests to pass. # Firewalls may also cause some tests to fail, so test it on a clear network. # Looks like you failed 1 test of 14. t/400_ping_syn.t ....... Dubious, test returned 1 (wstat 256, 0x100) Is that host really "supposed to be up" - 172.29.x.x is private, is it not? It seems my ISP allows iana private addresses as far as their router, at which point I get 'Communication prohibited by filter' (after 30 or icmp packets or so). Does this affect the testing? -- Mike Scott Harlow, Essex, England
  Mon Aug 06 10:53:14 2018 mike [...] scottsonline.org.uk - Correspondence added
Subject: Re: [rt.cpan.org #126007] bug in Net-Ping-2.68-0
Date: Mon, 6 Aug 2018 15:53:03 +0100
To: bug-Net-Ping [...] rt.cpan.org
From: Mike Scott <mike [...] scottsonline.org.uk>
On 06/08/18 14:07, Reini Urban via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=126007 > > > This was already fixed in commit 80388908f57e7b6, RT #125677 > released with 2.67. > > $Socket_VERSION = eval { $Socket::VERSION }; > ... > > Can you please recheck your Net::Ping version number? >
Further to my last email - I've tightened up on my firewall, and now the module tests all run successfully. It looks as though the one test makes some assumptions about the network that aren't in general necessarily true. I still get the original 'non-numeric' failure though; which doesn't seem to have been fixed in 2.68 -- Mike Scott Harlow, Essex, England