Bug #125941 for Sport-Analytics-NHL: t/405-main-compile.t fails (with newer Storable?)

Fri Jul 27 13:41:45 2018 slaven [...] rezic.de - Ticket created

Subject:

t/405-main-compile.t fails (with newer Storable?)

On some of my smoker systems the test suite fails: ... File t/tmp/data/2011/0002/0010/BS.storable already exists, skipping File t/tmp/data/2011/0002/0010/ES.storable already exists, skipping File t/tmp/data/2011/0002/0010/GS.storable already exists, skipping File t/tmp/data/2011/0002/0010/PL.storable already exists, skipping File t/tmp/data/2011/0002/0010/RO.storable already exists, skipping No storable file and no-compile option specified, skipping t/405-main-compile.t .............. All 9 subtests passed ... Test Summary Report ------------------- t/405-main-compile.t (Wstat: 11 Tests: 9 Failed: 0) Non-zero wait status: 11 Parse errors: No plan found in TAP output ... Statistical analysis suggests that this happens if a newer Storable version is installed (>= 3.08): **************************************************************** Regression 'mod:Storable' **************************************************************** Name Theta StdErr T-stat [0='const'] 1.0000 0.0000 21143508779509700.00 [1='eq_2.53'] 0.0000 0.0000 2.97 [2='eq_2.53_01'] 0.0000 0.0000 2.93 [3='eq_2.53_02'] 0.0000 0.0000 4.11 [4='eq_2.56'] 0.0000 0.0000 0.00 [5='eq_2.56_01'] 0.0000 0.0000 5.21 [6='eq_2.62'] -0.0000 0.0000 -2.97 [7='eq_3.08'] -1.0000 0.0000 -11728308468883890.00 [8='eq_3.09'] -1.0000 0.0000 -11728308468883882.00 [9='eq_3.11'] -1.0000 0.0000 -18310815728194712.00 R^2= 1.000, N= 64, K= 10 ****************************************************************

Fri Aug 03 22:47:52 2018 rparparov [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #125941] t/405-main-compile.t fails (with newer Storable?)
Date:	Fri, 3 Aug 2018 19:47:31 -0700
To:	bug-Sport-Analytics-NHL [...] rt.cpan.org
From:	Roman Parparov <rparparov [...] gmail.com>

Hi Slaven, I don't have Storable 3+ versions and I can't reproduce the bug. Does it happen both when you're bulk testing and when you run something like perl -I./lib t/405-main-compile.t Thanks, R. On 7/27/18 10:41 AM, slaven@rezic.de via RT wrote: Show quoted text

> Fri Jul 27 13:41:45 2018: Request 125941 was acted upon. > Transaction: Ticket created by slaven@rezic.de > Queue: Sport-Analytics-NHL > Subject: t/405-main-compile.t fails (with newer Storable?) > Broken in: 1.20 > Severity: (no value) > Owner: Nobody > Requestors: slaven@rezic.de > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=125941 > > > > On some of my smoker systems the test suite fails: > > ... > File t/tmp/data/2011/0002/0010/BS.storable already exists, skipping > File t/tmp/data/2011/0002/0010/ES.storable already exists, skipping > File t/tmp/data/2011/0002/0010/GS.storable already exists, skipping > File t/tmp/data/2011/0002/0010/PL.storable already exists, skipping > File t/tmp/data/2011/0002/0010/RO.storable already exists, skipping > No storable file and no-compile option specified, skipping > t/405-main-compile.t .............. > All 9 subtests passed > ... > Test Summary Report > ------------------- > t/405-main-compile.t (Wstat: 11 Tests: 9 Failed: 0) > Non-zero wait status: 11 > Parse errors: No plan found in TAP output > ... > > Statistical analysis suggests that this happens if a newer Storable version is installed (>= 3.08): > > **************************************************************** > Regression 'mod:Storable' > **************************************************************** > Name Theta StdErr T-stat > [0='const'] 1.0000 0.0000 21143508779509700.00 > [1='eq_2.53'] 0.0000 0.0000 2.97 > [2='eq_2.53_01'] 0.0000 0.0000 2.93 > [3='eq_2.53_02'] 0.0000 0.0000 4.11 > [4='eq_2.56'] 0.0000 0.0000 0.00 > [5='eq_2.56_01'] 0.0000 0.0000 5.21 > [6='eq_2.62'] -0.0000 0.0000 -2.97 > [7='eq_3.08'] -1.0000 0.0000 -11728308468883890.00 > [8='eq_3.09'] -1.0000 0.0000 -11728308468883882.00 > [9='eq_3.11'] -1.0000 0.0000 -18310815728194712.00 > > R^2= 1.000, N= 64, K= 10 > ****************************************************************

Fri Aug 03 22:47:53 2018 The RT System itself - Status changed from 'new' to 'open'

Sun Aug 05 01:43:42 2018 ANDK [...] cpan.org - Correspondence added

Storable 3.11 is on the CPAN, you should be able to install it. It leads to a SIGBUS. Here is a table that shows it happens with all Storable > 3 and with a wide range of perl versions. http://analysis.cpantesters.org/reports_by_field?SUBMIT_xxx=Submit&distv=Sport-Analytics-NHL-1.30&field=mod%3AStorable&field=meta%3Aperl&field=mod%3AStorable&order=2nd Here is a stack trace: Core was generated by `/home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.22.4/da1c/bin/per'. Program terminated with signal SIGBUS, Bus error. #0 retrieve_overloaded (cxt=0x558322719660, cname=<optimized out>) at Storable.xs:5490 5490 Storable.xs: No such file or directory. (gdb) bt #0 retrieve_overloaded (cxt=0x558322719660, cname=<optimized out>) at Storable.xs:5490 #1 0x00007f206f289c95 in retrieve (cxt=cxt@entry=0x558322719660, cname=cname@entry=0x0) at Storable.xs:7322 #2 0x00007f206f28ca2e in retrieve_hash (cxt=0x558322719660, cname=<optimized out>) at Storable.xs:6461 #3 0x00007f206f289c95 in retrieve (cxt=cxt@entry=0x558322719660, cname=cname@entry=0x0) at Storable.xs:7322 #4 0x00007f206f28a836 in retrieve_ref (cxt=0x558322719660, cname=0x0) at Storable.xs:5382 #5 0x00007f206f289c95 in retrieve (cxt=cxt@entry=0x558322719660, cname=cname@entry=0x0) at Storable.xs:7322 #6 0x00007f206f28cd07 in retrieve_array (cxt=0x558322719660, cname=<optimized out>) at Storable.xs:6264 #7 0x00007f206f289c95 in retrieve (cxt=cxt@entry=0x558322719660, cname=cname@entry=0x0) at Storable.xs:7322 #8 0x00007f206f28a836 in retrieve_ref (cxt=0x558322719660, cname=0x0) at Storable.xs:5382 #9 0x00007f206f289c95 in retrieve (cxt=cxt@entry=0x558322719660, cname=cname@entry=0x0) at Storable.xs:7322 #10 0x00007f206f28ca2e in retrieve_hash (cxt=0x558322719660, cname=<optimized out>) at Storable.xs:6461 #11 0x00007f206f289c95 in retrieve (cxt=cxt@entry=0x558322719660, cname=cname@entry=0x7ffe84b57be0 "Sport::Analytics::NHL::Report::BS") at Storable.xs:7322 #12 0x00007f206f28a6bd in retrieve_blessed (cxt=0x558322719660, cname=<optimized out>) at Storable.xs:4845 #13 0x00007f206f289c95 in retrieve (cxt=cxt@entry=0x558322719660, cname=cname@entry=0x0) at Storable.xs:7322 #14 0x00007f206f28dfe3 in do_retrieve (f=f@entry=0x5583225eea70, in=in@entry=0x0, optype=2, optype@entry=0, flags=<optimized out>) at Storable.xs:7512 #15 0x00007f206f28e504 in pretrieve (flag=<optimized out>, f=0x5583225eea70) at Storable.xs:7617 #16 XS_Storable_pretrieve (cv=<optimized out>) at Storable.xs:7830 #17 0x000055832091b4df in Perl_pp_entersub () at pp_hot.c:3272 #18 0x00005583209145c3 in Perl_runops_standard () at run.c:41 #19 0x00005583208a9643 in S_run_body (oldscope=<optimized out>) at perl.c:2443 #20 perl_run (my_perl=<optimized out>) at perl.c:2371 #21 0x0000558320885682 in main (argc=<optimized out>, argv=<optimized out>, env=<optimized out>) at perlmain.c:116

Mon Aug 06 09:28:50 2018 rparparov [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #125941] t/405-main-compile.t fails (with newer Storable?)
Date:	Sun, 5 Aug 2018 16:22:49 -0700
To:	bug-Sport-Analytics-NHL [...] rt.cpan.org
From:	Roman Parparov <rparparov [...] gmail.com>

Hi Andreas, I found it! It was caused by the difference in the API between Storable 2.xx and 3.xx: 2.xx sub retrieve { _retrieve($_[0], 0); } 3.xx sub retrieve { _retrieve(shift, 0, @_); } so the third is_deeply() argument was gobbled up by retrieve as an extra one, and this time used fatally. I'll issue a fix today. The owner of Storable might need to be notified. Thanks for your vigilance, Perl Testers! R. On 8/4/18 10:43 PM, Andreas Koenig via RT wrote: Show quoted text

> Queue: Sport-Analytics-NHL > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=125941 > > > Storable 3.11 is on the CPAN, you should be able to install it. It leads to a SIGBUS. Here is a table that shows it happens with all Storable > 3 and with a wide range of perl versions. > > http://analysis.cpantesters.org/reports_by_field?SUBMIT_xxx=Submit&distv=Sport-Analytics-NHL-1.30&field=mod%3AStorable&field=meta%3Aperl&field=mod%3AStorable&order=2nd > > Here is a stack trace: > > Core was generated by `/home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.22.4/da1c/bin/per'. > Program terminated with signal SIGBUS, Bus error. > #0 retrieve_overloaded (cxt=0x558322719660, cname=<optimized out>) at Storable.xs:5490 > 5490 Storable.xs: No such file or directory. > (gdb) bt > #0 retrieve_overloaded (cxt=0x558322719660, cname=<optimized out>) at Storable.xs:5490 > #1 0x00007f206f289c95 in retrieve (cxt=cxt@entry=0x558322719660, cname=cname@entry=0x0) > at Storable.xs:7322 > #2 0x00007f206f28ca2e in retrieve_hash (cxt=0x558322719660, cname=<optimized out>) > at Storable.xs:6461 > #3 0x00007f206f289c95 in retrieve (cxt=cxt@entry=0x558322719660, cname=cname@entry=0x0) > at Storable.xs:7322 > #4 0x00007f206f28a836 in retrieve_ref (cxt=0x558322719660, cname=0x0) at Storable.xs:5382 > #5 0x00007f206f289c95 in retrieve (cxt=cxt@entry=0x558322719660, cname=cname@entry=0x0) > at Storable.xs:7322 > #6 0x00007f206f28cd07 in retrieve_array (cxt=0x558322719660, cname=<optimized out>) > at Storable.xs:6264 > #7 0x00007f206f289c95 in retrieve (cxt=cxt@entry=0x558322719660, cname=cname@entry=0x0) > at Storable.xs:7322 > #8 0x00007f206f28a836 in retrieve_ref (cxt=0x558322719660, cname=0x0) at Storable.xs:5382 > #9 0x00007f206f289c95 in retrieve (cxt=cxt@entry=0x558322719660, cname=cname@entry=0x0) > at Storable.xs:7322 > #10 0x00007f206f28ca2e in retrieve_hash (cxt=0x558322719660, cname=<optimized out>) > at Storable.xs:6461 > #11 0x00007f206f289c95 in retrieve (cxt=cxt@entry=0x558322719660, > cname=cname@entry=0x7ffe84b57be0 "Sport::Analytics::NHL::Report::BS") at Storable.xs:7322 > #12 0x00007f206f28a6bd in retrieve_blessed (cxt=0x558322719660, cname=<optimized out>) > at Storable.xs:4845 > #13 0x00007f206f289c95 in retrieve (cxt=cxt@entry=0x558322719660, cname=cname@entry=0x0) > at Storable.xs:7322 > #14 0x00007f206f28dfe3 in do_retrieve (f=f@entry=0x5583225eea70, in=in@entry=0x0, optype=2, > optype@entry=0, flags=<optimized out>) at Storable.xs:7512 > #15 0x00007f206f28e504 in pretrieve (flag=<optimized out>, f=0x5583225eea70) at Storable.xs:7617 > #16 XS_Storable_pretrieve (cv=<optimized out>) at Storable.xs:7830 > #17 0x000055832091b4df in Perl_pp_entersub () at pp_hot.c:3272 > #18 0x00005583209145c3 in Perl_runops_standard () at run.c:41 > #19 0x00005583208a9643 in S_run_body (oldscope=<optimized out>) at perl.c:2443 > #20 perl_run (my_perl=<optimized out>) at perl.c:2371 > #21 0x0000558320885682 in main (argc=<optimized out>, argv=<optimized out>, env=<optimized out>) > at perlmain.c:116 >