On Tue Jul 24 12:56:10 2018, DWRIGHT wrote:
Show quoted text> On Mon Jul 23 17:28:46 2018, IVAN wrote:
> > On Mon Jul 23 11:20:55 2018, DWRIGHT wrote:
> > > Hello,
> > >
> > > In version 0.31 of Business::CreditCard, cards beginning in 3056 we
> > > re-categorized from Diners Club to Discover Cards.
> > >
> > > However, somewhere between version 0.34 and 0.36, they were re-
> > > categorized again from Discover to "Unknown".
> >
> > That is incorrect. Cards beginning in 3056 with 16-19 digits are
> > recognized correctly.
>
> Perhaps. However, Diner's Club cards only have 14 digits.
No. That is no longer the case, and has not been for many years.
Show quoted text
I believe that information to be incorrect. It is inconsistent with the latest BIN update I have seen from Discover in 2015. If you have an update from Discover dated newer that 2015, by all means, please share it (privately, they typically cannot be shared publicly.)
Show quoted text> This is the output with v0.33:
>
> perl -MBusiness::CreditCard -e ' print cardtype("30569309025904")'
> Discover card
>
> And here is the output with v0.36:
>
> perl -MBusiness::CreditCard -e ' print cardtype("30569309025904")'
> Unknown
>
> The behavior has changed in a way that is inconsistent with the POD.
No, the behavior has changed in a way that is consistent with the real world. That is no longer a valid Discover card, according to Discover. It hasn't been for many years, and probably wasn't even when 0.33 said it was.
The purpose of the module is to recognize real-world credit cards. I believe it does so correctly according to the latest documentation available from the relevant processor and owner of that BIN space.
If you feel the POD is inconsistent or misleading, you are welcome to send a patch to the documentation. I read through it again and I don't see what inconsistency you are referring to.
Show quoted text> > > The POD still states "Versions before 0.31 may also have returned
> > > "Diner's Club/Carte Blanche" (these cards are now recognized as
> > > "Discover card")." And I couldn't find anything in the Changelog
> > > that suggests that this was an intentional change.
> >
> > 0.34 Fri Feb 5 07:24:00 PST 2016
> > - 14 digit Discover remain only in 36*
>
> This ticket isn't about Discover cards, it's about Diner's Club cards.
There are no more Diner's Club cards. Diner's was acquired by Discover in 2008 and Diner's BINs are processed on the Discover network worldwide.
0.31 Mon Oct 19 18:51:35 PDT 2009
- Most Diner's Club cards (300-305, 3095 and 36) now processed as
Discover
Show quoted text> 14 digit Diner's club cards are still valid (as evidenced by the fact
> that Stripe.com still recommends testing them.)
I do not believe Stripe.com's page is better "evidence" than the information available from the actual card issuer in that BIN range. It is probably just out of date.
Show quoted text> And even if they
> were not still valid, I suggest there are use cases where it may be
> necessary to evaluate the card type of an expired card.
You "suggest", or you have an actual real-world use case for this?
Because that's a lot more than just recognizing Diner's from the past. If you want to know the type of cards from the past, you need to know both the processing country and date, and you'll need the start and end date of all historical processing agreements.
Business::CreditCard does not attempt to provide this kind of historical information. The scope of Business::CreditCard is to tell you what network you should accept a card on NOW, in your country. You know, the actual thing that everyone actually needs to use the module for.
Thanks for your input.
